X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 21686DC009E; Wed, 19 Nov 2014 07:42:34 +0000 (UTC) Date: Wed, 19 Nov 2014 08:42:32 +0100 From: Natanael Copa To: Alan Lacerda Cc: alpine-devel@lists.alpinelinux.org, Alan Lacerda Subject: Re: [alpine-devel] [PATCH] testing/exaile: new aport Message-ID: <20141119084232.4844b084@ncopa-desktop.alpinelinux.org> In-Reply-To: <1416333952-16286-1-git-send-email-alacerda@alpinelinux.org> References: <1416333952-16286-1-git-send-email-alacerda@alpinelinux.org> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 18 Nov 2014 18:05:52 +0000 Alan Lacerda wrote: > --- > testing/exaile/APKBUILD | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 testing/exaile/APKBUILD > > diff --git a/testing/exaile/APKBUILD b/testing/exaile/APKBUILD > new file mode 100644 > index 0000000..73de117 > --- /dev/null > +++ b/testing/exaile/APKBUILD > @@ -0,0 +1,44 @@ > +# Contributor: Alan Lacerda > +# Maintainer: Alan Lacerda > +pkgname=exaile > +pkgver=3.4.2 > +pkgrel=0 > +pkgdesc="A music player with a simple interface and powerful music management capabilities" > +url="http://www.exaile.org/" > +arch="noarch" > +license="GPL2" > +depends="gettext python" Are you sure we need gettext at runtime? Normally we don't. > +depends_dev="" > +makedepends="$depends_dev" > +install="" > +subpackages="" > +source="https://github.com/$pkgname/$pkgname/archive/$pkgver.tar.gz" > + > +_builddir="$srcdir/$pkgname-$pkgver" > +prepare() { > + local i > + cd "$_builddir" > + for i in $source; do > + case $i in > + *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;; > + esac > + done > +} > + > +build() { > + cd "$_builddir" > + make || return 1 > +} > + > +package() { > + cd "$_builddir" > + mkdir -p "$pkgdir"/usr/local "$pkgdir"/etc/xdb "$pkgdir"/lib > + make install PREFIX="$pkgdir"/usr/local \ This looks wrong. We should not install anything in /usr/local as that is reserved[1] for locally installed software (eg not managed with package manager). abuild normally complains if it finds stuff in /usr/local > + XDGCONFDIR="$pkgdir"/etc/xdb \ > + DESTDIR="$pkgdir"\ > + LIBINSTALLDIR="$pkgdir"/lib || return 1 libinstall dir /lib also looks wrong unless this package contains critical software needed for booting the system, things that is needed before /usr is mounted. > +} > + > +md5sums="ff0081f548bc17435877c2c65b05c9b8 3.4.2.tar.gz" > +sha256sums="0e280c317871e37cbe9db8d54d37a5bee99cf36ebd0f55048e41787d0461e4bf 3.4.2.tar.gz" > +sha512sums="1a13585afc4eaa2b03c3be0bd25394e8c6df824999b676349f6efeabe9286d7c773eaf5938d7a644e9facb9b6184c02cc465fe1ec0d22057ab2cb8a521357312 3.4.2.tar.gz" [1]: http://www.pathname.com/fhs/pub/fhs-2.3.html#USRLOCALLOCALHIERARCHY [2]: http://www.pathname.com/fhs/pub/fhs-2.3.html#LIBESSENTIALSHAREDLIBRARIESANDKERN --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---