X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 571C1DC009E; Wed, 19 Nov 2014 07:53:49 +0000 (UTC) Date: Wed, 19 Nov 2014 08:53:46 +0100 From: Natanael Copa To: Alan Lacerda Cc: alpine-devel@lists.alpinelinux.org, Alan Lacerda Subject: Re: [alpine-devel] [PATCH] testing/exaile: new aport Message-ID: <20141119085346.153ab518@ncopa-desktop.alpinelinux.org> In-Reply-To: <20141119084232.4844b084@ncopa-desktop.alpinelinux.org> References: <1416333952-16286-1-git-send-email-alacerda@alpinelinux.org> <20141119084232.4844b084@ncopa-desktop.alpinelinux.org> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 19 Nov 2014 08:42:32 +0100 Natanael Copa wrote: > On Tue, 18 Nov 2014 18:05:52 +0000 > Alan Lacerda wrote: ... > > +package() { > > + cd "$_builddir" > > + mkdir -p "$pkgdir"/usr/local "$pkgdir"/etc/xdb "$pkgdir"/lib > > + make install PREFIX="$pkgdir"/usr/local \ > > This looks wrong. We should not install anything in /usr/local as that > is reserved[1] for locally installed software (eg not managed with package > manager). > > abuild normally complains if it finds stuff in /usr/local I found out why abuild didn't stop you. It installs the file in under $pkgdir/ $pkdir/home/ncopa/aports/testing/exaile/pkg/exaile/usr/local/home/ncopa/aports/testing/exaile/pkg/exaile/lib/exaile/xlgui/devices.py which is way wrong. -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---