Date: Fri, 21 Nov 2014 08:33:30 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: =?ISO-8859-1?B?UmFmYSo=?= Rzepecki <divided.mind@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/pgagent: new aport
Message-ID: <20141121083330.736d8ec5@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1416518609-29322-1-git-send-email-divided.mind@gmail.com>
References: <1416518609-29322-1-git-send-email-divided.mind@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, 20 Nov 2014 16:23:29 -0500
Rafa* Rzepecki <divided.mind@gmail.com> wrote:

> http://www.pgadmin.org/docs/dev/pgagent.html
> a job scheduler for PostgreSQL
> ---
>  testing/pgagent/APKBUILD      | 64 +++++++++++++++++++++++++++++++++++++=
++++++
>  testing/pgagent/pgagent.confd | 22 +++++++++++++++
>  testing/pgagent/pgagent.initd | 25 +++++++++++++++++
>  3 files changed, 111 insertions(+)
>  create mode 100644 testing/pgagent/APKBUILD
>  create mode 100644 testing/pgagent/pgagent.confd
>  create mode 100644 testing/pgagent/pgagent.initd

Thanks! I applied it, but I have a few questions below.


> diff --git a/testing/pgagent/APKBUILD b/testing/pgagent/APKBUILD
> new file mode 100644
> index 0000000..ae9eaea
> --- /dev/null
> +++ b/testing/pgagent/APKBUILD
> @@ -0,0 +1,64 @@
> +# Contributor: Rafal Rzepecki <rafal@conjur.net>
> +# Maintainer:
> +pkgname=3Dpgagent
> +pkgver=3D3.4.0
> +pkgrel=3D0
> +pkgdesc=3D"a job scheduler for PostgreSQL"
> +url=3D"http://www.pgadmin.org/docs/dev/pgagent.html"
> +arch=3D"all"
> +license=3D"POSTGRESQL"
> +depends=3D"wxgtk2.8-base postgresql"

What does it need from wxgtk2.8-base that is not pulled in automatic as
SO (shared object) dependency? Normally abuild will automatically add
the dependencies for dynamic libs.

I n this case, abuild will automatically add so:libwx_baseu-2.8.so.0 as
a dependency which (currently) wxgtk2.8-base provides.

I suspect that wxgtk2.8-base can be removed from depends unless I am
missing something.

Does the server really need to run on the same server as the agent? If
not, then we should not have a hard dependency for the postgresql
server.

...

> diff --git a/testing/pgagent/pgagent.confd b/testing/pgagent/pgagent.confd
> new file mode 100644
> index 0000000..a85be20
> --- /dev/null
> +++ b/testing/pgagent/pgagent.confd
> @@ -0,0 +1,22 @@
> +# Pool time interval
> +PGA_POLL=3D"10"
> +
> +# Retry period
> +PGA_RETRY=3D"30"
> +
> +# Log file
> +PGA_LOG=3D"/var/log/pgagent.log"

Having the log file in /var/log means it needs to have root
permissions. Does the agent really need to run as root?

> diff --git a/testing/pgagent/pgagent.initd b/testing/pgagent/pgagent.initd
> new file mode 100644
> index 0000000..0e37fcc
> --- /dev/null
> +++ b/testing/pgagent/pgagent.initd
> @@ -0,0 +1,25 @@
> +#!/sbin/runscript
> +# Copyright 1999-2012 Gentoo Foundation
> +# Distributed under the terms of the GNU General Public License v2
> +# $Header: /var/cvsroot/gentoo-x86/dev-db/pgagent/files/pgagent.initd,v =
1.1 2012/04/28 18:34:11 titanofold Exp $
> +
> +PGAGENTOPT=3D"-t ${PGA_POLL} -r ${PGA_RETRY} -s ${PGA_LOG} -l ${PGA_LEVE=
L}"
> +
> +PGOPT=3D"hostaddr=3D${PG_HOST} dbname=3D${PG_DBNAME} user=3D${PG_USER}"
> +
> +depend() {
> +    use net
> +    need postgresql

Does the agent really require that a postgresql server runs on this
host even if the PG_HOST is pointing to some other host?

I suspect that you can actually run the agent on different host than the
postgresql server and in that case, you don't need postgresql. It
should probably say "use postgresql".

> +}
> +
> +start() {
> +    ebegin "Starting pgagent"
> +    start-stop-daemon --start --exec /usr/bin/pgagent -- ${PGAGENTOPT} $=
{PGOPT}
> +    eend $?
> +}
> +
> +stop() {
> +    ebegin "Stopping pgagent"
> +    start-stop-daemon --stop --name pgagent
> +    eend $?
> +}

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---