X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 175DFDC0BE6; Fri, 5 Dec 2014 13:35:01 +0000 (UTC) Date: Fri, 5 Dec 2014 14:34:58 +0100 From: Natanael Copa To: Valery Kartel Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [PATCH] testing/exim: post-install add SUID bit for correct --signal HUP reload Message-ID: <20141205143458.6a8ad0fa@ncopa-desktop.alpinelinux.org> In-Reply-To: <1417782491-11971-1-git-send-email-valery.kartel@gmail.com> References: <1417782491-11971-1-git-send-email-valery.kartel@gmail.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit No, we should not set suid bit in post-install. You can add options="suid" to make abuild not barf. On Fri, 5 Dec 2014 14:28:11 +0200 Valery Kartel wrote: > diff --git a/testing/exim/exim.logrotate b/testing/exim/exim.logrotate > index c923ed1..357652b 100644 > --- a/testing/exim/exim.logrotate > +++ b/testing/exim/exim.logrotate > @@ -8,6 +8,6 @@ > create 640 mail mail > sharedscripts > postrotate > - /etc/init.d/exim reload > /dev/null > + /etc/init.d/exim --quiet reload > endscript > } How about checking if it is actually running before reload? if /etc/init.d/exim --quiet status; then /etc/init.d/exim --quiet reload fi --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---