X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133])
	(using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: n@tanael.org)
	by mail.alpinelinux.org (Postfix) with ESMTPSA id 1BA4FDC082D;
	Tue, 16 Dec 2014 14:07:22 +0000 (UTC)
Date: Tue, 16 Dec 2014 15:07:19 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: k0r10n <k0r10n.dev@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/ecryptfs-utils: New aport
Message-ID: <20141216150719.48ce11c4@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1418273971-9668-1-git-send-email-k0r10n.dev@gmail.com>
References: <1418273971-9668-1-git-send-email-k0r10n.dev@gmail.com>
X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.23; x86_64-alpine-linux-musl)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 11 Dec 2014 08:59:31 +0400
k0r10n <k0r10n.dev@gmail.com> wrote:

> ---
>  testing/ecryptfs-utils/APKBUILD          | 56 ++++++++++++++++++++++++++++++++
>  testing/ecryptfs-utils/fix-headers.patch | 28 ++++++++++++++++
>  2 files changed, 84 insertions(+)
>  create mode 100644 testing/ecryptfs-utils/APKBUILD
>  create mode 100644 testing/ecryptfs-utils/fix-headers.patch

applied + some post fixes.

I have a question about the patch below:

...

> diff --git a/testing/ecryptfs-utils/fix-headers.patch b/testing/ecryptfs-utils/fix-headers.patch
> new file mode 100644
> index 0000000..eb2ca3e
> --- /dev/null
> +++ b/testing/ecryptfs-utils/fix-headers.patch
> @@ -0,0 +1,28 @@
> +--- a/src/utils/mount.ecryptfs.c.orig
> ++++ b/src/utils/mount.ecryptfs.c
> +@@ -24,7 +24,6 @@
> + #include <errno.h>
> + #include <fcntl.h>
> + #include <getopt.h>
> +-#include <keyutils.h>
> + #include <stdio.h>
> + #include <stdlib.h>
> + #include <string.h>
> +@@ -34,6 +33,7 @@
> + #include <sys/stat.h>
> + #include <sys/types.h>
> + #include <sys/wait.h>
> ++#include <keyutils.h>
> + #include "ecryptfs.h"
> + #include "decision_graph.h"
> + #include "io.h"

It looks like this only move the include of keyutils.h down? why is
that needed?

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---