From nobody Thu Mar 28 23:53:01 2024 X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-laptop (unknown [79.160.13.130]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 245B0DC009E for ; Thu, 25 Dec 2014 19:58:40 +0000 (UTC) Date: Thu, 25 Dec 2014 20:58:35 +0100 From: Natanael Copa To: alpine-devel@lists.alpinelinux.org Subject: [alpine-devel] busybox-1.23 in edge Message-ID: <20141225205835.397fac22@ncopa-laptop> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi, I pushed busybox 1.23 to edge. So far I found at least one regression[1] in ash and possibly another in modprobe. After upgrading my laptop (both new kernel and new busybox) it didn't load the ahci kernel module from initramfs so the harddisks was not found. I don't know if this is due to something in new busybox or in new kernel or if it affects other hardware. To continue boot up from initramfs emergency shell i did something like: for i in $(find /sys -name uevent); do echo add > "$i"; done lvm pvscan lvm vgchange -a y mount /dev/vg0/lv_root /sysroot exit If someone has time and wants to investigate, you could try install v3.1 in a vm, then upgrade to edge. (do snapshot before the upgrade). Please be careful if you are on edge now. Thanks! -nc [1]:http://lists.busybox.net/pipermail/busybox/2014-December/082129.html --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org --- From nobody Thu Mar 28 23:53:01 2024 X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id B489EDC009E for ; Fri, 26 Dec 2014 00:12:29 +0000 (UTC) Received: by mail-pa0-f52.google.com with SMTP id eu11so12330683pac.11 for ; Thu, 25 Dec 2014 16:12:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=USCA2OMQZDK1SXW4p+FUN45L8aSjnCOJWqf5qQ+dYsQ=; b=q299xMbnmCKylEOW21pAqCRYQEMO+VwajTnaE3MRIG7PtC0qRX7bSMTFywESP5E75Q KVOEV1Lra3Cucat5WVYZF5YHStFsWcKI1w9EwNCRrrAG3P3CBZsjDS3ZA57ZGU31R2QH HEF6L6a8mzdihffIJ5jrhnPqQU6UrPgE+rwXDd4i5ULAGFGpfbFIcDLP2TXXaEWnS8X8 E+PIp3463JyF6uwxOtWtMWsNM+RSH9vKDyITup+21GPANTIVR3iiQiAN4baG/4cJZx0Z CXwZ1TKzOuGTQqIWtknV3eyWJfMPrcaS+mXSzOIy+MYzo1PHv4PhQappD6ba8NlhdCCU dMMQ== X-Received: by 10.68.135.65 with SMTP id pq1mr63724668pbb.18.1419552748784; Thu, 25 Dec 2014 16:12:28 -0800 (PST) Received: from newbook ([50.0.224.95]) by mx.google.com with ESMTPSA id ri3sm26406140pdb.58.2014.12.25.16.12.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Dec 2014 16:12:28 -0800 (PST) Date: Thu, 25 Dec 2014 16:12:32 -0800 From: Isaac Dunham To: Natanael Copa Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] busybox-1.23 in edge Message-ID: <20141226001231.GB1793@newbook> References: <20141225205835.397fac22@ncopa-laptop> X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141225205835.397fac22@ncopa-laptop> User-Agent: Mutt/1.5.23 (2014-03-12) On Thu, Dec 25, 2014 at 08:58:35PM +0100, Natanael Copa wrote: > Hi, > > I pushed busybox 1.23 to edge. So far I found at least one regression[1] > in ash and possibly another in modprobe. > > After upgrading my laptop (both new kernel and new busybox) it didn't > load the ahci kernel module from initramfs so the harddisks was not > found. I don't know if this is due to something in new busybox or in > new kernel or if it affects other hardware. > > To continue boot up from initramfs emergency shell i did something like: > > for i in $(find /sys -name uevent); do echo add > "$i"; done > lvm pvscan > lvm vgchange -a y > mount /dev/vg0/lv_root /sysroot > exit > > If someone has time and wants to investigate, you could try install > v3.1 in a vm, then upgrade to edge. (do snapshot before the upgrade). > > Please be careful if you are on edge now. > > Thanks! > > -nc It sounds like it's a bug in busybox/whatever is doing coldplug; the kernel is creating a uevent entry that corresponds to the hardware, and it still has a modalias entry in ahci.ko (or you would need to modprobe ahci manually) Or it could be the kernel creating the uevent but not the modalias file--which is a known issue with some hardware; the workaround is to use something like this: find /sys -name uevent -exec grep -h MODALIAS= '{}' + | sort -u | \ cut -c 10- |xargs modprobe -a HTH, Isaac Dunham --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org --- From nobody Thu Mar 28 23:53:01 2024 X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 7A118DC0089; Fri, 26 Dec 2014 08:05:18 +0000 (UTC) Date: Fri, 26 Dec 2014 09:05:15 +0100 From: Natanael Copa To: Isaac Dunham Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] busybox-1.23 in edge Message-ID: <20141226090515.7f2f85ca@ncopa-desktop.alpinelinux.org> In-Reply-To: <20141226001231.GB1793@newbook> References: <20141225205835.397fac22@ncopa-laptop> <20141226001231.GB1793@newbook> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 25 Dec 2014 16:12:32 -0800 Isaac Dunham wrote: > On Thu, Dec 25, 2014 at 08:58:35PM +0100, Natanael Copa wrote: > > Hi, > > > > I pushed busybox 1.23 to edge. So far I found at least one regression[1] > > in ash and possibly another in modprobe. > > > > After upgrading my laptop (both new kernel and new busybox) it didn't > > load the ahci kernel module from initramfs so the harddisks was not > > found. I don't know if this is due to something in new busybox or in > > new kernel or if it affects other hardware. It did happen on my desktop too and I have a theory on whats going on. > > > > To continue boot up from initramfs emergency shell i did something like: > > > > for i in $(find /sys -name uevent); do echo add > "$i"; done > > lvm pvscan > > lvm vgchange -a y > > mount /dev/vg0/lv_root /sysroot > > exit > > > > If someone has time and wants to investigate, you could try install > > v3.1 in a vm, then upgrade to edge. (do snapshot before the upgrade). > > > > Please be careful if you are on edge now. > > > > Thanks! > > > > -nc > > It sounds like it's a bug in busybox/whatever is doing coldplug; Yes. > the > kernel is creating a uevent entry that corresponds to the hardware, > and it still has a modalias entry in ahci.ko (or you would need to > modprobe ahci manually) > Or it could be the kernel creating the uevent but not the modalias > file--which is a known issue with some hardware; > the workaround is to use something like this: > > find /sys -name uevent -exec grep -h MODALIAS= '{}' + | sort -u | \ > cut -c 10- |xargs modprobe -a Thank you very much for your input. I saw you suggested improvement in our couldplug earlier. I didn't spend time on it partly because I didn't feel it is broken, but mostly because I have some ideas how to do this part proplerly with a netlink listener. I tried your suggestion from emergency shell but disks didn't show up so I don't think its the kernel that has changed. I think its new busybox modprobe behavior introduced with upstream commit[1] 4e314faa0 (modprobe,rmmod: reject module names with slashes) I think what happens is that if a slash (/) is found in the probe name, modprobe will simply exit. We call it with: modprobe -a ... So it means it will load all modules up to first alias which contains a slash and then stop. ncopa-desktop:~# find /sys -name uevent -exec grep -h MODALIAS= '{}' + 2>/dev/null | sort -u | grep -E 'pci|/' MODALIAS=dmi:bvnDellInc.:bvrA07:bd09/10/2011:svnDellInc.:pnOptiPlex790:pvr01:rvnDellInc.:rn0HY9JP:rvrA00:cvnDellInc.:ct6:cvr: MODALIAS=pci:v00008086d00000100sv00001028sd000004ADbc06sc00i00 MODALIAS=pci:v00008086d00000102sv00001028sd000004ADbc03sc00i00 ... As you see, there are slashes in the dmi module and since we sort, dmi will always come before pci. So the disk controllers are never loaded and disks never found. I think we should revert the upstream commit for now. [1]:http://git.busybox.net/busybox/commit/modutils?id=4e314faa0aecb66717418e9a47a4451aec59262b --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org --- From nobody Thu Mar 28 23:53:01 2024 X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 76840DC0089; Fri, 26 Dec 2014 09:14:24 +0000 (UTC) Date: Fri, 26 Dec 2014 10:14:21 +0100 From: Natanael Copa To: Isaac Dunham Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] busybox-1.23 in edge Message-ID: <20141226101421.4b06160a@ncopa-desktop.alpinelinux.org> In-Reply-To: <20141226090515.7f2f85ca@ncopa-desktop.alpinelinux.org> References: <20141225205835.397fac22@ncopa-laptop> <20141226001231.GB1793@newbook> <20141226090515.7f2f85ca@ncopa-desktop.alpinelinux.org> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 26 Dec 2014 09:05:15 +0100 Natanael Copa wrote: > On Thu, 25 Dec 2014 16:12:32 -0800 > Isaac Dunham wrote: > > > On Thu, Dec 25, 2014 at 08:58:35PM +0100, Natanael Copa wrote: > > > Hi, > > > > > > I pushed busybox 1.23 to edge. So far I found at least one regression[1] > > > in ash and possibly another in modprobe. > > > > > > After upgrading my laptop (both new kernel and new busybox) it didn't > > > load the ahci kernel module from initramfs so the harddisks was not > > > found. I don't know if this is due to something in new busybox or in > > > new kernel or if it affects other hardware. > > It did happen on my desktop too and I have a theory on whats going on. ... > I think what happens is that if a slash (/) is found in the probe name, > modprobe will simply exit. We call it with: modprobe -a ... > > So it means it will load all modules up to first alias which contains a > slash and then stop. > > ncopa-desktop:~# find /sys -name uevent -exec grep -h MODALIAS= '{}' + 2>/dev/null | sort -u | grep -E 'pci|/' > MODALIAS=dmi:bvnDellInc.:bvrA07:bd09/10/2011:svnDellInc.:pnOptiPlex790:pvr01:rvnDellInc.:rn0HY9JP:rvrA00:cvnDellInc.:ct6:cvr: > MODALIAS=pci:v00008086d00000100sv00001028sd000004ADbc06sc00i00 > MODALIAS=pci:v00008086d00000102sv00001028sd000004ADbc03sc00i00 > ... > > As you see, there are slashes in the dmi module and since we sort, dmi > will always come before pci. So the disk controllers are never loaded > and disks never found. > > I think we should revert the upstream commit for now. I pushed a temp fix for busybox for now. I also bumped pkgrel for mkinitfs to force a regeneration with fixed busybox. The fixed was tested with success in qemu. Thanks! -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org --- From nobody Thu Mar 28 23:53:01 2024 X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id B8154DC006A for ; Fri, 26 Dec 2014 19:03:26 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id fp1so13327193pdb.24 for ; Fri, 26 Dec 2014 11:03:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=n0glod/6oGS2u78Ahr8l1eP49OItnoVG8V2GubG4Q9I=; b=eOntP9fh824fK5uihhLfi5x/ajQYPrsADjbQbIePp1VOLXFZ4WCmE9A75Ejw/ElmOP oX4tNhYwtmuWpCwohzoFhnAgbAKBRxngoFhI+7Rrg1QKqAtVdMzrGWg60lKWN9rynTvf a2oliOWsaksG2deW8YSkDQ07r3QjxLBZiw9FzV6KtshJLmn8Z4eldPxVPCmNG7abEySl hX05zBOTGqgFCgR0jXK3UoXjNp/Vj4LECqHb+hjlSzoD/DIhI/w3NDiDaj2RzDoRnRXf wsRqlao3j/r9RiGJUFpQG4rAyi/bptNjoOWRKFteHmX8vt1Jn+Wz74XpXKr8y/XVyTmd lx9g== X-Received: by 10.66.184.144 with SMTP id eu16mr28730639pac.18.1419620605510; Fri, 26 Dec 2014 11:03:25 -0800 (PST) Received: from newbook ([50.0.224.95]) by mx.google.com with ESMTPSA id c3sm28818820pbu.76.2014.12.26.11.03.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Dec 2014 11:03:25 -0800 (PST) Date: Fri, 26 Dec 2014 11:03:28 -0800 From: Isaac Dunham To: Natanael Copa Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] busybox-1.23 in edge Message-ID: <20141226190327.GA1800@newbook> References: <20141225205835.397fac22@ncopa-laptop> <20141226001231.GB1793@newbook> <20141226090515.7f2f85ca@ncopa-desktop.alpinelinux.org> <20141226101421.4b06160a@ncopa-desktop.alpinelinux.org> X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141226101421.4b06160a@ncopa-desktop.alpinelinux.org> User-Agent: Mutt/1.5.23 (2014-03-12) On Fri, Dec 26, 2014 at 10:14:21AM +0100, Natanael Copa wrote: > On Fri, 26 Dec 2014 09:05:15 +0100 > Natanael Copa wrote: > > > On Thu, 25 Dec 2014 16:12:32 -0800 > > Isaac Dunham wrote: > > > > > On Thu, Dec 25, 2014 at 08:58:35PM +0100, Natanael Copa wrote: > > > > Hi, > > > > > > > > I pushed busybox 1.23 to edge. So far I found at least one regression[1] > > > > in ash and possibly another in modprobe. > > > > > > > > After upgrading my laptop (both new kernel and new busybox) it didn't > > > > load the ahci kernel module from initramfs so the harddisks was not > > > > found. I don't know if this is due to something in new busybox or in > > > > new kernel or if it affects other hardware. > > > > It did happen on my desktop too and I have a theory on whats going on. > > ... > > > I think what happens is that if a slash (/) is found in the probe name, > > modprobe will simply exit. We call it with: modprobe -a ... > > > > So it means it will load all modules up to first alias which contains a > > slash and then stop. > > > > ncopa-desktop:~# find /sys -name uevent -exec grep -h MODALIAS= '{}' + 2>/dev/null | sort -u | grep -E 'pci|/' > > MODALIAS=dmi:bvnDellInc.:bvrA07:bd09/10/2011:svnDellInc.:pnOptiPlex790:pvr01:rvnDellInc.:rn0HY9JP:rvrA00:cvnDellInc.:ct6:cvr: > > MODALIAS=pci:v00008086d00000100sv00001028sd000004ADbc06sc00i00 > > MODALIAS=pci:v00008086d00000102sv00001028sd000004ADbc03sc00i00 > > ... > > > > As you see, there are slashes in the dmi module and since we sort, dmi > > will always come before pci. So the disk controllers are never loaded > > and disks never found. > > > > I think we should revert the upstream commit for now. > > I pushed a temp fix for busybox for now. I also bumped pkgrel for > mkinitfs to force a regeneration with fixed busybox. > > The fixed was tested with success in qemu. If there are slashes in some module aliases, the upstream commit is based on a flawed assumption and should be reverted everywhere. Thanks, Isaac Dunham --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---