Date: Mon, 30 Nov 2015 08:13:31 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: =?ISO-8859-1?B?U/ZyZW4=?= Tempel <soeren+git@soeren-tempel.net>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 1/5] abuild: use id instead of whoami
Message-ID: <20151130081331.34a219fd@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1448581847-30376-1-git-send-email-soeren+git@soeren-tempel.net>
References: <1448581847-30376-1-git-send-email-soeren+git@soeren-tempel.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Fri, 27 Nov 2015 00:50:43 +0100
S=F6ren Tempel <soeren+git@soeren-tempel.net> wrote:

> Furthermore compare the UID instead of the username.
> ---
>  abuild.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/abuild.in b/abuild.in
> index 38d6efd..697a186 100644
> --- a/abuild.in
> +++ b/abuild.in
> @@ -2144,7 +2144,7 @@ done
>  shift $(( $OPTIND - 1 ))
> =20
>  # check so we are not root
> -if [ "$(whoami)" =3D "root" ] && [ -z "$FAKEROOTKEY" ]; then
> +if [ $(id -u) -eq 0 ] && [ -z "$FAKEROOTKEY" ]; then
>  	[ -z "$forceroot" ] && die "Do not run abuild as root"
>  	FAKEROOT=3D
>  fi

Those patches comes in too late. We have already built world now for
v3.3. I don't want modify abuild unless it fixes something that is
clearly broken at this point as it may result in different reulst of
the built package.

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---