~alpine/devel

1

[alpine-devel] gpm patch bug

Szabolcs Nagy
Details
Message ID
<20160212000741.GP9915@port70.net>
Sender timestamp
1455235662
DKIM signature
missing
Download raw message
it seems this patch leaves .sa_flags uninitialized:

http://git.alpinelinux.org/cgit/aports/plain/testing/gpm/03-gpmroot.patch

either the struct should be zero initialized or do something like

#ifndef SA_INTERRUPT
#define SA_INTERRUPT 0
#endif


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---

[PATCH] Re: [alpine-devel] gpm patch bug

Isaac Dunham
Details
Message ID
<20160212021836.GA3469@newbook>
In-Reply-To
<20160212000741.GP9915@port70.net> (view parent)
Sender timestamp
1455243517
DKIM signature
missing
Download raw message
On Fri, Feb 12, 2016 at 01:07:42AM +0100, Szabolcs Nagy wrote:
> it seems this patch leaves .sa_flags uninitialized:
> 
> http://git.alpinelinux.org/cgit/aports/plain/testing/gpm/03-gpmroot.patch
> 
> either the struct should be zero initialized or do something like
> 
> #ifndef SA_INTERRUPT
> #define SA_INTERRUPT 0
> #endif

You are correct; I was not paying enough attention, just trying to get
it building.

Here's a patch to fix it, though I think that upgrading to the version in
github.com/telmich/gpm is probably the better solution.

Thanks,
Isaac Dunham