Date: Sun, 8 May 2016 13:07:58 -0700
From: Isaac Dunham <ibid.ag@gmail.com>
To: Alba Pompeo <albapompeo@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] ping: ping is not a valid applet
Message-ID: <20160508200757.GA10522@newbook>
References: <CAJDAfTC+HpKvX0rfeyxCNYS1rYx-ThiP6FKCcADZS_YxjqBUeQ@mail.gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="Q68bSM7Ycu6FN28Q"
Content-Disposition: inline
In-Reply-To: <CAJDAfTC+HpKvX0rfeyxCNYS1rYx-ThiP6FKCcADZS_YxjqBUeQ@mail.gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)


--Q68bSM7Ycu6FN28Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, May 08, 2016 at 01:36:17PM -0300, Alba Pompeo wrote:
> I'm on edge and receive this message when trying to ping an IP.
> ping: ping is not a valid applet
> Is there a fix?
> Thanks.
> Ciao.

This is an issue I mentioned previously, where bbsuid no longer recognizes
ping as a valid command, but the symlink has not been updated to point to
busybox.

Workaround:
rm -f /bin/ping && /bin/busybox --install -s

Fix:
See attached patch.

The sysctl settings shown are disabled/netdev (gid=28) only/everyone.

HTH,
Isaac Dunham

--Q68bSM7Ycu6FN28Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="0001-main-busybox-fix-ping-on-upgrades.patch"

>From be58791fd2d2149288352b6793ccf6675ab2c3e1 Mon Sep 17 00:00:00 2001
From: Isaac Dunham <ibid.ag@gmail.com>
Date: Sun, 8 May 2016 12:47:15 -0700
Subject: [PATCH] main/busybox: fix ping on upgrades

ping was a symlink to bbsuid to allow non-root pings, but the support for
ping in bbsuid was dropped when ICMP_ECHO support was patched in.
So the old ping symlink needs to be deleted.

This patch is not a complete fix: non-root ping requires setting a sysctl
to allow the appropriate groups to access ping.
This sysctl is a range, specifying the minimum and maximum gid allowed.
Example settings:
net.ipv4.ping_group_range=1 0
net.ipv4.ping_group_range=28 28
net.ipv4.ping_group_range=0 4294967295
---
 main/busybox/APKBUILD             | 2 +-
 main/busybox/busybox.post-upgrade | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/main/busybox/APKBUILD b/main/busybox/APKBUILD
index 02303ea..91f2d01 100644
--- a/main/busybox/APKBUILD
+++ b/main/busybox/APKBUILD
@@ -2,7 +2,7 @@
 # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
 pkgname=busybox
 pkgver=1.24.2
-pkgrel=2
+pkgrel=3
 pkgdesc="Size optimized toolbox of many common UNIX utilities"
 url=http://busybox.net
 arch="all"
diff --git a/main/busybox/busybox.post-upgrade b/main/busybox/busybox.post-upgrade
index 268f22d..f972562 100644
--- a/main/busybox/busybox.post-upgrade
+++ b/main/busybox/busybox.post-upgrade
@@ -7,5 +7,9 @@ for link in /bin/install /bin/ip /bin/vi /usr/bin/lspci; do
 	fi
 done
 
+if [ -L "/bin/ping" ] && [ "$(readlink /bin/ping)" = "/bin/bbsuid" ]; then
+	rm /bin/ping
+fi
+
 # We need the symlinks early
 exec /bin/busybox --install -s
-- 
2.8.1


--Q68bSM7Ycu6FN28Q--


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---