X-Original-To: alpine-devel@lists.alpinelinux.org Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) by lists.alpinelinux.org (Postfix) with ESMTP id 7638A5C441E for ; Mon, 21 Nov 2016 08:59:31 +0000 (GMT) Received: by mail-qk0-f196.google.com with SMTP id h201so45099799qke.3 for ; Mon, 21 Nov 2016 00:59:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YWRvu/rlU0fyeloQxinzmq/hiA4VAnPtEp0xsumS3ls=; b=Vd/Y/LPebSmLcqm41PV1ym+A3THsF4lpODJEZXCX3ZIc0+7Ya/uRBf5OjhGmtSpvwB At1ojHZ2YHtC4+z2nzue0N5t4c2k1ocrYW/ZqBqA7otmeOn7p3ZtWYkGTfr54Baw9MNc dQR+dK/K/gEC0SyU4pYDc7l67by8/XyYg3GVR6txX5GLdQYMzUkTWEt4aB3+vXrtj32S njCFpRcMUY3AXNfcAlWaDDpwhIuXKAtSSJu8J1SwGhqJplV2qN4/KqFrQvra3zs0d0M7 9CoKFzFyMC0CSwjiJ0YeJ7h0rcezMnGeAmVdQ4LpbDVJS04sl6ONCCRppwUOfPtFaGD+ StMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=YWRvu/rlU0fyeloQxinzmq/hiA4VAnPtEp0xsumS3ls=; b=VKRajLPWH9tlfqYoOOW9QWQf+XCob4iHr7QHAOV0DjN7ogrJJAOb/R4vC3THyz4pmH nZ31dN8phdEalk4BVGjdshdJ49ni75OVaCLA0Hwd20OJsNQz1RVsL23QU/Sc/eaX7Spx BdCx/Lp8qnkUXp6zX5UyWR4jxfzZoSuyWnBf+N/6YMrIYAHYpCSM3t4gAj8wmtEf2xEK Xh0jfP9eYHz6345BsAc497a8Q8I5v2SZFdnhcUD0aYxFQF3+s9iVgkVdkjWTeaooZgWi IJqvhNge3KGjZMtjI93Vo46OpOITOZbAd/G/WYdbM+1wT3thX2xrHuscJl1+zT7WeF1L H5Mw== X-Gm-Message-State: AKaTC02tUohGNY6b+nP15GzAEcJBIlhmQDFrstl+EGBYXRSd2rKd24cZ5a7d8UPfzGna9w== X-Received: by 10.46.5.150 with SMTP id 144mr7325854ljf.45.1479718770594; Mon, 21 Nov 2016 00:59:30 -0800 (PST) Received: from vostro.util.wtbts.net ([2001:1bc8:101:f402:e66f:13ff:fef3:8cd0]) by smtp.gmail.com with ESMTPSA id a9sm5089740ljb.9.2016.11.21.00.59.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Nov 2016 00:59:30 -0800 (PST) Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= Date: Mon, 21 Nov 2016 10:59:25 +0200 From: Timo Teras To: "Tuan M. Hoang" Cc: "alpine-devel" Subject: Re: [alpine-devel] Porting Alpine scripts Message-ID: <20161121105925.685761a2@vostro.util.wtbts.net> In-Reply-To: <20161121073927.2d0a9e65.tmhoang@flatglobe.org> References: <155a8e57d76.f37920c130996.6728092923369604578@flatglobe.org> <20160706172836.74bab5d1@vostro> <155e6497a8e.11ad265cf269464.7355344611305011615@flatglobe.org> <155f440c618.129c9f0aa5155.5728200182511575692@flatglobe.org> <20160718084038.23773fca@vostro.util.wtbts.net> <1560fbd5a78.dbf5aa7b48820.4632348656468847927@flatglobe.org> <20160722084514.7c01123f@vostro.util.wtbts.net> <15614c77014.1200f0e697958.371787825394349914@flatglobe.org> <20160723092945.0680e7fd@vostro> <1562340dbde.12a594a5120275.3795912911296475631@flatglobe.org> <156260c81a5.f458ee7355285.6767768145040849925@flatglobe.org> <20160726194654.69b12731@vostro> <15635238f98.e963f442298215.3433654478481171006@flatglobe.org> <20161116023639.23b44cf1.tmhoang@flatglobe.org> <20161117082440.7f5e0fa0@vostro.util.wtbts.net> <20161119041548.765e6513.tmhoang@flatglobe.org> <20161119092109.13567a93@vostro> <20161121073927.2d0a9e65.tmhoang@flatglobe.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 21 Nov 2016 07:39:27 +0700 "Tuan M. Hoang" wrote: > I see that you didn't provide linux-grsec/config-grsec.aarch64. grsec > does not support aarch64 neither? I have read some grsec patch and it > looks like they do provide some s390/s390x patch like this one : > http://dev.alpinelinux.org/~ncopa/grsec/grsecurity-3.1-4.4.32-201604252206-alpine.patch > I am not sure is this called "supported". Yes, aarch64 is not supported to my knowledge. But indeed there seems to be s390 support in grsec. Feel free to look at it, and enable a grsec config for it. > Actually according to the log above, $ paxctl are those failed > (ret=1). I will try to strace them this week. Ok. > > I would be happy to pick up some of these patches already now. Would > > you be able to give them exported with "git format-patch" so you get > > annotated as author and the commit log is preserved. > > > > I could try bootstrap s390 too then and see if the same problem > > happens and analyze it a bit more. > > > > In any case I recently fixed the bootstrap script and few aports. I > > was able to bootstrap again git master for armv7. > > > Please find my patches in the attachments. There were some small > changes that I did not include in those patches because I think it > only (temporarily) affects my build. So I list here fyi: > - scripts/bootstrap.sh : linux-headers & zlib-dev need to be > explicitly installed (besides fortify-headers, libc-dev, build-base) > even though linux-headers is zlib's makedends, zlib-dev is binutils's > makedepends. > > If there was any problem, please kindly let me know. I applied apk-tools patch to both aports, and apk-tools git. I also took parts of aports/gcc patch (the s390 specific config). linux-headers patch was applied as is. I'm still looking at the rest of the patches. Here's my review thoughts of them: - aports/gcc, moving the libgcc_s.so symlink is probably not the right solution. We prefer to keep that in the main 'gcc' package. During cross-build it should work so that the 'gcc-s390x' cross-build package has this in usr/s390x-alpine-linux-musl/lib/libgcc_s.so. Now it breaks because on other arch's this is in reality a linker script and not a symlink. The linker script enables gcc to search for the right file from all of the libpath again. But s390 is having it as symlink, and breaks because the actual file is relocated to the sysroot. I am not fully sure what to do here. I might lean on just overwriting the cross compiler's libgcc_s.so to be a while with contents: GROUP ( libgcc_s.so.1 -lgcc ) I'll think about it a bit more, and can push a fix later today for it. - aports/linux-vanilla looks good. Though you probably just got the kernel config from some other linux distro? It would probably be good to cross-check that with other Alpine's linux-vanilla configs to see that it is more or less in harmony. - aports/musl looks mostly ok. We hope musl would soon make release, and much of the patch is not needed then as it's mostly upstreamed now. There's one issue that's causing some of your trouble. The following hunk is wrong: @@ -142,6 +146,7 @@ compat() { mips*) _ld="ld.so.1" ;; + s390*) _ld="ld-musl-s390x.so.1" ;; The compat package is supposed to create symlinks that mimic glibc provided ld and libraries. The _ld var needs to be setup to be the glibc ld name, not the musl one. Looking at gcc, the proper thing here to do is: - mips*) _ld="ld.so.1" ;; + mips* | s390*) _ld="ld.so.1" ;; - In main/libressl you add --disable-asm? Why is this needed? It seemed to compile just fine without this flag. If really needed, this should be made conditional so that it's only applied for s390. - The bootstrap script changes should not be needed after the above fixes. Thanks for working on this! It's starting to look pretty good, and with the few tweaks above and after musl release, I think we are good to commit all of the required changes. Cheers, Timo --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---