Date: Tue, 24 Jan 2017 16:58:12 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: rnalrd@gmail.com
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] setup-apkrepos: fix detect fastest
 mirror - fixes #6683
Message-ID: <20170124165812.685f5714@ncopa-desktop.copa.dup.pw>
In-Reply-To: <1485272345-14166-1-git-send-email-rnalrd@gmail.com>
References: <1485272345-14166-1-git-send-email-rnalrd@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 24 Jan 2017 16:39:05 +0100
rnalrd@gmail.com wrote:

> From: Leonardo Arena <rnalrd@gmail.com>
> 
> ---
>  setup-apkrepos.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/setup-apkrepos.in b/setup-apkrepos.in
> index 4565852..f4d4709 100644
> --- a/setup-apkrepos.in
> +++ b/setup-apkrepos.in
> @@ -51,7 +51,7 @@ find_fastest_mirror() {
>  	for url in $MIRRORS; do
>  		# warm up the dns cache
>  		nslookup $(get_hostname_from_url $url) >/dev/null 2>&1
> -		local time=$(time_cmd wget -q -s -T 5 \
> +		local time=$(time_cmd wget -q -S -T 5 \
>  			${url%/}/edge/main/$arch/APKINDEX.tar.gz)
>  		if [ -n "$time" ]; then
>  			echo "$time $url"
> @@ -204,6 +204,8 @@ if [ -n "$JUSTADDRANDOM" ]; then
>  fi
>  
>  if [ -n "$JUSTADDFASTEST" ]; then
> +	# need GNU wget
> +	apk add wget --quiet
>  	show_mirror_list > /dev/null
>  	add_fastest_mirror && changed=true
>  fi

I dont think we should pull in gnu wget since we then would need to
have it on the iso.

I think there is a wget --spider option that should work for busybox too.

https://git.busybox.net/busybox/commit/?id=2972e2c4acb9c46a8cc05c857acac2b3d439bf69

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---