Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Thu, 26 Jan 2017 11:26:55 +0200
From: Timo Teras <timo.teras@iki.fi>
To: William Pitcock <nenolod@dereferenced.org>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] Proposal: testsuite support in APKBUILDs
Message-ID: <20170126112655.44ad5c0e@vostro.util.wtbts.net>
In-Reply-To: <CA+T2pCEB9g=un1jx0x2k+wKNQWeBt8hijEwq1Yy+qLLvb0OVrw@mail.gmail.com>
References: <CA+T2pCEB9g=un1jx0x2k+wKNQWeBt8hijEwq1Yy+qLLvb0OVrw@mail.gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 25 Jan 2017 21:38:00 -0600
William Pitcock <nenolod@dereferenced.org> wrote:

> As such, I propose we add a testsuite() phase to the build process,
> that runs after build(), but prior to package().  APKBUILDs should
> override the testsuite phase, but the default_testsuite() function
> will be a noop for the Alpine 3.6 release cycle that raises a warning
> that the APKBUILD does not define any mechanism for running a
> testsuite.  If "!testsuite" is defined in $features, the warning is
> ignored.
> 
> For cross-builds, the testsuite would be skipped unless the package
> is noarch.
> 
> After Alpine 3.6 (or maybe 3.7), we change the warning to a fatal
> error, requiring APKBUILDs to explicitly opt out of running a
> testsuite through $features.
> 
> Thoughts?

+1

We have some packages that run 'make check' or similar, but it would be
good to make it a separate step.

The above plan sounds good to me.

Thanks,
Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---