Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Fri, 27 Jan 2017 10:15:02 +0200
From: Timo Teras <timo.teras@iki.fi>
To: Ed Robinson <ed.robinson@reevoo.com>
Cc: 7heo <7heo@mail.com>, nenolod@dereferenced.org,
 alpine-devel@lists.alpinelinux.org, jakub@jirutka.cz
Subject: Re: [alpine-devel] Proposal: testsuite support in APKBUILDs
Message-ID: <20170127101502.7a2ff893@vostro.util.wtbts.net>
In-Reply-To: <CAFH_Dguqgd5eMY4UzuqPPuX2HqcWDOsKiwu3pN3c5d0idPawEw@mail.gmail.com>
References: <CA+T2pCEB9g=un1jx0x2k+wKNQWeBt8hijEwq1Yy+qLLvb0OVrw@mail.gmail.com>
	<20170126112655.44ad5c0e@vostro.util.wtbts.net>
	<4EDA0683-3991-44D0-882C-C34FBD4C38B2@jirutka.cz>
	<i2ems4.oke5ti.1hge1d6-qmf@gmx.com>
	<CA+T2pCF+dFPhWBKcwdUSp_Fr1Jk=rT1Pweap6iPZMXjf6HFi8g@mail.gmail.com>
	<5blaf1.okfi73.2tnq26-qmf@gmx.com>
	<CAFH_Dguqgd5eMY4UzuqPPuX2HqcWDOsKiwu3pN3c5d0idPawEw@mail.gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 27 Jan 2017 08:10:19 +0000
Ed Robinson <ed.robinson@reevoo.com> wrote:

> I would prefer test over check and (testsuite). Test is a verb so fits
> nicely with the other commands. "make test" is used about 4 times more
> often than make check in the existing packages.
> https://github.com/alpinelinux/aports/search?utf8=%E2%9C%93&q=make+test&type=Code
> (634 results) vs
> https://github.com/alpinelinux/aports/search?utf8=%E2%9C%93&q=make+check&type=Code
> (180 results)
> 
> I think the idea is a good one overall and I think while naming is
> moderately important, having the feature is more important than
> getting the name right...

'test' is a shell built-in and due to the way abuild is implemented, it
cannot be used. It would break lots of stuff.

I have no strong opinion over 'check' or 'testsuite'.

I'm planning to add 'rootbld' that will do a clean chroot build of the
package. So that would not be strictly a verb either. I have patch for
this, but it's pending a way to configure the repository URLs properly.

/Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---