Date: Sat, 4 Mar 2017 16:34:49 +0100
From: Jean-Louis Fuchs <ganwell@fangorn.ch>
To: alpine-devel@lists.alpinelinux.org
Subject: [alpine-devel] Calling build() check() package() might be a bad order
Message-ID: <20170304153449.GA24485@angua.1042.ch>
Precedence: list
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw"
Content-Disposition: inline
User-Agent: Mutt/1.7.2 (2016-11-26)


--GvXjxJ+pjyke8COw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi

I wanted to point out that there might be a problem with the order in
which abuild calls build(), check() and package().

My project has to be built different for testing and releasing. Since
abuild will call build() first, then check() and then package(), it is
built the wrong way either in check() or in package(). I am in the
fortunate position that my project can do out-of-source builds, but if
it couldn't I would have to do the following:

build()
    Build for release

check()
    Clean, build for test, test, clean and build for release

package()
    Package

I know that any project that does coverage has to be rebuilt for
testing, so my project shouldn't be the only case. Also tests often
only work if assert is active, which it isn't in release mode.

Here is the out-of-source version of the package of my project:
https://github.com/ganwell/chirp/blob/build_cleanup/dist/alpine/chirp/APKBUILD

If check() would run at the end:

build()
    Build for release

package()
    Package

check()
    Clean, build for test and test

May be there is a much better way that I am not aware of, in that case
we should document this in the wiki.

Best,
    Jean-Louis

--GvXjxJ+pjyke8COw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJ8BAEBCgBmBQJYut6WXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ3RTBFQTE3OUE3QUY0QTdFNTU1REIzRDU0
Mzk1OUY2ODQwODg2RDQ1AAoJEEOVn2hAiG1FEgoQALYgHtdIaWcI/M8GMsgjFzLX
Pz41hNkDc+1/Cr8GqI298FpBoDCcyOm79Lg2Zm0sin4fTzNUBIpDkwjxARewPuD1
8dUj4iEjBeNlczUAPv5G7Dx9SUdJqZ7rnbUMAozmWflXNS3/CsxFkvzfV9Que00B
7XEF1rq5mz24Xa4h6p6YosPJ98Sk9UwFDX3D4SsC232JX0X39A8VeuUUplxASVJl
1O5uw07y8oggUY9xfyZo4a9YzyGfLAYvSzZ33fL50nCM1Qc+T0yFB0jUFVfL+Blz
IXKT4jj866tXu1WNbiWR+2unehCPnRRwgSFJIYSbxyYj3geNGEEEuJ2emGfioSXz
VL0KTu8u7yXHULV6FGBZpM5KkFytjtCoGgGtnDp8oLuGe4O8IGdBp0At9xOn3BMw
1G7L+6DXnR/NRqQXCmPC3mjS/G6tVEK2i8jDJtwOtC9j610ekZKyA4M5QEI7/R1M
3LSQq8b29ZokAByLepL5hpc99KrjiXT8pwfEugddF51fl/SEXZ04AN4qvTr4sDQ5
9kABKHkW3b3aBnIa+82fupYHUDpYtongqubCo5WcWYZ5mu10vqAk3wmW8yE5kLXQ
a5EsyQwHW/H7qVi4pdRX71wuYUdWHeSxNC/DDm0wF0xguGUHx1vyReK9wM5ckW7j
eYT2SVx75nbpkOPovrUN
=4ALF
-----END PGP SIGNATURE-----

--GvXjxJ+pjyke8COw--


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---