X-Original-To: alpine-devel@lists.alpinelinux.org Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by lists.alpinelinux.org (Postfix) with ESMTP id 986845C43FF for ; Sun, 5 Mar 2017 05:08:35 +0000 (GMT) Received: from piha.riseup.net (unknown [10.0.1.163]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 38CC51A199C for ; Sun, 5 Mar 2017 05:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1488690514; bh=P5cAED5/KdYB1ZU0Hekcuq6Tza50wif2XIlCrk6sYt0=; h=Date:From:To:Subject:References:In-Reply-To:From; b=o84qu5NJ4clunN+jQ7XvRv0sLFoQd5cLFXrDqIzShTxNwxG73j2QOmV/hR1imAl8L wRpx5aSdHTRehZrtQHBLXJuAU1oEHLUv0Q4Qd3K73JN9aWGisj010OCQ7ISqGGxxdM XFrWVoMFxX3HIU6jDHwZMSGNo1KuQmssb3uDdMvM= Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: pickfire) with ESMTPSA id 4714F1C0515 Date: Sun, 5 Mar 2017 13:08:29 +0800 From: Ivan Tham To: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] Calling build() check() package() might be a bad order Message-ID: <20170305050829.GA28810@riseup.net> References: <20170304153449.GA24485@angua.1042.ch> X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <20170304153449.GA24485@angua.1042.ch> --envbJBWh7q8WU6mo Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Yes, I think build() -> package() -> check() would be a nice idea. I suggest that check() can be optional and not be included as well if we are building for abuild since there is not much reason to do so. On Sat, Mar 04, 2017 at 04:34:49PM +0100, Jean-Louis Fuchs wrote: >I wanted to point out that there might be a problem with the order in >which abuild calls build(), check() and package(). > >My project has to be built different for testing and releasing. Since >abuild will call build() first, then check() and then package(), it is >built the wrong way either in check() or in package(). I am in the >fortunate position that my project can do out-of-source builds, but if >it couldn't I would have to do the following: > >build() > Build for release > >check() > Clean, build for test, test, clean and build for release > >package() > Package > >I know that any project that does coverage has to be rebuilt for >testing, so my project shouldn't be the only case. Also tests often >only work if assert is active, which it isn't in release mode. > >Here is the out-of-source version of the package of my project: >https://github.com/ganwell/chirp/blob/build_cleanup/dist/alpine/chirp/APKB= UILD > >If check() would run at the end: > >build() > Build for release > >package() > Package > >check() > Clean, build for test and test > >May be there is a much better way that I am not aware of, in that case >we should document this in the wiki. --=20 Do what you like, like what you do. -- Pickfire --envbJBWh7q8WU6mo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEELdo3cs03YLvpIOpdscabztvQ+EIFAli7nU0ACgkQscabztvQ +EJ/Sw/7BkG4JYVf4+a0LvQ958cdFPRZ5p5tNI51UvYATtX52uikq7NxOHBHkO20 Sa62pakQz2eGKZqNgf1+1gF/bh6GGt4WfetKRTDHVax6rD7a9UJt0X55QAHETSQt I7Vw9SjHip0A2K5aIHxlNG4DWf1Xsm44AtgTPbumwXheEvtEM1E1TmDC5AMECDln mtQh5HG1ZIy1zcEbNwb+Xl0g3iUYHl9gJLhOGTzeYXpX31SUU/U41UhjEzkxsNRV yDYffcxvlY+YFRupIo+Bc9tBrNWswYyt0oPQpkJk/wLhUkdCXG5kxA3GBEPZ9Vze HwAgsAs8k4HfeVS8p1tKfTkhM9/lNEbBFqeNzUKHW2svkD+uedO9dlLb5AXNjQx5 V8zOt4yTJVXEXtxTMwvNGTeKIdS6VPbZ9sCZvXJj4Y8rq3BhMqKq2DKrq2hxaXmp eXWLwpgmUchRsJYQKot2/uAeuPaskXA1ccstbPRHCHNiWkH6tNUMzpYv5FAd9wVZ 4aQ843QPU9BpdLb9Z6FbSG8JA+vpGgap4MSGYxua7IVL0PfzwIUqVZJDqMJxELqB g7cFopYZR7V1bhr9Ki3cWJKkizOOONNA5C9pOmZt3DA4BT8Gmju1KOh//3Z/+Tks 2HtezX4suCLfvBwnQaFu6pnUNAdQA611YyRCZBSe3WO8g3s3OS8= =CXNI -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo-- --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---