7 6

[alpine-devel] [abuild RFC] abuild: add config option to globally enable dbg

Carlo Landmeter
Details
Message ID
<20170616094140.21953-1-clandmeter@gmail.com>
Sender timestamp
1497606100
DKIM signature
missing
Download raw message
Patch: +5 -0
---
 abuild.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/abuild.in b/abuild.in
index 1db1a4a..ff37162 100644
--- a/abuild.in
+++ b/abuild.in
@@ -2317,6 +2317,11 @@ fi
 # for recursive action
 export REPODEST SRCDEST
 
+# add dbg subpackage if its enabled globally
+if [ -n "$DEFAULT_DBG" ] && ! subpackage_types_has "dbg" && ! options_has "!dbg" && [ "$arch" != "noarch" ]; then
+        subpackages="$pkgname-dbg $subpackages"
+fi
+
 # if we want build debug package
 if [ -n "$DEBUG" ] || subpackage_types_has "dbg"; then
 	CFLAGS="$CFLAGS -g"
-- 
2.13.1



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Alba Pompeo
Details
Message ID
<CAJDAfTBiCc1YwP7QzYWBeB+w-yp1=y_L7AOtD7bcpu7eciLTBA@mail.gmail.com>
In-Reply-To
<20170616094140.21953-1-clandmeter@gmail.com> (view parent)
Sender timestamp
1497615850
DKIM signature
missing
Download raw message
Why not create a dbgs metapackage like the docs metapackage?
https://git.alpinelinux.org/cgit/abuild/tree/abuild.in#n1476
https://git.alpinelinux.org/cgit/aports/tree/main/docs/APKBUILD




On Fri, Jun 16, 2017 at 6:41 AM, Carlo Landmeter <clandmeter@gmail.com> wrote:
> ---
>  abuild.in | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/abuild.in b/abuild.in
> index 1db1a4a..ff37162 100644
> --- a/abuild.in
> +++ b/abuild.in
> @@ -2317,6 +2317,11 @@ fi
>  # for recursive action
>  export REPODEST SRCDEST
>
> +# add dbg subpackage if its enabled globally
> +if [ -n "$DEFAULT_DBG" ] && ! subpackage_types_has "dbg" && ! options_has "!dbg" && [ "$arch" != "noarch" ]; then
> +        subpackages="$pkgname-dbg $subpackages"
> +fi
> +
>  # if we want build debug package
>  if [ -n "$DEBUG" ] || subpackage_types_has "dbg"; then
>         CFLAGS="$CFLAGS -g"
> --
> 2.13.1
>
>
>
> ---
> Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> Help:         alpine-devel+help@lists.alpinelinux.org
> ---
>


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Natanael Copa
Details
Message ID
<20170616160926.6b71801a@ncopa-desktop.copa.dup.pw>
In-Reply-To
<CAJDAfTBiCc1YwP7QzYWBeB+w-yp1=y_L7AOtD7bcpu7eciLTBA@mail.gmail.com> (view parent)
Sender timestamp
1497622166
DKIM signature
missing
Download raw message
On Fri, 16 Jun 2017 09:24:10 -0300
Alba Pompeo <albapompeo@gmail.com> wrote:

> Why not create a dbgs metapackage like the docs metapackage?
> https://git.alpinelinux.org/cgit/abuild/tree/abuild.in#n1476
> https://git.alpinelinux.org/cgit/aports/tree/main/docs/APKBUILD

Why would someome want install all the -dbg packages?

-nc

> 
> 
> 
> 
> On Fri, Jun 16, 2017 at 6:41 AM, Carlo Landmeter <clandmeter@gmail.com> wrote:
> > ---
> >  abuild.in | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/abuild.in b/abuild.in
> > index 1db1a4a..ff37162 100644
> > --- a/abuild.in
> > +++ b/abuild.in
> > @@ -2317,6 +2317,11 @@ fi
> >  # for recursive action
> >  export REPODEST SRCDEST
> >
> > +# add dbg subpackage if its enabled globally
> > +if [ -n "$DEFAULT_DBG" ] && ! subpackage_types_has "dbg" && ! options_has "!dbg" && [ "$arch" != "noarch" ]; then
> > +        subpackages="$pkgname-dbg $subpackages"
> > +fi
> > +
> >  # if we want build debug package
> >  if [ -n "$DEBUG" ] || subpackage_types_has "dbg"; then
> >         CFLAGS="$CFLAGS -g"
> > --
> > 2.13.1
> >
> >
> >
> > ---
> > Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> > Help:         alpine-devel+help@lists.alpinelinux.org
> > ---
> >  
> 
> 
> ---
> Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> Help:         alpine-devel+help@lists.alpinelinux.org
> ---
> 



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Seamus Caveney
Details
Message ID
<965d70af-3857-d85b-998c-91e445a99726@brinstar.org>
In-Reply-To
<20170618100036.73aab4ae@vostro> (view parent)
Sender timestamp
1497777659
DKIM signature
missing
Download raw message
On 2017-06-18 00:00, Timo Teras wrote:
> On Fri, 16 Jun 2017 16:09:26 +0200
> Natanael Copa <ncopa@alpinelinux.org> wrote:
> 
>> On Fri, 16 Jun 2017 09:24:10 -0300
>> Alba Pompeo <albapompeo@gmail.com> wrote:
>>
>>> Why not create a dbgs metapackage like the docs metapackage?
>>> https://git.alpinelinux.org/cgit/abuild/tree/abuild.in#n1476
>>> https://git.alpinelinux.org/cgit/aports/tree/main/docs/APKBUILD
>>
>> Why would someome want install all the -dbg packages?
> 
> I would. When trying to analyze core dump. Global meta package would be
> nicer than trying to hunt individually the -dbg packagaes needed.
> Though, we might hold that for the big projects. Getting firefox,
> libreoffice etc. -dbg might be just too much.
> 
> /Timo
> 

Better to opt for wildcards for install. More useful than adding a dbg 
meta package and replaces the current solution for docs metapkg, which 
is brittle imo, where is it documented that you must have the installif 
entry in a custom doc function in an APKBUILD?

apk add *-dbg
apk add *-doc

Or say install many subpackages:

apk add qemu-system-*

The function already exists for search, why not for add as well?


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Timo Teras
Details
Message ID
<20170618100036.73aab4ae@vostro>
In-Reply-To
<20170616160926.6b71801a@ncopa-desktop.copa.dup.pw> (view parent)
Sender timestamp
1497769236
DKIM signature
missing
Download raw message
On Fri, 16 Jun 2017 16:09:26 +0200
Natanael Copa <ncopa@alpinelinux.org> wrote:

> On Fri, 16 Jun 2017 09:24:10 -0300
> Alba Pompeo <albapompeo@gmail.com> wrote:
> 
> > Why not create a dbgs metapackage like the docs metapackage?
> > https://git.alpinelinux.org/cgit/abuild/tree/abuild.in#n1476
> > https://git.alpinelinux.org/cgit/aports/tree/main/docs/APKBUILD  
> 
> Why would someome want install all the -dbg packages?

I would. When trying to analyze core dump. Global meta package would be
nicer than trying to hunt individually the -dbg packagaes needed.
Though, we might hold that for the big projects. Getting firefox,
libreoffice etc. -dbg might be just too much.

/Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Timo Teras
Details
Message ID
<20170618140358.0202f9bb@vostro>
In-Reply-To
<965d70af-3857-d85b-998c-91e445a99726@brinstar.org> (view parent)
Sender timestamp
1497783838
DKIM signature
missing
Download raw message
On Sun, 18 Jun 2017 02:20:59 -0700
Seamus Caveney <scv@brinstar.org> wrote:

> On 2017-06-18 00:00, Timo Teras wrote:
> > On Fri, 16 Jun 2017 16:09:26 +0200
> > Natanael Copa <ncopa@alpinelinux.org> wrote:
> >   
> >> On Fri, 16 Jun 2017 09:24:10 -0300
> >> Alba Pompeo <albapompeo@gmail.com> wrote:
> >>  
> >>> Why not create a dbgs metapackage like the docs metapackage?
> >>> https://git.alpinelinux.org/cgit/abuild/tree/abuild.in#n1476
> >>> https://git.alpinelinux.org/cgit/aports/tree/main/docs/APKBUILD  
> >>
> >> Why would someome want install all the -dbg packages?  
> > 
> > I would. When trying to analyze core dump. Global meta package
> > would be nicer than trying to hunt individually the -dbg packagaes
> > needed. Though, we might hold that for the big projects. Getting
> > firefox, libreoffice etc. -dbg might be just too much.
> 
> Better to opt for wildcards for install. More useful than adding a
> dbg meta package and replaces the current solution for docs metapkg,
> which is brittle imo, where is it documented that you must have the
> installif entry in a custom doc function in an APKBUILD?

It's in the 'default_doc' split function. But yes, it's not explicitly
documented.

> 
> apk add *-dbg
> apk add *-doc

This would add -dbg packages for everything in the entire index, not
just for the packages which are already installed.

Also the install_if works so that if you have 'docs' installed and you
do 'apk add foo' you will automatically get 'foo-doc' too if it exists.
Basically "apk add docs" means that I want to have docs on all packages
installed on system now, or any time in the future.

"apk del foo" would also remove the docs package with the 'docs' meta.
"apk add *-docs" would add dependency in 'world' and require explcit
removal of the docs too.

The point of the install_if / docs packages is to be more dynamic and
follow the installation status of the main package.

> Or say install many subpackages:
> 
> apk add qemu-system-*
> 
> The function already exists for search, why not for add as well?

But, it does exist for add and delete too. I use regularly "apk del
*-dev". However, the use case is different than from the 'docs'
metapackage and install_if.

/Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Cág
Details
Message ID
<20170619105707.GA31980@alpine>
In-Reply-To
<20170618140358.0202f9bb@vostro> (view parent)
Sender timestamp
1497869827
DKIM signature
missing
Download raw message
Timo Teras wrote:

> But, it does exist for add and delete too. I use regularly "apk del
> *-dev". However, the use case is different than from the 'docs'
> metapackage and install_if.

"apk add" doesn't work for me:

# apk -i add xfce4-*
ERROR: unsatisfiable constraints:
  xfce4-* (missing):
    required by: world[xfce4-*]

"apk del" does:

# apk -i del lx*
The following packages will be REMOVED:
  lxappearance-doc lxappearance-lang lxappearance

-- 
caóc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
William Pitcock
Details
Message ID
<CA+T2pCHJuz9-FAHjdCiAkxfbd3cuOTWrOz1rAo+rfSC4LSKg7w@mail.gmail.com>
In-Reply-To
<20170619105707.GA31980@alpine> (view parent)
Sender timestamp
1498071860
DKIM signature
missing
Download raw message
Hello,

On Mon, Jun 19, 2017 at 5:57 AM, Cág <ca6c@bitmessage.ch> wrote:
> Timo Teras wrote:
>
>> But, it does exist for add and delete too. I use regularly "apk del
>> *-dev". However, the use case is different than from the 'docs'
>> metapackage and install_if.
>
> "apk add" doesn't work for me:
>
> # apk -i add xfce4-*
> ERROR: unsatisfiable constraints:
>   xfce4-* (missing):
>     required by: world[xfce4-*]

Indeed, this is because apk add adds dependency rules, not packages.
However, it is possible that we could do wildcard expansion for simple
package names.
I will look into it.

William


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---