X-Original-To: alpine-devel@lists.alpinelinux.org Received: from mail.cmpwn.com (mail.cmpwn.com [45.56.77.53]) by lists.alpinelinux.org (Postfix) with ESMTP id 4FA335C618A for ; Thu, 26 Jul 2018 12:27:22 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cmpwn.com; s=cmpwn; t=1532608313; bh=k7AMZsOYfURuJfPOi7V/VX84mtJes2R//1D8GgSF86o=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Jazz6mCiPh0fOq4axzaRrg94WLsEFAVQcZsf5DaB3omjGqFq0aLkqnOS9HPPK/Gz6 V1iBQNeri0MYbGPFjhdq74enwZjUAyhmusVOfeR7WD7wRikHUxpkwoA26UGk1RCmvR 77HiWld+E5yAMjWpM2unYQCtw4/vGi+mUnFJ8AeQ= Date: Thu, 26 Jul 2018 08:27:20 -0400 From: Drew DeVault To: Natanael Copa Cc: Alpine Development Subject: Re: [alpine-devel] How to improve quality control for patch reviews Message-ID: <20180726122719.GB16298@homura.localdomain> References: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw> X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw> X-GNU: Terry Pratchett Hey Natanael, I haven't been active much recently but I do have some thoughts here. On 2018-07-26 2:15 PM, Natanael Copa wrote: > - improve documentation. Write documentation with a simple checklist > you can look over before you submit a PR. For example, "check that > license is in SPDX format[1]", "check that it does not automatically > start services from pre-install", etc. This will make it easier for > people doing patch reviews and can be useful when adding automated > checks. Docs are great but linters are much better (something you alluded to). > - add more automatic checks I'm working on a service, sr.ht[0], which provides a number of services including mailing lists[1] and continuous integration[2]. One feature I want to support is creating CI builds from patches sent to mailing lists (including off-site lists), and I already have a thing which can wire up GitHub pull requests to CI builds. [0] https://sr.ht [1] https://lists.sr.ht/~sircmpwn [2] https://builds.sr.ht/job/5448 These builds could run in a fresh Alpine install (full virt with KVM) and attempt to build the package, catching any missing makedeps or ghostly dependencies like the example you gave suffered from, run a linter, and report the results back to the ML or the GitHub PR. Would something like that be useful for Alpine? --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---