X-Original-To: alpine-devel@lists.alpinelinux.org Received: from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25]) by lists.alpinelinux.org (Postfix) with ESMTP id 8EB8C5C5460 for ; Thu, 26 Jul 2018 12:16:05 +0000 (GMT) Received: from mx1.tetrasec.net (mail.local [127.0.0.1]) by mx1.tetrasec.net (Postfix) with ESMTP id 36C6B9E28E5 for ; Thu, 26 Jul 2018 12:16:05 +0000 (GMT) Received: from ncopa-desktop.copa.dup.pw (67.63.200.37.customer.cdi.no [37.200.63.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mx1.tetrasec.net (Postfix) with ESMTPSA id A416C9E2887 for ; Thu, 26 Jul 2018 12:16:04 +0000 (GMT) Date: Thu, 26 Jul 2018 14:15:58 +0200 From: Natanael Copa To: Alpine Development Subject: [alpine-devel] How to improve quality control for patch reviews Message-ID: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi! We have had a few complaints from Jakub Jirutka about qualtiy control. A recent example is https://github.com/alpinelinux/aports/commit/6c21984c5b86ca03c72a88927f8c1de0c420e25f#commitcomment-29834072 We do struggle with keep up with the PR queue and at the same time do good enough quality control. I also think we may have different opinions what is good enough. I wonder if you have any ideas how we deal with this? A few things I think we can do: - improve documentation. Write documentation with a simple checklist you can look over before you submit a PR. For example, "check that license is in SPDX format[1]", "check that it does not automatically start services from pre-install", etc. This will make it easier for people doing patch reviews and can be useful when adding automated checks. - add more automatic checks - give more people push access. Look for people that are candidates to get push access. Help them to improve. Follow up when they are "good enough". Any other ideas or thoughts? -nc 1: https://spdx.org/licenses/ --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---