X-Original-To: alpine-devel@lists.alpinelinux.org Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by lists.alpinelinux.org (Postfix) with ESMTP id 5570F5C61D8 for ; Thu, 2 Aug 2018 08:06:38 +0000 (GMT) Received: by mail-lf1-f46.google.com with SMTP id n96-v6so903046lfi.1 for ; Thu, 02 Aug 2018 01:06:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KzZQwZXq0DCohKZ2u39G1/IWs+e2hPSbKEIbckbCebA=; b=nDPoLRSUyPEWNU0vUkK1kmtEpuPQVBp0Zzf0TEL4s2qMc4USlOmKCFM1M4cf2xdcBQ gRAfJviUWQK1LcMwbuKo4vBnSY/ox9SebP2pBHHBGR2Mvei9VXf+v2hEYYQTA0TB+wLI feL2zeVewGlmxkmuCP7SEhbkCD37/Zv9GfpIAaNuu5EBpIQSPBnesw4SWTbmVZ2kcVz6 iTJdSGmpy85mRKyTQwHxbLK7QMk0uyNYfdeRyfUZkc6Lk8uxL2wtyDzYLNDmkUIh9jVi 5OiQJkpMoR97QcygHhrIZHuNPILonGmAoNmcUy0h3chBq/nMga+4zhi53t1CMdnbGwxa HaHQ== X-Gm-Message-State: AOUpUlEe5Akto4viLa8l06meSAfomh1SKcSsJomTOB66G6SaI0brDRBu 7OX8rn97h1qsLk683/ZC9fWBnFZfyNc= X-Google-Smtp-Source: AAOMgpe1gXnS6fjLJ6oCxEkjcskKfwqQGlYeTRyPiamcmji3IsqD5NIZjt6vbZfnH/xCA+iF9oXhuw== X-Received: by 2002:a19:4b90:: with SMTP id y138-v6mr1044172lfa.118.1533197197600; Thu, 02 Aug 2018 01:06:37 -0700 (PDT) Received: from vostro ([83.145.235.199]) by smtp.gmail.com with ESMTPSA id f3-v6sm191558lfc.30.2018.08.02.01.06.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 01:06:37 -0700 (PDT) Date: Thu, 2 Aug 2018 11:06:35 +0300 From: Timo Teras To: Natanael Copa Cc: Alpine Development Subject: Re: [alpine-devel] How to improve quality control for patch reviews Message-ID: <20180802110635.20e1f810@vostro> In-Reply-To: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw> References: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 26 Jul 2018 14:15:58 +0200 Natanael Copa wrote: > We do struggle with keep up with the PR queue and at the same time do > good enough quality control. I also think we may have different > opinions what is good enough. > > I wonder if you have any ideas how we deal with this? We need to automate more things. > - add more automatic checks This is the key. We need good linter that catches issues. It should be CI hook in github to audit changes and give automated feedback. The increasing amount of rules (some written, some not) are sometimes missed. Especially when the policy changes and people forget which is the latest direction. We need linter that is the authority and keep it up-to-date. Thanks, Timo --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---