X-Original-To: alpine-devel@lists.alpinelinux.org Received: from st43p00im-zteg10063401.me.com (st43p00im-zteg10063401.me.com [17.58.63.175]) by lists.alpinelinux.org (Postfix) with ESMTP id 26CA3F856E7 for ; Fri, 5 Apr 2019 21:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=04042017; t=1554498774; bh=1ccCwqgv1sAsrm6QuA/inMdTSCwPcn6fv318fYreQDs=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=0UEUKNB94FgRTRFfvDJcaP2yy1Y+VW1NcPERfxoQCLAjT7ysTQ8sfqKWaWhdHzIo/ 5Ph9TINL/yTqYLAdF0Yks4vuLDdt7wZvln5Urf0F8KgpxMQMIxOw0UuzbYLjfzYf+2 ou3+FAar66T1ebw3Ds9dVauus6b6xmlTrN9iDo8BMPR7uELLMtSmduu4s/FDzgHCcX qEojebdG2yJGiHynedCWrufVziuLXouOW4hFwsAhZZU5XnObDPksaSoUrqNNtb0Rfk DayNJERF3BnEHBdEBD3G5uwcSZAgyTKfavyG5z+FszoLHoew61ksRdsQ94k1ZSUzSG x2nYENdIK819g== Received: from sachiel (199-168-73-217.lfytina2.metronetinc.net [199.168.73.217]) by st43p00im-zteg10063401.me.com (Postfix) with ESMTPSA id 888CA8A011D for ; Fri, 5 Apr 2019 21:12:53 +0000 (UTC) Date: Fri, 5 Apr 2019 17:13:03 -0400 From: Max Rees To: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] abuild and depends in subpackages Message-ID: <20190405211302.GA19076@sachiel> Mail-Followup-To: alpine-devel@lists.alpinelinux.org References: <20190405154333.5d309856@ncopa-desktop.copa.dup.pw> <4d38a38c-ee89-4310-814b-a22fdc9f80fd@email.android.com> X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4d38a38c-ee89-4310-814b-a22fdc9f80fd@email.android.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-05_16:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=40 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=537 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1812120000 definitions=main-1904050140 On Apr 05 11:06 AM, tcely wrote: > On Apr 5, 2019 9:43 AM, Natanael Copa wrote: > > But we need to decide what behavior we want long term: Do we want > explicitly (always) unset depends or avoid doing depends="$depends > ..." > in split functions? > I would prefer avoid depends="$depends ..." > > I would prefer to set origdepends="$depends" before unsetting depends > for subpackages, at least temporarily until aports can be fixed. > Another way around depends="$depends ..." is to use a variable like > depends_dev so that the assignment happens before the split function > runs. I took this last suggestion and ran with it to see if it could be implemented, since it is tangentially related to my ongoing work with abuildd. If the properties of a subpackage are set outside of its split function, then it is much easier to introspect all subpackage properties without trying to parse shell / formatting (very hard) or running the split function (not possible unless the package is already being built). This is something I think Natanael mentioned briefly on #alpine-devel. A logical extension of this idea is to change the format of $subpackages from the current format of: $subpackages="$subpkgname[:$subpkgsplit[:$subpkgarch]] ..." to something like the following: $subpackages="$subpkgname $variable[ $value...] ..." For example, for iproute2: subpackages="$pkgname-doc $pkgname-bash-completion split bashcomp $pkgname-bash-completion arch noarch $pkgname-bash-completion depends $pkgname-bash-completion pkgdesc bash completions for $pkgname $pkgname-bash-completion install_if $pkgname=$pkgver-r$pkgrel bash-completion" I have what appears to be a working proof-of-concept patch to abuild for this, albeit not thoroughly tested yet, if anyone is interested in exploring this further. Max --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---