Received: from fx.arvanta.net (static-213-198-238-194.adsl.eunet.rs
 [213.198.238.194])	by nld3-dev1.alpinelinux.org (Postfix) with ESMTP id
 26861781A36	for <~alpine/devel@lists.alpinelinux.org>; Tue, 23 Jul 2019
 15:20:16 +0000 (UTC)
Received: from arya.arvanta.net (arya.arvanta.net [10.5.1.6])	by
 fx.arvanta.net (Postfix) with ESMTP id F1AB646F9	for
 <~alpine/devel@lists.alpinelinux.org>; Tue, 23 Jul 2019 17:20:14 +0200 (CEST)
Date: Tue, 23 Jul 2019 17:20:14 +0200
From: Milan =?utf-8?Q?P=2E_Stani=C4=87?= <mps@arvanta.net>
To: ~alpine/devel@lists.alpinelinux.org
Subject: Re: Alpine Linux aports codestyle
Message-ID: <20190723152014.GA13932@arya.arvanta.net>
References: <1c2e99a3-4995-296d-b6e1-6fbad8261ab8@schinagl.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1c2e99a3-4995-296d-b6e1-6fbad8261ab8@schinagl.nl>
User-Agent: Mutt/1.12.1 (2019-06-15)

On Tue, 2019-07-23 at 08:28, Olliver Schinagl wrote:
> Hey list,
> 
> over the past year or so, I've started to contribute to Alpine Linux's
> aports, and have met various codestyles. To get to the bottom of what is
> 'the' Alpine Linux codestyle, I came up empty handed, there is no
> CODESTYLE.md, no search query that finds anything nor on the wiki.

For some time I'm 'writing' this (your) mail in my head (but didn't on
keyboard).

> Now of course, the document could be hiding out of plain site, and if that
> is the case, other then saying 'make it findable', I appologize for even
> bringing anything up here.
> 
> As I was about to do a version bump to community/mtd-utils, I noticed a lot
> of activity on the package, a great thing!. Sadly I came to the realization,
> that in the 'default' aports workflow, the maintainers/contributers do not
> get CC-ed on changes. As I'm mostly only familiar with Linux, U-Boot and
> busybox development, I missed the 'get_maintainers' step, where people
> involved in abuild's would be kept in the loop.

This part should be addressed, IMO.
When changing, upgrading, fixing package we should ask maintainer (at
least) first and maybe contributor's if maintainer doesn't respond, and
not 'blindly' push changes.

Of course, guide and some rules would help for this.

> Never the less, what triggered for me to address the mailing list however
> was commit 57d39405ad74 ("community/mtd-utils: adhere to aports code
> style"). As the subject already states, 'adhere to aports code style' is
> mentioned, but as mentioned earlier, I cannot seem to find this
> aforementioned code style. It should be obvious then of course, that when
> asking people to adhere to a coding style, this style needed to be
> documented (and more importantantly rationalized). It shouldn't needed to be
> mentioned, by having a guide (that can be checked with linters/checkers)
> makes life easier, for both developers and reviewers (passes automated code
> checks, no need to argue about style anymore).
> 
> So in short, where is the style guide that everybody keeps talking about :)
> 
> Thank you,
> 
> Olliver