Received: from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25]) by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 45DA3781F64 for ; Wed, 24 Jul 2019 07:53:19 +0000 (UTC) Received: from mx1.tetrasec.net (mail.local [127.0.0.1]) by mx1.tetrasec.net (Postfix) with ESMTP id 3A3AB9E1BCE; Wed, 24 Jul 2019 07:53:17 +0000 (UTC) Received: from ncopa-desktop.copa.dup.pw (67.63.200.37.customer.cdi.no [37.200.63.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: alpine@tanael.org) by mx1.tetrasec.net (Postfix) with ESMTPSA id 2DFA79E0044; Wed, 24 Jul 2019 07:53:15 +0000 (UTC) Date: Wed, 24 Jul 2019 09:53:07 +0200 From: Natanael Copa To: Olliver Schinagl Cc: alpine-devel@lists.alpinelinux.org Subject: Re: Alpine Linux aports codestyle Message-ID: <20190724095307.7dcfeec7@ncopa-desktop.copa.dup.pw> In-Reply-To: References: <1c2e99a3-4995-296d-b6e1-6fbad8261ab8@schinagl.nl> <20190723212959.316ab849@ncopa-desktop.copa.dup.pw> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-alpine-linux-musl) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Jul 2019 09:13:39 +0200 Olliver Schinagl wrote: > Hey Nathanael, Hi! > On 23-07-2019 21:29, Natanael Copa wrote: > > On Tue, 23 Jul 2019 08:28:11 +0200 > > Olliver Schinagl wrote: > > > >> Hey list, > >> > >> over the past year or so, I've started to contribute to Alpine Linux's > >> aports, and have met various codestyles. To get to the bottom of what is > >> 'the' Alpine Linux codestyle, I came up empty handed, there is no > >> CODESTYLE.md, no search query that finds anything nor on the wiki. > >> > >> Now of course, the document could be hiding out of plain site, and if > >> that is the case, other then saying 'make it findable', I appologize for > >> even bringing anything up here. > > > >> As I was about to do a version bump to community/mtd-utils, I noticed > >> a lot of activity on the package, a great thing!. Sadly I came to the > >> realization, that in the 'default' aports workflow, the > >> maintainers/contributers do not get CC-ed on changes. As I'm mostly > >> only familiar with Linux, U-Boot and busybox development, I missed > >> the 'get_maintainers' step, where people involved in abuild's would > >> be kept in the loop. > > > > This can and be improved. > Excellent, what did you have in mind? I was wondering how to do it in practice given that some people send patches via email, and some via github. We are also moving to gitlab and will hopefully be able to disable github PRs. In any case, it should be automated as much as possible. > I suspsect a CONTRIBUTING.md would > fix this. > > * Read codestyle > * always include maintainers in the CC/invite to review. Yes. Something like that would be great. We already have a .github/CONTRIBUTING.md, but it is specific for github. > For linux (and u-boot) the get_maintainers script goes over the git log > of a APKBUILD and gets the contributers. > > Actually, this can be easily automated. > Codestyle -> linting via the CI. > maintainers can also be found using the CI (parse the APKBUILD file, > include maintainer via the gitlab API Something like that would be great. > Getting the auther authors/contributers from the log however can cause > quite some false positives, e.g. if someone goes over the entire > repository and fixes some global issue (removes all cd $builddir > statements) he now gets flagged for each MR. Some users add them selves as `# Contributor: ` in the APKBUILD. I guess it should be enough to notify the listed maintainer and contributors. That way it is possible to disable notifications in case someone would want to do that. > > I created an issue: https://gitlab.alpinelinux.org/alpine/aports/issues/10689 > Created a MR to kick off the ball. Awesome! Thank you! Turns out to be our first MR in gitlab :) Congrats! -nc