From: Lars Johannsen <laj@it.dk>
Reply-To: laj@it.dk
To: ~alpine/devel@lists.alpinelinux.org
Subject: patch,unmaintained main/compat-pvgrub: may write to wrong file
Date: Thu, 24 Oct 2019 12:02:15 +0200
User-Agent: KMail/1.11.4 (Linux/2.6.29.6; KDE/4.2.4; x86_64; ; )
MIME-Version: 1.0
Message-Id: <201910241202.15717.laj@it.dk>
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_naXsdGSjqL4UhNi"

--Boundary-00=_naXsdGSjqL4UhNi
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi
While browsing aports i saw this bug.
Im not using this package and it seems to be unmaintained,
but anyway here is a patch to prevent it from writing to the wrong file.




--Boundary-00=_naXsdGSjqL4UhNi
Content-Type: text/x-patch;
  charset="us-ascii";
  name="0001-main-compat-pvgrub-prevent-output-to-wrong-conf-file.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
	filename="0001-main-compat-pvgrub-prevent-output-to-wrong-conf-file.patch"

From 9394fd8e5e672bdb4b3a30ffc59c5fdb628c5ca2 Mon Sep 17 00:00:00 2001
From: JailBox <jailbox@tools.dk>
Date: Thu, 24 Oct 2019 00:23:03 +0200
Subject: [PATCH] main/compat-pvgrub: prevent output to wrong conf-file

 if "$myconf" defines/redefines "$conf"
	the generated output would go to the wrong file
I.e. 
  >echo "conf=/boot/mybootdir/extlinux.conf" >> /etc/update-extliunx.conf
 /sbin/update-extlinux will honor this,
 while update-pvgrub would write to the wrong config file.

So postpone presetting "$conf" until "$myconf" has been source'd

---
 main/compat-pvgrub/update-pvgrub | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/main/compat-pvgrub/update-pvgrub b/main/compat-pvgrub/update-pvgrub
index 56594a337b..5293f5081a 100755
--- a/main/compat-pvgrub/update-pvgrub
+++ b/main/compat-pvgrub/update-pvgrub
@@ -5,7 +5,6 @@ default=0
 timeout=5
 verbose=0
 
-conf=/boot/grub/menu.lst
 myconf=/etc/update-extlinux.conf
 
 # read in extlinux settings
@@ -13,6 +12,8 @@ if [ -f "$myconf" ]; then
 	. $myconf
 fi
 
+conf=/boot/grub/menu.lst
+
 everbose() {
 	if [ "$verbose" = "0" ]; then
 		return
-- 
2.22.0


--Boundary-00=_naXsdGSjqL4UhNi--