Date: Mon, 17 Feb 2020 10:42:34 +0200
From: Timo Teras <timo.teras@iki.fi>
To: =?UTF-8?B?U8O2cmVu?= Tempel <soeren@soeren-tempel.net>
Cc: Wolf <wolf@wolfsden.cz>, ~alpine/devel@lists.alpinelinux.org
Subject: Re: community/go and buildmode pie
Message-ID: <20200217104234.0475f206@vostro.wlan>
In-Reply-To: <36NQ9KC6PLT7B.30TAJMQSFWPSF@8pit.net>
References: <20191129221308.hy6ybayxu2nsu5dy@wolfsden.cz>
	<20191202121828.5ba2a735@vostro>
	<36NQ9KC6PLT7B.30TAJMQSFWPSF@8pit.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, 16 Feb 2020 12:30:50 +0100
S=C3=B6ren Tempel <soeren@soeren-tempel.net> wrote:

> Timo Teras <timo.teras@iki.fi> wrote:
> > Alpine standard is to ship PIE if possible because full ASLR does
> > not work without it. =20
>=20
> While this is true and I definitely agree that this a good idea I
> would like to point out that compiling all go packages as PIEs is
> possible without the default-buildmode-pie.patch.
>=20
> My solution to this issue is setting GOFLAGS to -buildmode=3Dpie on the
> builders using /etc/abuild.conf. This is also how we pass -Os for
> C/C++ software currently. Contrary to CFLAGS, GOFLAGS is actually
> picked up by the go compiler itself (see `go help environment`).
>=20
> This has the advantage that it fixes the warning mentioned by Wolf and
> more importantly it would allows us to make more parts of the go
> compiler testsuite pass in the future.
>=20
> See: https://gitlab.alpinelinux.org/alpine/aports/merge_requests/4138
>=20
> Timo, do you have any thoughts on this change?

Sound OK idea. Prefer to set GOFLAGS also in function.sh as abuild.conf
might not get updated if it's modified. Should probably ship defaults
for all flags there. Commented in the MR also.

Timo