Received: from vps892.directvps.nl (ikke.info [178.21.113.177])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 7C1FA781B7A
	for <~alpine/devel@lists.alpinelinux.org>; Thu, 20 Feb 2020 17:44:27 +0000 (UTC)
Received: by vps892.directvps.nl (Postfix, from userid 1008)
	id 0956D4400E2; Thu, 20 Feb 2020 18:44:27 +0100 (CET)
Date: Thu, 20 Feb 2020 18:44:26 +0100
From: Kevin Daudt <kdaudt@alpinelinux.org>
To: Rasmus Thomsen <oss@cogitri.dev>
Cc: ~alpine/devel@lists.alpinelinux.org
Subject: Re: Using buildtypes that respect our C{,PP,XX}FLAGS in CMake and
 Meson
Message-ID: <20200220174426.GA1247035@alpha>
References: <2896c13070c508a49cbaa72c8fb7f34ea947358b.camel@cogitri.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2896c13070c508a49cbaa72c8fb7f34ea947358b.camel@cogitri.dev>

On Thu, Feb 20, 2020 at 05:20:45PM +0000, Rasmus Thomsen wrote:
> Hello list,
> 
> [..]
> 
> As such I'd suggest multiple steps to be taken:
> 
> 1) Change existing aports over to the None/plain buildtype to make sure
> this doesn't break anything (we'll probably use some performance but
> get smaller packages due to our CFLAGS, but that's the goal here, I
> suppose)
> 
> 2) Change Alpine policy to only use the None/plain buildtype.
> Additionally, the buildtype _must be_ mentioned, since at least Meson
> defaults to 'debug' if no buildtype is specified.
> 
> 3) Change newapkbuild so that new aports use the correct buildtype (
> https://gitlab.alpinelinux.org/alpine/abuild/merge_requests/29)
> 
> Thanks,
> 
> Rasmus Thomsen
> 

If feasible, we could add a linting check to verify that the proper
buildtype is used as well.