Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Duncan Bellamy <a.16bit.sysop@me.com>
Mime-Version: 1.0 (1.0)
Subject: Re: Maintainer merge-request policy needed
Message-Id: <36BD51FC-744D-47F7-8904-0BC52E050488@me.com>
Date: Mon, 3 May 2021 14:17:18 +0100
Cc: Jakub Jirutka <jakub@jirutka.cz>, ~alpine/devel@lists.alpinelinux.org
To: David Demelier <markand@malikania.fr>

=EF=BB=BF

> On 3 May 2021, at 12:17, David Demelier <markand@malikania.fr> wrote:
>=20
> =EF=BB=BFOn Mon, May 03, 2021 at 12:37:15PM +0200, Jakub Jirutka wrote:
>> Hi David,
>> I mostly agree with you, but I think that 2 weeks is too long time
>=20
> I think this could be discussed but two weeks can be very short too. If
> someone is on a vacation it may not have any kind of time to review a
> merge request depending on the change.
>=20
> Perhaps we can set a number of timeout depending on the nature of the
> merge request.
>=20
>> That=E2=80=99s specifically why a maintainer should always add documentat=
ion
>> comments into APKBUILD! If you, as a maintainer, have a knowledge of
>> some non-standard/unexpected and non-obvious thing important for the
>> future upgrades, you should document it (for example [1]). Also, if
>> some dependencies are tightly coupled, you should specify the required
>> version range (e.g. `depends=3D"foo>=3D3.5.0"` or `depends=3D"foo=3D~3.5.=
5"`).
>> Maintainers should share important knowledge (comments in APKBUILD)
>> and document all non-obvious changes (commit messages), not keep it
>> for themselves.
>=20
> You're entirely right on that point. I'll also update my APKBUILD to
> include any useful notes too.
>=20
> PS: you seemed have replied only to me so I add a CC to the list because
> you've shared interesting points as well.
>=20
> --=20
> David

Hi,
I would like to add there is the other problem of packages that list a maint=
ainer where the maintainer is no longer actively maintaining the package.

If there was an authorisation period with timeout, it would make it clear th=
en if no response was received that they no longer wished to maintain it or t=
here contact details were wrong.

Duncan

Sent from my iPad=