Received: from magnesium.8pit.net (magnesium.8pit.net [45.76.88.171])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 0C5D6781A49
	for <~alpine/devel@lists.alpinelinux.org>; Sun, 27 Oct 2019 13:33:24 +0000 (UTC)
Received: from localhost (ip4d14d438.dynamic.kabel-deutschland.de [77.20.212.56])
	by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 7aba348d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:YES);
	Sun, 27 Oct 2019 14:33:23 +0100 (CET)
Date: Sun, 27 Oct 2019 14:33:18 +0100
To: Leo <thinkabit.ukim@gmail.com>
Cc: ~alpine/devel@lists.alpinelinux.org
Subject: Re: RFC: Deprecate GitHub PRs
From: soeren@soeren-tempel.net
References: <3OHWOOASIXH2T.20R4V2YVU7P8Y@8pit.net>
 <20191025120444.54dfc985@Impreza>
In-Reply-To: <20191025120444.54dfc985@Impreza>
Message-Id: <3CVEDN3TONFZQ.3UPZ5W5S5UMU0@8pit.net>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Leo <thinkabit.ukim@gmail.com> wrote:
> We can also do what Linus' Linux tree on GitHub does and use a
> KernelPRBot that comments on Pull Requests, telling how to do it
> properly.

I actually prefer this idea, thanks for sharing. The KernelPRBot is open
source [0], however, I personally dislike some technical decisions, e.g.
it requires a cronjob and doesn't utilize GitHub webhooks.

For this reason (and because I was looking for a simple project to
experiment with a new programming language anyhow), I ended up writing
an alternative to KernelPRBot [1]. Contrary to KernelPRBot, it uses
GitHub webhooks and can thus easily be deployed for the entire GitHub
Alpine organization.

Just as KernelPRBot it adds a custom comment to any new PR and
additionally closes it automatically afterwards (though that's
configurable).

It works as is currently, I also created an aport for it [2]. If we
decide to stick with this approach the only thing left to do is creating
a markdown comment template.

> Sounds good to me, current Pull Requests are reviewed and merged until
> there are none. New Pull requests receive a visit from AlpinePRBot?

Sounds good.

Cheers,
S=C3=B6ren

[0]: https://github.com/ajdlinux/PRBot
[1]: https://github.com/nmeum/noprs
[2]: https://gitlab.alpinelinux.org/alpine/aports/merge_requests/870