From nobody Fri Mar 29 11:10:32 2024 Received: from magnesium.8pit.net (magnesium.8pit.net [45.76.88.171]) by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id B32ED781912 for <~alpine/devel@lists.alpinelinux.org>; Fri, 25 Oct 2019 10:32:40 +0000 (UTC) Received: from localhost ( [77.20.212.56]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id c519669b (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:YES) for <~alpine/devel@lists.alpinelinux.org>; Fri, 25 Oct 2019 12:32:39 +0200 (CEST) Date: Fri, 25 Oct 2019 12:32:35 +0200 To: ~alpine/devel@lists.alpinelinux.org Subject: RFC: Deprecate GitHub PRs From: soeren@soeren-tempel.net Message-Id: <3OHWOOASIXH2T.20R4V2YVU7P8Y@8pit.net> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi there, Currently Alpine supports (at least) three ways to submit patches: 1. GitLab merge request (MR) on gitlab.alpinelinux.org 2. GitHub pull requests (PR) on github.com/alpinelinux 3. git-format-patches send to the mailing list (ML) IMHO this creates an unnecessary maintenance overhead, e.g. you have to consult three platforms to figure out if a patch has already been submitted somewhere. Additionally, the platforms use different CI services (or none at all in case of the ML). Since gitlab.alpinelinux.org is fully usable nowadays I would suggest to stop supporting GitHub PRs. Users attempting to submit PRs should be notified that patches should either be send to the ML or submitted as GitLab MRs. This could, for instance, be achieved through a GitHub PR template [1]. I assume that we would like to continue using GitHub as a read-only git mirror. Unfortunately, it does not seem to be possible to disable GitHub PRs [2]. Other organizations seem to deal with this using a cronjob or a GitHub bot which automatically closes all PRs periodically [3]. This seems to be a feasible solution which we could deploy. A problem that remains is dealing with existing PRs. Solutions include stopping to accept new PRs and reviewing the existing ones until there are none left or migrating them to GitLab. Any thoughts on this proposal? Cheers, S=C3=B6ren [1]: https://help.github.com/en/github/building-a-strong-community/creating= -a-pull-request-template-for-your-repository [2]: https://github.com/dear-github/dear-github/issues/84 [3]: https://mail.gnome.org/archives/desktop-devel-list/2016-November/msg00= 043.html From nobody Fri Mar 29 11:10:32 2024 Received: from mx1.tetrasec.net (mx1.tetrasec.net [74.117.189.118]) by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 4F8DB781931 for <~alpine/devel@lists.alpinelinux.org>; Fri, 25 Oct 2019 15:42:15 +0000 (UTC) Received: from mx1.tetrasec.net (mail.local [127.0.0.1]) by mx1.tetrasec.net (Postfix) with ESMTP id 86D672DE2063; Fri, 25 Oct 2019 15:42:13 +0000 (UTC) Received: from ncopa-desktop.copa.dup.pw (67.63.200.37.customer.cdi.no [37.200.63.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: alpine@tanael.org) by mx1.tetrasec.net (Postfix) with ESMTPSA id 85BE12DE1F7B; Fri, 25 Oct 2019 15:42:12 +0000 (UTC) Date: Fri, 25 Oct 2019 17:42:05 +0200 From: Natanael Copa To: soeren@soeren-tempel.net Cc: ~alpine/devel@lists.alpinelinux.org Subject: Re: RFC: Deprecate GitHub PRs Message-ID: <20191025174205.4a9a35d3@ncopa-desktop.copa.dup.pw> In-Reply-To: <3OHWOOASIXH2T.20R4V2YVU7P8Y@8pit.net> References: <3OHWOOASIXH2T.20R4V2YVU7P8Y@8pit.net> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-alpine-linux-musl) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Fri, 25 Oct 2019 12:32:35 +0200 soeren@soeren-tempel.net wrote: > Hi there, >=20 > Currently Alpine supports (at least) three ways to submit patches: >=20 > 1. GitLab merge request (MR) on gitlab.alpinelinux.org > 2. GitHub pull requests (PR) on github.com/alpinelinux > 3. git-format-patches send to the mailing list (ML) >=20 > IMHO this creates an unnecessary maintenance overhead, e.g. you have to > consult three platforms to figure out if a patch has already been > submitted somewhere. Additionally, the platforms use different CI > services (or none at all in case of the ML). Agree. This is the long term plan. As a sidenote, it is also possible to connect the gilab login with a github login, so you can use the github password to login to gitlab. > Since gitlab.alpinelinux.org is fully usable nowadays I would suggest > to stop supporting GitHub PRs. Users attempting to submit PRs should be > notified that patches should either be send to the ML or submitted as > GitLab MRs. This could, for instance, be achieved through a GitHub PR > template [1]. I am all for shutting down github PRs as long as the infra team, the people maintaining our gitlab instance is ok with it. My understanding is that they are a bit overloaded right now, so we may need patience. > I assume that we would like to continue using GitHub as a read-only > git mirror. Unfortunately, it does not seem to be possible to disable > GitHub PRs [2]. Other organizations seem to deal with this using a > cronjob or a GitHub bot which automatically closes all PRs > periodically [3]. This seems to be a feasible solution which we could > deploy. >=20 > A problem that remains is dealing with existing PRs. Solutions include > stopping to accept new PRs and reviewing the existing ones until there > are none left or migrating them to GitLab. >=20 > Any thoughts on this proposal? I think we want keep github as read-only mirror, yes. I think we may need a webhook for gitlab, to do the mirror to git.a.o. Currently we push to git.a.o and sync to gitlab, but we want push to gitlab and sync to git.a.o, so git.a.o becomes read-only mirror with cgit interface. We may also want the webhook do auto closing etc, similar to what we do now (stale bot). If there are any volunteers with docker and gitlab maintenance experience, who would be interested in help us, please let us know. >=20 > Cheers, > S=F6ren >=20 > [1]: > https://help.github.com/en/github/building-a-strong-community/creating-a-= pull-request-template-for-your-repository > [2]: https://github.com/dear-github/dear-github/issues/84 [3]: > https://mail.gnome.org/archives/desktop-devel-list/2016-November/msg00043= .html From nobody Fri Mar 29 11:10:32 2024 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id DD981781B3B for <~alpine/devel@lists.alpinelinux.org>; Fri, 25 Oct 2019 15:04:54 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id t20so3651073qtr.10 for <~alpine/devel@lists.alpinelinux.org>; Fri, 25 Oct 2019 08:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=xDyrJxU5ueELIxGyOxqb4emwrCrzWE81+boblIsHZVQ=; b=uYLPVgipZgp7kghQWRdddzGk0urMvO49/QsWUESoIKcbJNvWpJHxXTBV2NukktGrfn Q2kwMX4XbkipBkpxasJRk12+ZCRzeuAHmq10xuBrjmAq/3V26dvy3eThDNbQqkzUW8C7 jFP1LmrSpVzFe8RNP0Bv/I+xXYBeAJpR22qN5o1IV6NuNCFAZHjoWrBMzSrBmvxGdmsM ZA8NW2+XvH/v5exJIByknZNI03CcF1vweqg+PMYRtvPNEEw4YTOnBup/LlmyBdIYdIQ3 2zQglMZA8BJ+/k9L+3xLIJjLVLcij8Fr1nhQvTGt/x/gUJoqK3A8Qb5ag3AuASeVXdwB LRlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xDyrJxU5ueELIxGyOxqb4emwrCrzWE81+boblIsHZVQ=; b=YCulGdGc+u9pGOk3S1ZSgLECX/jLduiz6OlB1sQU88N2biduyR/vbjdCvWu44VrfQK umhTIDMaTd3frbtcwBB/ha/kdXC+Bty2xnqRMenknvwd9KfGLkzJ2uWa9/kCzDRTYkX+ 27EGJMrzATPw42fduzTW1ro9A8yyHDn9lCHgNItb5BFQyRJNaadL27vw1h7V5Gj7BXaX crDzDeMCoPgPf507XLHJh3b5KNJO9RqIkwSHmgaPn6wzQZT/5B0+eRUJy9icb/seh2lk X+8mmYSuQ0oXVil+344v+lmYplB0sYiE3I+C5+zEfmAmJazaqiOmg3ZpWLNY9M4pkI1F a1Mg== X-Gm-Message-State: APjAAAXBwd0UJWHC6y+Wd2vGC+5B9HPGtunD/4DebcjgZOyZushoCiND Faoz4RVCTKznZNZ26neLQ7rKGmiF X-Google-Smtp-Source: APXvYqw2ma9uvncq8rOHrmwqShuvvKXf1v93il3hY1FL4KgW+i2vhETAdsnyO5k/FIA1+8XCmvrTwA== X-Received: by 2002:ac8:44da:: with SMTP id b26mr3471008qto.299.1572015893222; Fri, 25 Oct 2019 08:04:53 -0700 (PDT) Received: from Impreza ([2804:14c:3ba1:31:5cb7:e0ad:35fa:7b40]) by smtp.gmail.com with ESMTPSA id q44sm2072151qtk.16.2019.10.25.08.04.52 for <~alpine/devel@lists.alpinelinux.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 08:04:53 -0700 (PDT) Date: Fri, 25 Oct 2019 12:04:44 -0300 From: Leo To: ~alpine/devel@lists.alpinelinux.org Subject: Re: RFC: Deprecate GitHub PRs Message-ID: <20191025120444.54dfc985@Impreza> In-Reply-To: <3OHWOOASIXH2T.20R4V2YVU7P8Y@8pit.net> References: <3OHWOOASIXH2T.20R4V2YVU7P8Y@8pit.net> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-alpine-linux-musl) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 25 Oct 2019 12:32:35 +0200 soeren@soeren-tempel.net wrote: > Since gitlab.alpinelinux.org is fully usable nowadays I would suggest > to stop supporting GitHub PRs. Users attempting to submit PRs should > be notified that patches should either be send to the ML or submitted > as GitLab MRs. This could, for instance, be achieved through a GitHub > PR template [1]. > We can also do what Linus' Linux tree on GitHub does and use a KernelPRBot that comments on Pull Requests, telling how to do it properly. > A problem that remains is dealing with existing PRs. Solutions include > stopping to accept new PRs and reviewing the existing ones until there > are none left or migrating them to GitLab. > Sounds good to me, current Pull Requests are reviewed and merged until there are none. New Pull requests receive a visit from AlpinePRBot? From nobody Fri Mar 29 11:10:32 2024 Received: from magnesium.8pit.net (magnesium.8pit.net [45.76.88.171]) by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 0C5D6781A49 for <~alpine/devel@lists.alpinelinux.org>; Sun, 27 Oct 2019 13:33:24 +0000 (UTC) Received: from localhost (ip4d14d438.dynamic.kabel-deutschland.de [77.20.212.56]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 7aba348d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:YES); Sun, 27 Oct 2019 14:33:23 +0100 (CET) Date: Sun, 27 Oct 2019 14:33:18 +0100 To: Leo Cc: ~alpine/devel@lists.alpinelinux.org Subject: Re: RFC: Deprecate GitHub PRs From: soeren@soeren-tempel.net References: <3OHWOOASIXH2T.20R4V2YVU7P8Y@8pit.net> <20191025120444.54dfc985@Impreza> In-Reply-To: <20191025120444.54dfc985@Impreza> Message-Id: <3CVEDN3TONFZQ.3UPZ5W5S5UMU0@8pit.net> User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Leo wrote: > We can also do what Linus' Linux tree on GitHub does and use a > KernelPRBot that comments on Pull Requests, telling how to do it > properly. I actually prefer this idea, thanks for sharing. The KernelPRBot is open source [0], however, I personally dislike some technical decisions, e.g. it requires a cronjob and doesn't utilize GitHub webhooks. For this reason (and because I was looking for a simple project to experiment with a new programming language anyhow), I ended up writing an alternative to KernelPRBot [1]. Contrary to KernelPRBot, it uses GitHub webhooks and can thus easily be deployed for the entire GitHub Alpine organization. Just as KernelPRBot it adds a custom comment to any new PR and additionally closes it automatically afterwards (though that's configurable). It works as is currently, I also created an aport for it [2]. If we decide to stick with this approach the only thing left to do is creating a markdown comment template. > Sounds good to me, current Pull Requests are reviewed and merged until > there are none. New Pull requests receive a visit from AlpinePRBot? Sounds good. Cheers, S=C3=B6ren [0]: https://github.com/ajdlinux/PRBot [1]: https://github.com/nmeum/noprs [2]: https://gitlab.alpinelinux.org/alpine/aports/merge_requests/870