Received: from magnesium.8pit.net (magnesium.8pit.net [45.76.88.171])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id B32ED781912
	for <~alpine/devel@lists.alpinelinux.org>; Fri, 25 Oct 2019 10:32:40 +0000 (UTC)
Received: from localhost (<unknown> [77.20.212.56])
	by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id c519669b (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:YES)
	for <~alpine/devel@lists.alpinelinux.org>;
	Fri, 25 Oct 2019 12:32:39 +0200 (CEST)
Date: Fri, 25 Oct 2019 12:32:35 +0200
To: ~alpine/devel@lists.alpinelinux.org
Subject: RFC: Deprecate GitHub PRs
From: soeren@soeren-tempel.net
Message-Id: <3OHWOOASIXH2T.20R4V2YVU7P8Y@8pit.net>
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101
 Thunderbird/54.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi there,

Currently Alpine supports (at least) three ways to submit patches:

	1. GitLab merge request (MR) on gitlab.alpinelinux.org
	2. GitHub pull requests (PR) on github.com/alpinelinux
	3. git-format-patches send to the mailing list (ML)

IMHO this creates an unnecessary maintenance overhead, e.g. you have to
consult three platforms to figure out if a patch has already been
submitted somewhere. Additionally, the platforms use different CI
services (or none at all in case of the ML).

Since gitlab.alpinelinux.org is fully usable nowadays I would suggest
to stop supporting GitHub PRs. Users attempting to submit PRs should be
notified that patches should either be send to the ML or submitted as
GitLab MRs. This could, for instance, be achieved through a GitHub PR
template [1].

I assume that we would like to continue using GitHub as a read-only git
mirror. Unfortunately, it does not seem to be possible to disable GitHub
PRs [2]. Other organizations seem to deal with this using a cronjob or a
GitHub bot which automatically closes all PRs periodically [3]. This
seems to be a feasible solution which we could deploy.

A problem that remains is dealing with existing PRs. Solutions include
stopping to accept new PRs and reviewing the existing ones until there
are none left or migrating them to GitLab.

Any thoughts on this proposal?

Cheers,
S=C3=B6ren

[1]: https://help.github.com/en/github/building-a-strong-community/creating=
-a-pull-request-template-for-your-repository
[2]: https://github.com/dear-github/dear-github/issues/84
[3]: https://mail.gnome.org/archives/desktop-devel-list/2016-November/msg00=
043.html