DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=Y7lg6DCPLWlLLexpzzAO6AbieHr4hAs+6aLcbYcqC7zP2JsSzHQWYwehBU/kRjWoLl
         NjdQRPF7lR5LY97DqgqeZG3saO+fiY+/iE5pgSvJi7XaTYpqdyLAEyX74Nz4IrJmDIbO
         POHHuZ9yAiLy4dIqyzCoAo9P1GhWGhYT8VbLk=
Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Message-ID: <49DB58C3.4080505@iki.fi>
Date: Tue, 07 Apr 2009 16:44:35 +0300
From: =?ISO-8859-1?Q?Timo_Ter=E4s?= <timo.teras@iki.fi>
User-Agent: Thunderbird 2.0.0.19 (X11/20090105)
Precedence: list
MIME-Version: 1.0
To: Natanael Copa <natanael.copa@gmail.com>
CC: Alpine-devel <alpine-devel@lists.alpinelinux.org>
Subject: Re: [alpine-devel] dealing with kernel module apkbuilds
References: <1239110538.15720.63.camel@nc>
In-Reply-To: <1239110538.15720.63.camel@nc>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Natanael Copa wrote:
> 2. we include the kernel version in the kernel module package pkgver.
> This is doe by sourcing the kernel APKBUILD. For example:
> 
> # source kernel version
> . ../linux-grsec/APKBUILD
> pkgname=dahdi-linux-grsec
> _dahdiver=2.1.0.4
> pkgver=$pkgver.$pkgrel.$_dahdiver
> pkgrel=1
> ...
> 
> If kernel is 2.6.28.9-r4, the dadhdi-linux-grsec would here end up as
> 2.6.28.9.4.2.1.0.4-r1
> 
> Alternatively we could just add the pkgrels so reduce one digit:
> # source kernel version
> . ../linux-grsec/APKBUILD
> pkgname=dahdi-linux-grsec
> _dahdiver=2.1.0.4
> _rel=1
> pkgver=$pkgver.$_dahdiver
> pkgrel=$(( $_rel + $pkgrel ))
> ...
> 
> In this example we would end up with
> dahdi-linux-grsec-2.6.28.9.2.1.0.4-r4
> 
> If we now upgrade the kernel to 2.6.28.9-r5 then will 'abuild up2date'
> detect that the package is missing and will trigger a rebuild and things
> just works. However, it is somewhat hackish, creates ugly version
> numbers and is not so simple.
> But the drawback is that it will not auto rebuild if kernel is updated.
> 
> What do you prefer?

I'd prefer something like option 2.

But I would not include the kernel version in the package version.
Instead apk-tools should do versioned dependencies. Then during build
you could just rebuild packages that have no longer valid dependencies
after kernel package upgrade.

Ideally you should not need to specify the kernel flavor in apkbuild.
Instead the build system should know all available kernel variants,
and rebuild the modules for each variant.

- Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---