Message-ID: <4E1C7C58.6040405@hohm.net>
Date: Tue, 12 Jul 2011 11:54:48 -0500
From: John Keith Hohm <john@hohm.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10
Precedence: list
MIME-Version: 1.0
To: Natanael Copa <ncopa@alpinelinux.org>
CC: alpine-devel@lists.alpinelinux.org, 
 Carlo Landmeter <clandmeter@gmail.com>
Subject: Re: [alpine-devel] [PATCH] testing/mtr: new aport
References: <1310419297-15518-1-git-send-email-john@hohm.net> <20110712102023.10ce93fe@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <20110712102023.10ce93fe@ncopa-desktop.nor.wtbts.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 07/12/2011 03:20 AM, Natanael Copa wrote:
> I had a look at this patch and, sure it works. It would have been
> preferable that it could have changed the configure.in file and then
> run aclocal&&  autoreconf or similar. Instead of error out on missing
> res_mkquery it could have set a config.h variable and then do
> something like:
>
> #ifndef HAVE_MK_QUERY
> /* res_mkquery from dietlibc libcruft http://www.fefe.de/dietlibc/ */
> ...
> #endif

Yes, I actually did something like that first locally but the patch from 
re-running those tools was ridiculously big, since I did not use the 
exact same automake and autoconf versions as upstream.

> and send that patch upstream.
>
> (even better would probably to remove the entire dns.c and use c-ares
> library)

Hey, thanks for the pointer to c-ares.  Maybe I should check with 
upstream whether they are likely to accept such a patch.  I had first 
considered replacing dns.c with the public domain djbdns client library 
files but thought they might not be keen on losing IPv6 support.

> That said, I think its good enough for Alpine anyways.
> Thanks!

Thanks guys for the inclusion, and for working on Alpine. I am quite 
pleased to be able to stay with Alpine for an upgrade to a new x86_64 
incarnation of an important firewall.

-- 
John Keith Hohm
<john@hohm.net>


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---