Content-Type: text/plain; charset=utf-8
Precedence: list
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [alpine-devel] Proposal: testsuite support in APKBUILDs
From: Jakub Jirutka <jakub@jirutka.cz>
In-Reply-To: <20170126112655.44ad5c0e@vostro.util.wtbts.net>
Date: Thu, 26 Jan 2017 14:08:29 +0100
Cc: William Pitcock <nenolod@dereferenced.org>,
 alpine-devel@lists.alpinelinux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4EDA0683-3991-44D0-882C-C34FBD4C38B2@jirutka.cz>
References: <CA+T2pCEB9g=un1jx0x2k+wKNQWeBt8hijEwq1Yy+qLLvb0OVrw@mail.gmail.com> <20170126112655.44ad5c0e@vostro.util.wtbts.net>
To: Timo Teras <timo.teras@iki.fi>

Hi,

currently we have the following phases: sanitycheck, builddeps, clean, =
fetch, unpack, prepare, mkusers, rootpkg, cleanup. All of them except =
rootpkg are verbs. So I=E2=80=99d prefer =E2=80=9Ccheck=E2=80=9D (as =
Arch) instead of =E2=80=9Ctestsuite=E2=80=9D.

Jakub

> On 26. Jan 2017, at 10:26, Timo Teras <timo.teras@iki.fi> wrote:
>=20
> On Wed, 25 Jan 2017 21:38:00 -0600
> William Pitcock <nenolod@dereferenced.org> wrote:
>=20
>> As such, I propose we add a testsuite() phase to the build process,
>> that runs after build(), but prior to package().  APKBUILDs should
>> override the testsuite phase, but the default_testsuite() function
>> will be a noop for the Alpine 3.6 release cycle that raises a warning
>> that the APKBUILD does not define any mechanism for running a
>> testsuite.  If "!testsuite" is defined in $features, the warning is
>> ignored.
>>=20
>> For cross-builds, the testsuite would be skipped unless the package
>> is noarch.
>>=20
>> After Alpine 3.6 (or maybe 3.7), we change the warning to a fatal
>> error, requiring APKBUILDs to explicitly opt out of running a
>> testsuite through $features.
>>=20
>> Thoughts?
>=20
> +1
>=20
> We have some packages that run 'make check' or similar, but it would =
be
> good to make it a separate step.
>=20
> The above plan sounds good to me.
>=20
> Thanks,
> Timo
>=20
>=20
> ---
> Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> Help:         alpine-devel+help@lists.alpinelinux.org
> ---
>=20



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---