X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail-in-14.arcor-online.net (mail-in-14.arcor-online.net [151.189.21.54]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 23A6ADC013F for ; Sat, 24 Mar 2012 18:23:24 +0000 (UTC) Received: from mail-in-18-z2.arcor-online.net (mail-in-18-z2.arcor-online.net [151.189.8.35]) by mx.arcor.de (Postfix) with ESMTP id 1F1579BEEB for ; Sat, 24 Mar 2012 19:23:23 +0100 (CET) Received: from mail-in-08.arcor-online.net (mail-in-08.arcor-online.net [151.189.21.48]) by mail-in-18-z2.arcor-online.net (Postfix) with ESMTP id 1C5BB33A38E for ; Sat, 24 Mar 2012 19:23:23 +0100 (CET) Received: from [192.168.6.10] (85-127-183-180.dynamic.xdsl-line.inode.at [85.127.183.180]) (Authenticated sender: panthera.tigris@arcor.de) by mail-in-08.arcor-online.net (Postfix) with ESMTPA id EE62E1FB554 for ; Sat, 24 Mar 2012 19:23:22 +0100 (CET) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-08.arcor-online.net EE62E1FB554 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in; t=1332613403; bh=pIfY7MYXBdsjNVRiJHzRgBwo53t41RGFbIN1BdnXn4w=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type: Content-Transfer-Encoding; b=LE8+8KvZeIL99TxIkyR6mFGexWdxHObrbwP2IjPnnWEm3Q1HNyqmHxDSZCMjFJ/NB BA4s2bgQHDbsYbCaO7n1JLCSAOFtQdOQ2kmb99YQDL0mYdHtoTnlMFnuUrp01J5Eth JdIcZL7B8im2AC1si35RAMU50hWffpEBXgDpegFg= Message-ID: <4F6E1119.8080306@arcor.de> Date: Sat, 24 Mar 2012 19:23:21 +0100 From: Der Tiger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0 X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 To: alpine-devel@lists.alpinelinux.org Subject: [alpine-devel] [Patch] acf-iptables: fixing model Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Hi, There are two bugs causing the web interface to malfunction when either a protocol selection is negated using a exclamation mark (!) or a comment is entered in the appropriate field of the form. PLEASE, make sure removing the escaping of the spec string does not cause problems with certain data entered in the form! So far, I had no troubles while testing, because the fields are checked in validate_rule(), anyway. Regards, Tiger --- /usr/share/acf/app/iptables/iptables-model.lua.orig +++ /usr/share/acf/app/iptables/iptables-model.lua @@ -147 +147 @@ - addparameter(rule.value.protocol.value, "-p") + addparameter(rule.value.protocol.value, "-p", true) @@ -520 +520 @@ - local cmd = path .. "iptables -t " .. format.escapespecialcharacters(rule.value.table.value) .. " -R " .. format.escapespecialcharacters(rule.value.chain.value) .. " " .. format.escapespecialcharacters(rule.value.position.value) .. " " .. format.escapespecialcharacters(spec) .. " 2>&1" + local cmd = path .. "iptables -t " .. format.escapespecialcharacters(rule.value.table.value) .. " -R " .. format.escapespecialcharacters(rule.value.chain.value) .. " " .. format.escapespecialcharacters(rule.value.position.value) .. " " .. spec .. " 2>&1" --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---