X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail-in-05.arcor-online.net (mail-in-05.arcor-online.net [151.189.21.45]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id D2C7EDC0157 for ; Sun, 13 Apr 2014 10:48:43 +0000 (UTC) Received: from mail-in-15-z2.arcor-online.net (mail-in-15-z2.arcor-online.net [151.189.8.32]) by mx.arcor.de (Postfix) with ESMTP id 3CBF0E3C27 for ; Sun, 13 Apr 2014 12:48:42 +0200 (CEST) Received: from mail-in-18.arcor-online.net (mail-in-18.arcor-online.net [151.189.21.58]) by mail-in-15-z2.arcor-online.net (Postfix) with ESMTP id 3A1A511204A for ; Sun, 13 Apr 2014 12:48:42 +0200 (CEST) X-Greylist: Passed host: 85.127.142.90 X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-18.arcor-online.net 161C23DC320 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in; t=1397386122; bh=4lQ1glGvKWpyJcS2XEbHI2d0nF4q4RFGWnMHDuchaxk=; h=Message-ID:Date:From:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Tnv4uZV6UW90vERfOFxPD79wGWyvhjkS9Z4ZHYxvwfblETL1C8vjs2S3AWBYZQ81s Un+qh5BgHmJc3cV93bow5Z2XjktmgCu6+C7XqOVyzl1Bj/FR7hchmhCYiz0VrezTKH o5ETmuxrB91VXolN864uyLI8NXEAVlq1rMVxyImk= Received: from [192.168.16.209] (85-127-142-90.dynamic.xdsl-line.inode.at [85.127.142.90]) (Authenticated sender: panthera.tigris@arcor.de) by mail-in-18.arcor-online.net (Postfix) with ESMTPA id 161C23DC320 for ; Sun, 13 Apr 2014 12:48:41 +0200 (CEST) Message-ID: <534A6B89.7000503@arcor.de> Date: Sun, 13 Apr 2014 12:48:41 +0200 From: Der Tiger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 To: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [PATCH] Updated freeswitch.initd to include missing path switches. References: <1397371981-3308-1-git-send-email-tbooth@hindbra.in> <534A3DA7.6090609@arcor.de> <20140413075957.497c6499@ncopa-desktop.alpinelinux.org> In-Reply-To: <20140413075957.497c6499@ncopa-desktop.alpinelinux.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Natanael, On 2014-04-13 09:59, Natanael Copa wrote: > On Sun, 13 Apr 2014 09:32:55 +0200 > Der Tiger wrote: > >> In order to make those switches adjustable by the user, I suggest to set >> them in /etc/conf.d/freeswitch utilizing the ${OPTS} variable in the >> init.d script rather than make them hard-coded in /etc/init.d/freeswitch >> itself, because some folks my want to store recordings on a different >> drive or use their own set of grammar and voice files. > Yes, and it will break things for those who actually have things stored > other location. I don't see why pre-setting ${OPTS} in /etc/conf.d/freeswitch would break anything for anyone. Anyway, introducing separate variables for each switch, as you suggested, is certainly the better way to go. > Maybe we should introduce variables with sane values: > > -recordings ${recordings_dir:-/var/lib/freeswitch/recordings} \ > -grammar ${grammar_dir:-/var/lib/freeswitch/grammar} \ > -sounds ${sounds_dir:-/usr/share/freeswitch/sounds} \ > -storage ${storage_dir:-/var/lib/freeswitch} \ > ${OPTS} > Regards, Tiger --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---