Subject: Re: [alpine-devel] [PATCH] new aport: testing/pnmixer
To: alpine-devel@lists.alpinelinux.org
References: <1456869303-12595-1-git-send-email-hasufell@posteo.de>
From: "hasufell@posteo.de" <hasufell@posteo.de>
Message-ID: <56D6DA9D.7010403@posteo.de>
Date: Wed, 2 Mar 2016 13:20:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
Precedence: list
MIME-Version: 1.0
In-Reply-To: <1456869303-12595-1-git-send-email-hasufell@posteo.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit

On 03/01/2016 10:55 PM, Julian Ospald wrote:
[snip]

> +
> +die() {
> +    echo "$@"
> +    return 1
> +}
> +
> +build() {
> +    cd "${_builddir}"
> +    ./autogen.sh \
> +        --build=$CBUILD \
> +        --host=$CHOST \
> +        --prefix=/usr \
> +        --sysconfdir=/etc \
> +        --mandir=/usr/share/man \
> +        --localstatedir=/var \
> +        || die "configuration failed"
> +    make || die "building failed"
> +}
> +
> +package() {
> +    make -C "${_builddir}" DESTDIR="$pkgdir" install || die "installation failed"
> +}
> +

Silly mistake. "die" doesn't behave here like I think it does, but I
find those "return 1" calls a bit non-verbose. Using "exit 1" seems to
break the cleanup functions.


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---