DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=DKIM-Signature:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:References:In-Reply-To:Mime-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Cc:X-Mailer:From:Subject:Date:To;
  b=h93zKgSQxsvRrlQL05aZW8TOGr/4hFn63AT7za9nrZTlm1N0DGATKgiSWsFNuG/TT58NDD9E1BRcQb44grTaxocghze5KNF0Y2NWCPKOnVm4TCsvstp9kkDt+EjZFy8c72tP5rwgcBkzM8tl3XOQylxns7U/pSvlrDZmYQztlz0=  ;
References: <4F6E1119.8080306@arcor.de> <1333732837.18993.YahooMailNeo@web130105.mail.mud.yahoo.com> <4F8589D0.3010002@arcor.de>
In-Reply-To: <4F8589D0.3010002@arcor.de>
Precedence: list
Mime-Version: 1.0 (1.0)
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii
Message-Id: <6D2E9A25-1C97-4FED-B5D3-BC0123220404@yahoo.com>
Cc: "alpine-devel@lists.alpinelinux.org" <alpine-devel@lists.alpinelinux.org>
From: Ted Trask <ttrask01@yahoo.com>
Subject: Re: [alpine-devel] [Patch] acf-iptables: fixing model
Date: Wed, 11 Apr 2012 10:03:59 -0400
To: Der Tiger <der.tiger.alpine@arcor.de>

Ok, thanks for testing again. To make my life easier, can you send me an exa=
mple of a statement that doesn't work? I'm definitely not an iptables expert=
, so I'm not aware of all of the possibilities. Thanks.

Ted

On Apr 11, 2012, at 9:40 AM, Der Tiger <der.tiger.alpine@arcor.de> wrote:

> ReHi Ted,
>=20
> The patch works nicely! So far I didn't encounter any more problems
> entering and editing data in the existing fields of the iptables GUI form.=

>=20
> Due to the complexity of the iptables configuration not all possible
> options are represented in the form by dedicated field. For instance
> port REDIRECT statements in the nat table are not handled, so far.
> Unfortunately this causes the parameters to be thrown out, once the rule
> is edited, because the is no field in the form to hold the data.
>=20
> Therefore, I'd suggest to add an "Additional Options" field to the form,
> that is filled with all unrecognised fractions of the rule string in
> order to prevent those fractions from getting lost when the rule is saved.=

>=20
> Regards, Tiger
>=20
> Am 2012-04-06 19:20, schrieb Ted Trask:
>> Thank you for the patch, and sorry for the long delay before properly
>> responding. Unfortunately, the bugs you found were not the only ones
>> present. I guess acf-iptables hadn't been tested in a while. Please
>> see http://git.alpinelinux.org/cgit/acf-iptables/commit/?id=3Dce765fba9cf=
9fd1c4b1981ab137df35c4b662b04
>> for the changes I committed. Please try using the file
>> http://git.alpinelinux.org/cgit/acf-iptables/tree/iptables-model.lua to
>> make sure I fixed your reported problems. Once I hear back from you,
>> I'll feel more confident in bumping the package version.
>>=20
>> Ted
>>=20
>> ------------------------------------------------------------------------
>> *From:* Der Tiger <der.tiger.alpine@arcor.de>
>> *To:* alpine-devel@lists.alpinelinux.org
>> *Sent:* Saturday, March 24, 2012 2:23 PM
>> *Subject:* [alpine-devel] [Patch] acf-iptables: fixing model
>>=20
>> Hi,
>>=20
>> There are two bugs causing the web interface to malfunction when either
>> a protocol selection is negated using a exclamation mark (!) or a
>> comment is entered in the appropriate field of the form.
>>=20
>> PLEASE, make sure removing the escaping of the spec string does not
>> cause problems with certain data entered in the form! So far, I had no
>> troubles while testing, because the fields are checked in
>> validate_rule(), anyway.
>>=20
>> Regards, Tiger
>>=20
>> --- /usr/share/acf/app/iptables/iptables-model.lua.orig
>> +++ /usr/share/acf/app/iptables/iptables-model.lua
>> @@ -147 +147 @@
>> -    addparameter(rule.value.protocol.value, "-p")
>> +    addparameter(rule.value.protocol.value, "-p", true)
>> @@ -520 +520 @@
>> -        local cmd =3D path .. "iptables -t " ..
>> format.escapespecialcharacters(rule.value.table.value) .. " -R " ..
>> format.escapespecialcharacters(rule.value.chain.value) .. " " ..
>> format.escapespecialcharacters(rule.value.position.value) .. " " ..
>> format.escapespecialcharacters(spec) .. " 2>&1"
>> +        local cmd =3D path .. "iptables -t " ..
>> format.escapespecialcharacters(rule.value.table.value) .. " -R " ..
>> format.escapespecialcharacters(rule.value.chain.value) .. " " ..
>> format.escapespecialcharacters(rule.value.position.value) .. " " .. spec
>> .. " 2>&1"
>>=20
>>=20
>>=20
>> ---
>> Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
>> <mailto:unsubscribe@lists.alpinelinux.org>
>> Help:        alpine-devel+help@lists.alpinelinux.org
>> <mailto:help@lists.alpinelinux.org>
>> ---
>>=20
>>=20
>>=20
>=20
>=20
> ---
> Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> Help:         alpine-devel+help@lists.alpinelinux.org
> ---
>=20


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---