~alpine/devel

5 2

[alpine-devel] New aport diffutils

Leonardo Arena <rnalrd@gmail.com>
Details
Message ID
<9334be8a0901200056m31dd069ft258e4e3b9d491d7f@mail.gmail.com>
Sender timestamp
1232441809
DKIM signature
missing
Download raw message
Please see attached patch

Thanks
Leo
Details
Message ID
<1232442926.1947.17.camel@nc>
In-Reply-To
<9334be8a0901200056m31dd069ft258e4e3b9d491d7f@mail.gmail.com> (view parent)
Sender timestamp
1232442926
DKIM signature
missing
Download raw message
Hi Leo,

On Tue, 2009-01-20 at 09:56 +0100, Leonardo Arena wrote:
> Please see attached patch

Cool!

nclab01:~/aports/extra/diffutils$ tar -ztf diffutils-2.8.1-r0.apk     
.PKGINFO
usr/
usr/info/
usr/info/diff.info
^^^^
this belongs in -doc package.

usr/bin/
usr/bin/cmp
usr/bin/diff
usr/bin/diff3
usr/bin/sdiff

Otherwise good.

> 
> Thanks
> Leo 
> 
> 
> 
> 
> 
> 
> differences
> between files
> attachment
> (0001-extra-diffutils-new-aport.patch)
> 
> From f80e154e092e4d19868f3aa73451ce2ff1e9f869 Mon Sep 17 00:00:00 2001
> From: Leonardo Arena <root@df1844j.(none)>
> Date: Tue, 20 Jan 2009 08:53:29 +0000
> Subject: [PATCH] extra/diffutils: new aport
...
> +build() {
> +       cd "$srcdir/$pkgname-$pkgver"
> +
> +       ./configure --prefix=/usr --mandir=/usr/share/man

so we should use:

	./configure --prefix=/usr --mandir=/usr/share/man\
		--infodir=/usr/share/info

I can fix that.

> +       make || return 1
> +       make check || return 1
> +       make install DESTDIR=$pkgdir
> +}
> +md5sums="71f9c5ae19b60608f6c7f162da86a428  diffutils-2.8.1.tar.gz"


Otherwise it looks good. Is it ok if you maintain this package? It means
your name and email is in top and bugs and fixes for this package goes
to you. You create patches which i verify and commit.

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Leonardo Arena <rnalrd@gmail.com>
Details
Message ID
<9334be8a0901200122j224ff2afr81109f6405ca3e85@mail.gmail.com>
In-Reply-To
<1232442926.1947.17.camel@nc> (view parent)
Sender timestamp
1232443355
DKIM signature
missing
Download raw message
It's ok, thanks for reviewing!

On Tue, Jan 20, 2009 at 10:15 AM, Natanael Copa <natanael.copa@gmail.com>wrote:

> Hi Leo,
>
>
> Otherwise it looks good. Is it ok if you maintain this package? It means
> your name and email is in top and bugs and fixes for this package goes
> to you. You create patches which i verify and commit.
>
> -nc
>
>
Details
Message ID
<1232443497.1947.23.camel@nc>
In-Reply-To
<9334be8a0901200122j224ff2afr81109f6405ca3e85@mail.gmail.com> (view parent)
Sender timestamp
1232443497
DKIM signature
missing
Download raw message
On Tue, 2009-01-20 at 10:22 +0100, Leonardo Arena wrote:
> It's ok, thanks for reviewing!

woot!

your commit:
http://dev.alpinelinux.org/cgit/cgit.cgi/aports/commit/?id=3b847621b75c355d7d97d102f4cf0ea1b37a4e14

the fix:
http://dev.alpinelinux.org/cgit/cgit.cgi/aports/commit/?id=c08adf6896312a22de8fbc050c5d74d32166a98d

Thanks!


> 
> On Tue, Jan 20, 2009 at 10:15 AM, Natanael Copa
> <natanael.copa@gmail.com> wrote:
>         Hi Leo,
>         
>         
>         Otherwise it looks good. Is it ok if you maintain this
>         package? It means
>         your name and email is in top and bugs and fixes for this
>         package goes
>         to you. You create patches which i verify and commit.
>         
>         -nc
>         
> 



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Details
Message ID
<1232443643.1947.25.camel@nc>
In-Reply-To
<9334be8a0901200122j224ff2afr81109f6405ca3e85@mail.gmail.com> (view parent)
Sender timestamp
1232443643
DKIM signature
missing
Download raw message
On Tue, 2009-01-20 at 10:22 +0100, Leonardo Arena wrote:
> It's ok, thanks for reviewing!

btw... Look at the "Author of the commit"
http://dev.alpinelinux.org/cgit/cgit.cgi/aports/commit/?id=3b847621b75c355d7d97d102f4cf0ea1b37a4e14

You should probably set your email address in git:

git config --global user.email you@yourdomain.example.com

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Leonardo Arena <rnalrd@gmail.com>
Details
Message ID
<9334be8a0901200133g1ecc5033s88b4f7241431e2ee@mail.gmail.com>
In-Reply-To
<1232443643.1947.25.camel@nc> (view parent)
Sender timestamp
1232444020
DKIM signature
missing
Download raw message
Done!

Thanks

On Tue, Jan 20, 2009 at 10:27 AM, Natanael Copa <natanael.copa@gmail.com>wrote:

> On Tue, 2009-01-20 at 10:22 +0100, Leonardo Arena wrote:
> > It's ok, thanks for reviewing!
>
> btw... Look at the "Author of the commit"
>
> http://dev.alpinelinux.org/cgit/cgit.cgi/aports/commit/?id=3b847621b75c355d7d97d102f4cf0ea1b37a4e14
>
> You should probably set your email address in git:
>
> git config --global user.email you@yourdomain.example.com
>
> -nc
>
>
Reply to thread Export thread (mbox)