X-Original-To: alpine-devel@lists.alpinelinux.org Received: from forward1p.cmail.yandex.net (forward1p.cmail.yandex.net [77.88.31.16]) by lists.alpinelinux.org (Postfix) with ESMTP id 6A6955C420B for ; Thu, 26 Jan 2017 15:51:04 +0000 (GMT) Received: from smtp2o.mail.yandex.net (smtp2o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::26]) by forward1p.cmail.yandex.net (Yandex) with ESMTP id E753121103; Thu, 26 Jan 2017 18:51:01 +0300 (MSK) Received: from smtp2o.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp2o.mail.yandex.net (Yandex) with ESMTP id 318C05080E97; Thu, 26 Jan 2017 18:50:59 +0300 (MSK) Received: by smtp2o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 9LRFlFUD38-ouCORI0o; Thu, 26 Jan 2017 18:50:57 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1485445857; bh=u6eHbYTmcxR88nm6f0FsHFTd9UfzOcmRsync9moZqmo=; h=Date:In-Reply-To:References:Subject:To:CC:From:Message-ID; b=Ny8pl48mrtW5x3w+/zB09V9b3/jejrWlfcZ9toIrlZgdFQ8aDdmUtuBYO+rTUd6Mf 3gbKGmuZpySHFu+z67S2jr59xVFnrJwm8ToswyIu9HbnSWgqwSMW2etueyo4Vy/4hK gfEmuAvoTAGEy6CT+CeS7+pGURPLptGFEWo/n5BQ= Authentication-Results: smtp2o.mail.yandex.net; dkim=pass header.i=@yandex.com X-Yandex-Suid-Status: 1 0,1 0,1 0,1 0 Date: Thu, 26 Jan 2017 16:50:54 +0100 In-Reply-To: <4EDA0683-3991-44D0-882C-C34FBD4C38B2@jirutka.cz> References: <20170126112655.44ad5c0e@vostro.util.wtbts.net> <4EDA0683-3991-44D0-882C-C34FBD4C38B2@jirutka.cz> X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----XPFGDSPAZDGTAEPR84M6IJBNFMH2L2" Content-Transfer-Encoding: 7bit Subject: Re: [alpine-devel] Proposal: testsuite support in APKBUILDs To: alpine-devel@lists.alpinelinux.org,Jakub Jirutka ,Timo Teras CC: William Pitcock From: =?UTF-8?Q?=C5=81ukasz_Jendrysik?= Message-ID: <9E6F2B08-FE29-48A8-BCC9-7D5B0547B35D@yandex.com> ------XPFGDSPAZDGTAEPR84M6IJBNFMH2L2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable +1 On January 26, 2017 2:08:29 PM GMT+01:00, Jakub Jirutka wrote: >Hi, > >currently we have the following phases: sanitycheck, builddeps, clean, >fetch, unpack, prepare, mkusers, rootpkg, cleanup=2E All of them except >rootpkg are verbs=2E So I=E2=80=99d prefer =E2=80=9Ccheck=E2=80=9D (as Ar= ch) instead of >=E2=80=9Ctestsuite=E2=80=9D=2E > >Jakub > >> On 26=2E Jan 2017, at 10:26, Timo Teras wrote: >>=20 >> On Wed, 25 Jan 2017 21:38:00 -0600 >> William Pitcock wrote: >>=20 >>> As such, I propose we add a testsuite() phase to the build process, >>> that runs after build(), but prior to package()=2E APKBUILDs should >>> override the testsuite phase, but the default_testsuite() function >>> will be a noop for the Alpine 3=2E6 release cycle that raises a >warning >>> that the APKBUILD does not define any mechanism for running a >>> testsuite=2E If "!testsuite" is defined in $features, the warning is >>> ignored=2E >>>=20 >>> For cross-builds, the testsuite would be skipped unless the package >>> is noarch=2E >>>=20 >>> After Alpine 3=2E6 (or maybe 3=2E7), we change the warning to a fatal >>> error, requiring APKBUILDs to explicitly opt out of running a >>> testsuite through $features=2E >>>=20 >>> Thoughts? >>=20 >> +1 >>=20 >> We have some packages that run 'make check' or similar, but it would >be >> good to make it a separate step=2E >>=20 >> The above plan sounds good to me=2E >>=20 >> Thanks, >> Timo >>=20 >>=20 >> --- >> Unsubscribe: alpine-devel+unsubscribe@lists=2Ealpinelinux=2Eorg >> Help: alpine-devel+help@lists=2Ealpinelinux=2Eorg >> --- >>=20 > > > >--- >Unsubscribe: alpine-devel+unsubscribe@lists=2Ealpinelinux=2Eorg >Help: alpine-devel+help@lists=2Ealpinelinux=2Eorg >--- --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------XPFGDSPAZDGTAEPR84M6IJBNFMH2L2 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable +1

On January 26= , 2017 2:08:29 PM GMT+01:00, Jakub Jirutka <jakub@jirutka=2Ecz> wrote= :
Hi,

currently we have the following phase=
s: sanitycheck, builddeps, clean, fetch, unpack, prepare, mkusers, rootpkg,=
 cleanup=2E All of them except rootpkg are verbs=2E So I’d prefer &ld=
quo;check” (as Arch) instead of “testsuite”=2E

Jakub

 On 26=
=2E Jan 2017, at 10:26, Timo Teras <timo=2Eteras@iki=2Efi> wrote:
 
 On Wed, 25 Jan 2017 21:38:00 -0600
 William Pitcock <neno=
lod@dereferenced=2Eorg> wrote:
 
 As such, I propose we add a testsuite() phase to the b=
uild process,
 that runs after build(), but prior to package()=2E  APK=
BUILDs should
 override the testsuite phase, but the default_testsuite=
() function
 will be a noop for the Alpine 3=2E6 release cycle that ra=
ises a warning
 that the APKBUILD does not define any mechanism for ru=
nning a
 testsuite=2E  If "!testsuite" is defined in $featur=
es, the warning is
 ignored=2E
 
 For cross-builds, the test=
suite would be skipped unless the package
 is noarch=2E
 
 A=
fter Alpine 3=2E6 (or maybe 3=2E7), we change the warning to a fatal
 =
error, requiring APKBUILDs to explicitly opt out of running a
 testsui=
te through $features=2E
 
 Thoughts?
 
 +1=

 
 We have some packages that run 'make check' or similar, but i=
t would be
 good to make it a separate step=2E
 
 The above =
plan sounds good to me=2E
 
 Thanks,
 Timo
 
 
 ---
 Unsubscribe:  alpine-devel+unsubscribe@lists=2Ealpinelinux=2Eo=
rg
 Help:         alpine-devel+help@lists=2Ealpinelinux=2Eorg
 --=
-
 



---
Unsubscribe:  alpine-=
devel+unsubscribe@lists=2Ealpinelinux=2Eorg
Help:         alpine-devel=
+help@lists=2Ealpinelinux=2Eorg
---


--
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------XPFGDSPAZDGTAEPR84M6IJBNFMH2L2-- --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---