X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@lists.alpinelinux.org
Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182])
	by lists.alpinelinux.org (Postfix) with ESMTP id 72EFE1EBFFA
	for <alpine-devel@lists.alpinelinux.org>; Mon, 24 Jan 2011 07:35:15 +0000 (UTC)
Received: by iyb26 with SMTP id 26so3822828iyb.13
        for <alpine-devel@lists.alpinelinux.org>; Sun, 23 Jan 2011 23:35:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        bh=B9r5vjvAFbKO43Mz9kpfYcqqUUZ4XBuUPEJsQ/KoZxE=;
        b=wOkVGm2iyH/IZ8VqUE2d/baW+kk/b4QGc9BcRAdjYJQdUcn54hMSDP8LcHazGZaCZu
         uGalx4JVVVXDs6p/NG89je05lBcz6yz0G5wRAymSjfQF8F8SQ/6ZM2XovnoqScGL2iyk
         evuXzoqY6ldDkCodNLmqXEsKiIJ2JwxImb99c=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=rNYTN+9jhK6Yg1K+AtLysu2+ApieaZ4rnfFV2Zz0Fgi4KQjlSuczUTC75p1e06Mdtp
         WuDp4dBl8eq5AUQfQoJdIHNKxcfsIxbqiTCln2n5ouc/U1+nke6dcmHBHYEO3OJezGDm
         CWktgs7j7M15BscqoM/jXReeUepY/V87sVBqc=
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Received: by 10.231.31.139 with SMTP id y11mr4289531ibc.96.1295854515275; Sun,
 23 Jan 2011 23:35:15 -0800 (PST)
Received: by 10.231.19.130 with HTTP; Sun, 23 Jan 2011 23:35:15 -0800 (PST)
In-Reply-To: <1295759701-17319-1-git-send-email-jbilyk@gmail.com>
References: <1295759701-17319-1-git-send-email-jbilyk@gmail.com>
Date: Mon, 24 Jan 2011 08:35:15 +0100
Message-ID: <AANLkTikmXCXASzHqWLDYtNW92_6Bhz0AHq3siE1r6bk8@mail.gmail.com>
Subject: Re: [alpine-devel] [PATCH] testing/perl-dbd-sqlite: new aport
From: Leonardo Arena <rnalrd@gmail.com>
To: alpine-devel@lists.alpinelinux.org
Cc: Jeff Bilyk <jbilyk@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 23, 2011 at 6:15 AM, Jeff Bilyk <jbilyk@gmail.com> wrote:
> new aport
> ---
> =A0testing/perl-dbd-sqlite/APKBUILD | =A0 32 ++++++++++++++++++++++++++++=
++++
> =A01 files changed, 32 insertions(+), 0 deletions(-)
> =A0create mode 100644 testing/perl-dbd-sqlite/APKBUILD
>
> diff --git a/testing/perl-dbd-sqlite/APKBUILD b/testing/perl-dbd-sqlite/A=
PKBUILD
> new file mode 100644
> index 0000000..72f8ef4
> --- /dev/null
> +++ b/testing/perl-dbd-sqlite/APKBUILD
> @@ -0,0 +1,32 @@
> +# Contributor: Jeff Bilyk <jbilyk at gmail>
> +# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
> +pkgname=3Dperl-dbd-sqlite
> +_realpkgname=3DDBD-SQLite
> +pkgver=3D0.31
> +pkgrel=3D0
> +pkgdesc=3D"Perl CPAN DBD::SQLite module"
> +url=3D"http://search.cpan.org/dist/${_realpkgname}"
> +arch=3D"all"
> +license=3D"GPL PerlArtistic"
> +depends=3D"perl-dbi"
> +makedepends=3D"perl perl-dev"
> +source=3D"http://search.cpan.org/CPAN/authors/id/M/MS/MSERGEANT/${_realp=
kgname}-$pkgver.tar.gz"
> +
> +_builddir=3D"$srcdir"/${_realpkgname}-$pkgver
> +
> +prepare() {
> + =A0 =A0 =A0 return 0
> +}
> +
> +build() {
> + =A0 =A0 =A0 cd "$_builddir"
> + =A0 =A0 =A0 perl Makefile.PL INSTALLDIRS=3Dvendor

It would be better to set variable PERL_MM_USE_DEFAULT to 1, so that
ExtUtils::MakeMaker should not ask any question. It would be better to
add a "|| return 1" at the end.

> + =A0 =A0 =A0 make || return 1
> +}
> +
> +package() {
> + =A0 =A0 =A0 cd "$_builddir"
> + =A0 =A0 =A0 make DESTDIR=3D"$pkgdir" install

"Make" should have a "|| return 1".
After installing, you should search for perlocal.pod file and delete
it. It creates file collisions among perl packages.

# creates file collision among perl modules
find "$pkgdir" -name perllocal.pod -delete

> +}
> +
> +md5sums=3D"4aa99c39104b7cd39129aec548e7d3e4 =A0DBD-SQLite-0.31.tar.gz"
> --
> 1.7.3.5

I've applied those fixes, and took maintainership.

Thanks!

- leo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---