Received: from mail.cmpwn.com (mail.cmpwn.com [45.56.77.53])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 9F470781AE4
	for <~alpine/devel@lists.alpinelinux.org>; Fri, 27 Sep 2019 20:01:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cmpwn.com; s=cmpwn;
	t=1569614513; bh=Xy8I5CCuFS0HM+6tyv8trzyExU8slQF9nsS/fguOvXs=;
	h=In-Reply-To:Date:From:To:Subject;
	b=IWiXys7fvKIeW7fsIFpkj4ig2E1tQGo9vyywRCD12Or6H1u3RgPW+/aBk0XYVyWA/
	 iafYXAMq38//yECey+byz3gn/uKNg7I22QXpE04TWz2WYAeVSQQf6DUW0B15GU1Ue1
	 gyvKq+4+JN1EtMvS5tCRfH3J9QBPVh3EAgJN6GfY=
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <20190925151226.mcurtpbxekq4gvtu@arch>
Date: Fri, 27 Sep 2019 16:01:53 -0400
From: "Drew DeVault" <sir@cmpwn.com>
To: "Ivan Tham" <pickfire@riseup.net>, <~alpine/devel@lists.alpinelinux.org>
Subject: Re: [PATCH v2] Support encrypted root in setup-disk
Message-Id: <BXB1WOTW9VIO.21XBMH1DR9RP3@homura>

On Wed Sep 25, 2019 at 11:12 PM Ivan Tham wrote:
> Why not just `cryptsetup status "$rootdev" | awk '/device:/ { print $2 }'`?

+1

> I think we should probably add a TODO for cryptkey.

cryptkey?

> >@@ -1290,6 +1321,15 @@ if [ -n "$diskdevs" ] && [ -z "$DISK_MODE" ]; the=
n
> > 		esac
> > 	done
> > 	DISK_MODE=3D"$answer"
> >+	# TODO: support encryption for more installation types
> >+	if [ -z "$USE_CRYPT" ] && [ "$DISK_MODE" =3D "sys" ] && [ -z "$USE_LVM=
" ]; then
> >+		echon "Would you like to encrypt $it_them? [y/N] "
> >+		default_read answer '?'
> >+		if yesno "$answer"
> >+		then
> >+			USE_CRYPT=3D1
> >+		fi
> >+	fi
> > fi
> >
> > if [ -z "$SWAP_SIZE" ]; then
>=20
> I was wondering why only LVM gets that first, in my mind many people use
> LUKS without LVM, maybe I was wrong.

I don't understand this question.