Subject: [alpine-devel] Proposal: testsuite support in APKBUILDs

From: William Pitcock <[email-masked]>
Date: Wed, 25 Jan 2017 21:38:00 -0600

Hello,

A concern I hear occasionally from people when discussing Alpine as a
distribution they could use for their projects is that Alpine does not
typically run testsuites in APKBUILDs.  This is largely because abuild
does not have awareness of testsuites.

As such, I propose we add a testsuite() phase to the build process,
that runs after build(), but prior to package().  APKBUILDs should
override the testsuite phase, but the default_testsuite() function
will be a noop for the Alpine 3.6 release cycle that raises a warning
that the APKBUILD does not define any mechanism for running a
testsuite.  If "!testsuite" is defined in $features, the warning is
ignored.

For cross-builds, the testsuite would be skipped unless the package is noarch.

After Alpine 3.6 (or maybe 3.7), we change the warning to a fatal
error, requiring APKBUILDs to explicitly opt out of running a
testsuite through $features.

Thoughts?

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Natanael Copa <[email-masked]>
Date: Thu, 26 Jan 2017 12:22:37 +0100

On Wed, 25 Jan 2017 21:38:00 -0600

> testsuite through $features.

Sounds good to me.

-nc

---

---

From: Timo Teras <[email-masked]>
Date: Thu, 26 Jan 2017 11:26:55 +0200

> testsuite through $features.

+1

We have some packages that run 'make check' or similar, but it would be
good to make it a separate step.

The above plan sounds good to me.

Thanks,
Timo

---

---

From: Jakub Jirutka <[email-masked]>
Date: Thu, 26 Jan 2017 14:08:29 +0100

Hi,

currently we have the following phases: sanitycheck, builddeps, clean, fetch, unpack, prepare, mkusers, rootpkg, cleanup. All of them except rootpkg are verbs. So I’d prefer “check” (as Arch) instead of “testsuite”.

Jakub

> On 26. Jan 2017, at 10:26, Timo Teras <[email-masked]> wrote:
> 

---

---

From: Łukasz Jendrysik <[email-masked]>
Date: Thu, 26 Jan 2017 16:50:54 +0100

+1

On January 26, 2017 2:08:29 PM GMT+01:00, Jakub Jirutka <[email-masked]> wrote:
>Hi,
>
>currently we have the following phases: sanitycheck, builddeps, clean,
>fetch, unpack, prepare, mkusers, rootpkg, cleanup. All of them except
>rootpkg are verbs. So I’d prefer “check” (as Arch) instead of
>“testsuite”.
>
>Jakub
>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

---

From: 7heo <[email-masked]>
Date: Thu, 26 Jan 2017 15:55:56 +0000

Hey,
 
Since we're talking about vocabulary and semantics, I would rather avoid check, since it doesn't reflect what happens. A testsuite is a suite (set of, ordered, predictable) of tests (dynamic procedure to validate an element, that has to be executed). A check is merely an observation with assertion on an existing state. As an example, you can check the door is open, but you have to test if the lock works (you can't just check it in normal conditions and without a specialized apparatus).
 
Long story short, I don't have any problem with making it shorter and simpler, but I would rather have something that matches what is actually does. :)
 
Theo.

On Thu Jan 26 14:08:29 2017 GMT+0100, Jakub Jirutka wrote:
>�˛���m楦)�u�ޗ맲��r��zX��ƥ�)ޖ)�Ɗ��ijZb��^��~��i�+-��i�w��{���