Precedence: list
MIME-Version: 1.0
In-Reply-To: <20140715162818.0f5adca9@ncopa-desktop.alpinelinux.org>
References: <1405457044-3186-1-git-send-email-ibid.ag@gmail.com>
	<20140715162818.0f5adca9@ncopa-desktop.alpinelinux.org>
Date: Wed, 16 Jul 2014 00:51:21 -0500
Message-ID: <CA+T2pCEbZcdwnXgZfUKLqBWc20MAmj-FtOqdvkuEx=UnR-2A_g@mail.gmail.com>
Subject: Re: [alpine-devel] [PATCH] testing/sword: add new package
From: William Pitcock <nenolod@dereferenced.org>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: Isaac Dunham <ibid.ag@gmail.com>, alpine-devel@lists.alpinelinux.org
Content-Type: text/plain; charset=UTF-8

Hello!

On Tue, Jul 15, 2014 at 9:28 AM, Natanael Copa <ncopa@alpinelinux.org> wrote:
> On Tue, 15 Jul 2014 13:44:04 -0700
> Isaac Dunham <ibid.ag@gmail.com> wrote:
>
>> Sword is a library for free Bible software.
>> It can also be used for other books.
> ...
>
>> +++ b/testing/sword/01-corediatheke.patch
>> @@ -0,0 +1,18 @@
>> +diff --git a/utilities/diatheke/corediatheke.cpp b/utilities/diatheke/corediatheke.cpp
>> +index 6e05e7c..c2b6efb 100644
>> +--- a/utilities/diatheke/corediatheke.cpp
>> ++++ b/utilities/diatheke/corediatheke.cpp
>> +@@ -454,7 +454,6 @@ void doquery(unsigned long maxverses = -1, unsigned char outputformat = FMT_PLAI
>> +                                             if (font) { *output << "style=\"font:\""  << font << ";\" " ;}
>> +                                             if (strcmp(modlocale,locale) !=0 ) { *output << "lang=\"" << modlocale << "\"";}
>> +                                             *output << ">";
>> +-                                    }
>> +                             }
>> +
>> +                             if (font && (outputformat == FMT_HTML || outputformat == FMT_HTMLHREF || outputformat == FMT_XHTML || outputformat == FMT_THML || outputformat == FMT_CGI)) {
>> +@@ -498,4 +497,4 @@ void doquery(unsigned long maxverses = -1, unsigned char outputformat = FMT_PLAI
>> +             }
>> +
>> +     }
>> +-
>> ++}
>
> I saw your work with upstream to get this fixed. What I find
> interesting is that they didn't catch an error like this upstream. Why
> didn't the problem show up on glibc?
>
> musl again causes hidden bugs bubble up to the surface.
>
> Good job!
>
> Applied. Thanks!
>
> -nc

Since this package was added to testing, there was a discussion on an
IRC channel where this software became interesting to test, as I
wanted to factcheck some things being claimed on it.

Unfortunately, I discovered that after installing sword and
sword-utils, and then running:

user$ installmgr -init
[...]
user$ installmgr -r CrossWire
user$ installmgr -ri CrossWire KJV

Then doing a query using diatheke:

user$ diatheke -b KJV -k ...

Nothing came up.  Running strace(1) on diatheke showed it required the
data files to be installed as root before the software would function
correctly.

With the software configured as root, it functions correctly, however
I believe this is a policy violation as software is typically supposed
to be accessible to the user without configuration systemwide, and
installmgr does *something* with the data it downloads when running as
a user.

I am not sure about why it is malfunctioning, if you have any feedback
let me know.

- kaniini


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---