Precedence: list
MIME-Version: 1.0
In-Reply-To: <CAArrbi1iwc7pgpGCUsr0xUz+NYnJ-LhRfQr-13CaJRxLbUfPhg@mail.gmail.com>
References: <CAArrbi1iwc7pgpGCUsr0xUz+NYnJ-LhRfQr-13CaJRxLbUfPhg@mail.gmail.com>
Date: Wed, 9 Nov 2011 14:41:50 +0100
Message-ID: <CA+cSEmNacjPqNQaPpVUSycBehMHbVkw9fPJCx5dfG5YAaVFUkQ@mail.gmail.com>
Subject: Re: [alpine-devel] pnp4nagios
From: Carlo Landmeter <clandmeter@gmail.com>
To: Peter de Zoeten <peter@dezoeten.mine.nu>
Cc: alpine-devel@lists.alpinelinux.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 8, 2011 at 10:34 PM, Peter de Zoeten <peter@dezoeten.mine.nu> w=
rote:
> Hello all,
>
> i'm a little in doubt at the moment;
>
> I compiled pnp4nagios with the following git diff. PNP4Nagios is
> heavily dependend on PHP. So should i make a php package?

If the package consist of a binary/script files and php files which
can run separately on different server (and make sense) it would make
sense to split them.
If not, then just keep it in the same package and add the necessary
depends to it.

> And also: in this APKBUILD the package install to
> /usr/local/pnp4nagios; should i try to get it to webapps?

You have an empty configure line in your apkbuild. This makes "make
install" go to usr/local.
newapkbuild has logic to download the src for you and analyze it and
prepare a proper apkbuild for you.
Because this is a sf.net source, you need to use the -s switch like this:

newapkbuild -s http://sourceforge.net/projects/pnp4nagios/files/PNP-0.6/pnp=
4nagios-0.6.15.tar.gz

While normally you can skip the -s part and just append the src url.
I don't know where the php files are installed, but if its some kind
of interface, i guess it would make sense to move it to webapps dir.

Please create git patches with "git format-patch" and add a sane
commit message to that commit like we use in our aports tree. Please
check aports git log for reference:

http://git.alpinelinux.org/cgit/aports/log

Please keep in mind, if you set yourself as maintainer, try to keep
the aport up-to-date by sending us patches.
If you are going to send us patches on a regular basis we suggest you
to request your own repo to be hosted on git.alpinelinux.org or setup
your own repo (i.e. github) from which we can fetch.

Thanks!

-carlo

> This is the git APKBUILD package:
>
> Look at www.pnp4nagios.org for all information
> ---
> =A0testing/pnp4nagios/APKBUILD | =A0 64 +++++++++++++++++++++++++++++++++=
++++++++++
> =A01 files changed, 64 insertions(+), 0 deletions(-)
> =A0create mode 100644 testing/pnp4nagios/APKBUILD
>
> diff --git a/testing/pnp4nagios/APKBUILD b/testing/pnp4nagios/APKBUILD
> new file mode 100644
> index 0000000..3ee1ec2
> --- /dev/null
> +++ b/testing/pnp4nagios/APKBUILD
> @@ -0,0 +1,64 @@
> +# Contributor: Peter de Zoeten <peter@dezoeten.mine.nu>
> +# Maintainer: =A0Peter de Zoeten <peter@dezoeten.mine.nu>
> +pkgname=3Dpnp4nagios
> +pkgver=3D0.6.15
> +pkgrel=3D0
> +pkgdesc=3D"PNP4Nagios"
> +url=3D"http://www.pnp4nagios.org"
> +arch=3D"all"
> +license=3D"GPL"
> +depends=3D"nagios rrdtool perl-time-hires perl-rrd php-zlib libgcc"
> +depends_dev=3D""
> +makedepends=3D"$depends_dev"
> +install=3D""
> +#subpackages=3D"$pkgname-doc $pkgname-php"
> +subpackages=3D"$pkgname-doc"
> +
> +source=3D"http://sourceforge.net/projects/pnp4nagios/files/pnp4nagios/pn=
p4nagios-$pkgver/pnp4nagios-$pkgver.tar.gz"
> +
> +#source=3D"saveas-http://downloads.sourceforge.net/project/pnp4nagios/PN=
P-0.6/pnp4nagios-0.6.15.tar.gz?r=3Dhttp%3A%2F%2Fsourceforge.net%2Fprojects%=
2Fpnp4nagios%2Ffiles%2FPNP-0.6%2F&ts=3D1318875996&use_mirror=3Dheanet/pnp4n=
agios-0.6.15.tar.gz"
> +
> +_builddir=3D"$srcdir"/$pkgname-$pkgver
> +prepare() {
> + =A0 =A0 =A0 local i
> + =A0 =A0 =A0 cd "$_builddir"
> + =A0 =A0 =A0 for i in $source; do
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 case $i in
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 *.patch) msg $i; patch -p1 -i "$srcdir"/$i =
|| return 1;;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 esac
> + =A0 =A0 =A0 done
> +}
> +
> +build() {
> + =A0 =A0 =A0 cd "$_builddir"
> + =A0 =A0 =A0 ./configure || return 1
> + =A0 =A0 =A0 make all || return 1
> +}
> +doc() {
> + =A0 =A0 =A0 =A0arch=3D"noarch"
> + =A0 =A0 =A0 =A0# Man pages
> + =A0 =A0 =A0 =A0mkdir -p "$subpkgdir"/usr/share/man || return 1
> + =A0 =A0 =A0 =A0mv "$pkgdir"/usr/local/pnp4nagios/man/man*
> "$subpkgdir"/usr/share/man/ \
> + =A0 =A0 =A0 =A0|| return 1
> +
> + =A0 =A0 =A0 =A0# Doc files
> + =A0 =A0 =A0 =A0_docs=3D"INSTALL README"
> + =A0 =A0 =A0 =A0for _doc in $_docs; do
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0install -Dm644 "$srcdir"/$pkgname-$pkgve=
r/$_doc \
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 "$subpkgdir"/usr/share/doc/$pkgname/$_doc |=
| return 1
> + =A0 =A0 =A0 =A0done
> + =A0 =A0 =A0 rmdir "$pkgdir"/usr/local/pnp4nagios/man/
> +}
> +
> +package() {
> + =A0 =A0 =A0 cd "$_builddir"
> + =A0 =A0 =A0 make fullinstall DESTDIR=3D"$pkgdir" || return 1
> + =A0 =A0 =A0 mkdir -p "$pkgdir"/usr/share/nagios/htdocs/ssi
> + =A0 =A0 =A0 cp "$_builddir"/contrib/ssi/status-header.ssi
> "$pkgdir"/usr/share/nagios/htdocs/ssi/status-header.ssi
> +# =A0 =A0 =A0 rm -rf "$pkgdir"/etc/httpd
> + =A0 =A0 =A0 mkdir -p "$pkgdir"/etc/lighttpd
> + =A0 =A0 =A0 cp "$_builddir"/sample-config/lighttpd.pnp4nagios.conf
> "$pkgdir"/etc/lighttpd/pnp4nagios.conf.sample
> +}
> +
> +
> +md5sums=3D"27cdab96510e15cfa0f4b7c2bf15dd2b =A0pnp4nagios-0.6.15.tar.gz"
>
> Let me know what you think. It works fine the way it is compiled now.
>
> Regards, Peter
>
>
> ---
> Unsubscribe: =A0alpine-devel+unsubscribe@lists.alpinelinux.org
> Help: =A0 =A0 =A0 =A0 alpine-devel+help@lists.alpinelinux.org
> ---
>
>


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---