Precedence: list
MIME-Version: 1.0
In-Reply-To: <4EA555E7.1030301@freemail.gr>
References: <4EA555E7.1030301@freemail.gr>
Date: Mon, 24 Oct 2011 16:29:26 +0200
Message-ID: <CA+cSEmMPNx=Nmmfft4mQSS7Rzsise5U7_XZhbFLVyQ8hXORM9w@mail.gmail.com>
Subject: Re: [alpine-devel] APKBUILD for liboping
From: Carlo Landmeter <clandmeter@gmail.com>
To: Harry Lachanas <grharry@freemail.gr>
Cc: Alpine Development <alpine-devel@lists.alpinelinux.org>
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Oct 24, 2011 at 2:11 PM, Harry Lachanas <grharry@freemail.gr> wrote:
> I am trying to contribute some stuff into alpine ...
>
> Please excuse any mistakes or typos ...
> It compiles ok on my system(s) ..
>

Hi Harry, Thanks for your contributions

Let me try to give you some feedback on both your apkbuilds

1. We would appreciate if you could provide us with git patches or a
repo where we can pull from. (more info in our wiki)
2. You did not provide any Maintainer or Contributor information. We
cannot merge apkbuilds without any of them. (we need maintainer if it
needs to go into main (after testing) or only contributor if it goes
into testing).
3. It looks like you created your apkbuild manually. We suggest next
time you try our newapkbuild script (please check our wiki), which
will setup a template for you to edit. It will contain some defaults
which each apkbuild need.
4. I don't think its good to set optimizations inside the apkbuild.
Its better if we set that globally in abuild except if the build fails
of course.
5. Your depends has -dev packages. These are build dependencies which
should go into makedepends or makedepends-dev
6. You dont need to specify the dev or doc functions when nothing
special has to be done. It will be automatically called by subpackages
var.
7. liboping didn't correctly "make install". (missing setcap). If you
use abuild you would have noticed.
7. Please set your pkgrel to 0 on your initial commit
8. Could you provide a contributor line so i can commit them, or even
better generate git patches? You can find info about git patches in
our wiki.



Thanks!

Carlo

> Thanks
> Harry
>
>
>


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---