Precedence: list
MIME-Version: 1.0
From: Carlo Landmeter <clandmeter@gmail.com>
Date: Tue, 24 Oct 2017 15:46:15 +0200
Message-ID: <CA+cSEmNptoEO1O3L+3T-uHFOULKYoYx6HDouJNrxM8M1vmJd+A@mail.gmail.com>
Subject: [alpine-devel] Halt CI on missing testsuite/check
To: Alpine-devel <alpine-devel@lists.alpinelinux.org>
Content-Type: multipart/alternative; boundary="001a1144161ac7fe3b055c4b29d2"

--001a1144161ac7fe3b055c4b29d2
Content-Type: text/plain; charset="UTF-8"

Hi friends,

I was going over the PR queue yesterday and found out that many of our
fellow
developers/contributors found their way to github and help us to bump
versions
of packages which are out of date. We appricate the time spend but it would
be
great if those contributors could also take care of the recent addition of
testsuite support (aka abuild check).

The idea is to add a check function to our apkbuilds and run tests that are
created by upsteam in their scripts. Examples of such tests suites are
"make check" and "make test". If for any reason upstream did not include any
testsuites an alternative could be to just add a simple cmd --help >
/dev/null
to atleast make sure the resulting binaries actually work.

If by any chance the included testsuites fail it would be nice if
contributors
would try to fix them (send patches upstream) or else atleast indicate why
they
fail and add a message to the commit log and set options to include !check.

To actually gain attention regarding testsuites my suggestion would be to
require testsuites (abuild check) on our current CI. I wrote a small patch
[1]
to let abuild halt if check is not found (currently it only issues a
warning).


1. http://tpaste.us/40l1


-carlo

--001a1144161ac7fe3b055c4b29d2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi friends,</div><div><br></div><div>I was going over=
 the PR queue yesterday and found out that many of our fellow</div><div>dev=
elopers/contributors found their way to github and help us to bump versions=
</div><div>of packages which are out of date. We appricate the time spend b=
ut it would be</div><div>great if those contributors could also take care o=
f the recent addition of=C2=A0</div><div>testsuite support (aka abuild chec=
k).=C2=A0</div><div><br></div><div>The idea is to add a check function to o=
ur apkbuilds and run tests that are=C2=A0</div><div>created by upsteam in t=
heir scripts. Examples of such tests suites are=C2=A0</div><div>&quot;make =
check&quot; and &quot;make test&quot;. If for any reason upstream did not i=
nclude any</div><div>testsuites an alternative could be to just add a simpl=
e cmd --help &gt; /dev/null=C2=A0</div><div>to atleast make sure the result=
ing binaries actually work.</div><div><br></div><div>If by any chance the i=
ncluded testsuites fail it would be nice if contributors</div><div>would tr=
y to fix them (send patches upstream) or else atleast indicate why they</di=
v><div>fail and add a message to the commit log and set options to include =
!check.</div><div><br></div><div>To actually gain attention regarding tests=
uites my suggestion would be to=C2=A0</div><div>require testsuites (abuild =
check) on our current CI. I wrote a small patch [1]</div><div>to let abuild=
 halt if check is not found (currently it only issues a warning).</div><div=
><br></div><div><br></div><div>1. <a href=3D"http://tpaste.us/40l1">http://=
tpaste.us/40l1</a></div><div><br></div><div><br></div><div>-carlo</div></di=
v>

--001a1144161ac7fe3b055c4b29d2--


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---