Subject: [alpine-devel] Re: [PATCH] Add DHCP to services.json

From: Jeremy Thomerson <[email-masked]>
Date: Mon, 11 Jun 2012 22:28:34 -0500

Anybody look at this yet?

On Mon, May 28, 2012 at 12:01 AM, Jeremy Thomerson <
[email-masked]> wrote:

> ---
>  json/services.json |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/json/services.json b/json/services.json
> index ff1e82b..0d7d3ec 100644
> --- a/json/services.json
> +++ b/json/services.json
> @@ -1,7 +1,8 @@
>  {
>   "service": {
> -    "babel": { "proto": "tcp", "port": 6697 },
> +    "babel": { "proto": "tcp", "port": 6697 },
>     "bgp": { "proto": "tcp", "port": 179 },
> +    "dhcp": { "proto": "udp", "port": [ "67", "68" ] },
>     "dns": [
>       { "proto": "udp", "port": 53 },
>       { "proto": "tcp", "port": 53 }
> --
> 1.7.3.1
>
>

---

From: Timo Teras <[email-masked]>
Date: Tue, 12 Jun 2012 07:39:03 +0300

Hi,

> > index ff1e82b..0d7d3ec 100644

Nit pick here, why is the line changed? Some whitespace change?

> >       { "proto": "tcp", "port": 53 }

Yes - we need something like this. Though, I wonder if we want to
enable this by default for interfaces. Same goes with ICMPv6 since that
is a requirement for IPv6 things to work. We'll try to figure out this
soon.

Then again - in either case, we might want to add explicit rules, so
this should likely go in anway. I also wonder if we want to keep this
as-is, or also add the related icmpv6 codes to service 'dhcp' too.

- Timo

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Jeremy Thomerson <[email-masked]>
Date: Tue, 12 Jun 2012 01:18:21 -0500

> Nit pick here, why is the line changed? Some whitespace change?

Yes - there was some whitespace error - I think tabulation was messed up or
something IIRC.

> as-is, or also add the related icmpv6 codes to service 'dhcp' too.

Yeah, I wasn't worried about adding a default rule.  I was just surprised
that when I added a rule in my config for service "dhcp" it didn't work and
I had to define it on my own.

JT