X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from jeremythomerson.com (unknown [74.117.189.39]) by mail.alpinelinux.org (Postfix) with ESMTP id 46C7FDC3507 for ; Tue, 12 Jun 2012 06:18:43 +0000 (UTC) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by jeremythomerson.com (Postfix) with ESMTP id 2C2681C766 for ; Tue, 12 Jun 2012 02:12:22 -0500 (CDT) Received: by wibhj8 with SMTP id hj8so2968270wib.7 for ; Mon, 11 Jun 2012 23:18:41 -0700 (PDT) Received: by 10.216.215.153 with SMTP id e25mr7845809wep.189.1339481921269; Mon, 11 Jun 2012 23:18:41 -0700 (PDT) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Reply-To: jeremy@thomersonfamily.com Received: by 10.223.7.9 with HTTP; Mon, 11 Jun 2012 23:18:21 -0700 (PDT) In-Reply-To: <20120612073903.21153926@vostro> References: <1338181266-5999-1-git-send-email-jeremy@thomersonfamily.com> <20120612073903.21153926@vostro> From: Jeremy Thomerson Date: Tue, 12 Jun 2012 01:18:21 -0500 Message-ID: Subject: Re: [alpine-devel] Re: [PATCH] Add DHCP to services.json To: Timo Teras Cc: alpine-devel@lists.alpinelinux.org Content-Type: multipart/alternative; boundary=0016e6d77c4c19af0304c24070a9 --0016e6d77c4c19af0304c24070a9 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Jun 11, 2012 at 11:39 PM, Timo Teras wrote: > Hi, > > On Mon, 11 Jun 2012 22:28:34 -0500 Jeremy Thomerson > wrote: > > > Anybody look at this yet? > > > > On Mon, May 28, 2012 at 12:01 AM, Jeremy Thomerson < > > jeremy@thomersonfamily.com> wrote: > > > > > --- > > > json/services.json | 3 ++- > > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > > > diff --git a/json/services.json b/json/services.json > > > index ff1e82b..0d7d3ec 100644 > > > --- a/json/services.json > > > +++ b/json/services.json > > > @@ -1,7 +1,8 @@ > > > { > > > "service": { > > > - "babel": { "proto": "tcp", "port": 6697 }, > > > + "babel": { "proto": "tcp", "port": 6697 }, > > Nit pick here, why is the line changed? Some whitespace change? > Yes - there was some whitespace error - I think tabulation was messed up or something IIRC. > > > "bgp": { "proto": "tcp", "port": 179 }, > > > + "dhcp": { "proto": "udp", "port": [ "67", "68" ] }, > > > "dns": [ > > > { "proto": "udp", "port": 53 }, > > > { "proto": "tcp", "port": 53 } > > > -- > > Yes - we need something like this. Though, I wonder if we want to > enable this by default for interfaces. Same goes with ICMPv6 since that > is a requirement for IPv6 things to work. We'll try to figure out this > soon. > Then again - in either case, we might want to add explicit rules, so > this should likely go in anway. I also wonder if we want to keep this > as-is, or also add the related icmpv6 codes to service 'dhcp' too. Yeah, I wasn't worried about adding a default rule. I was just surprised that when I added a rule in my config for service "dhcp" it didn't work and I had to define it on my own. JT --0016e6d77c4c19af0304c24070a9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Mon, Jun 11, 2012 at 11:39 PM, Timo T= eras <timo.teras@iki.fi> wrote:
Hi,

On Mon, 11 Jun 2012 22:28:34 -0500 Jeremy Thomerson
<jeremy@thomersonfamily.co= m> wrote:

> Anybody look at this yet?
>
> On Mon, May 28, 2012 at 12:01 AM, Jeremy Thomerson <
> jeremy@thomersonfamily.c= om> wrote:
>
> > ---
> > =A0json/services.json | =A0 =A03 ++-
> > =A01 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/json/services.json b/json/services.json
> > index ff1e82b..0d7d3ec 100644
> > --- a/json/services.json
> > +++ b/json/services.json
> > @@ -1,7 +1,8 @@
> > =A0{
> > =A0 "service": {
> > - =A0 =A0"babel": { "proto": "tcp",= "port": 6697 },
> > + =A0 =A0"babel": { "proto": "tcp",= "port": 6697 },

Nit pick here, why is the line changed? Some whitespace change?

Yes - there was some whitespace error - I th= ink tabulation was messed up or something IIRC.
=A0
> > =A0 =A0 "bgp": { "proto": &= quot;tcp", "port": 179 },
> > + =A0 =A0"dhcp": { "proto": "udp", = "port": [ "67", "68" ] },
> > =A0 =A0 "dns": [
> > =A0 =A0 =A0 { "proto": "udp", "port"= ;: 53 },
> > =A0 =A0 =A0 { "proto": "tcp", "port"= ;: 53 }
> > --

Yes - we need something like this. Though, I wonder if we want to
enable this by default for interfaces. Same goes with ICMPv6 since that
is a requirement for IPv6 things to work. We'll try to figure out this<= br> soon.=A0

Then again - in either case, we might want to add explicit rules, so
this should likely go in anway. I also wonder if we want to keep this
as-is, or also add the related icmpv6 codes to service 'dhcp' too.<= /blockquote>

Yeah, I wasn't worried about adding a d= efault rule. =A0I was just surprised that when I added a rule in my config = for service "dhcp" it didn't work and I had to define it on m= y own.

JT=A0
--0016e6d77c4c19af0304c24070a9-- --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---