X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail-ig0-f194.google.com (mail-ig0-f194.google.com [209.85.213.194]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id C97E9DC03FF for ; Fri, 28 Nov 2014 18:03:26 +0000 (UTC) Received: by mail-ig0-f194.google.com with SMTP id a13so1045322igq.9 for ; Fri, 28 Nov 2014 10:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=njLRLOpXshqs3ByAP1B4N6+Z+sFRXwIcVZi8bvjQUDA=; b=LEm6BUW8/rxMBXLwSYdRD4Qb+J9jYSdX4q8RodXmapjDrymltJ5YMh9Vh/VU6z1jDD 85BIXh7SE/K9NOBzPFRCGbwQAyqnvRObLpt0fYmtznWd+RXlEMJFvT4YF2qND5ISVOWH AGk/8Liy/BWL1P/+564OjxOVLKkA/y1my81n9MaSKl675zs2gJQpXDm1CTtBcvKYVgy0 qQKo6Pivj6w43nQ9bG88oOSNCOLIzA5dYTGUnp3fsQnwPUkeUTDKw8TOZgJ20v1bCF+e IVLkDQoWR6tyZJiNnJeCWxwBP5F1glgvebeV9knGdIDTrEvhoaVkEFqNajW9oaA2Z3gK EHlQ== X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 X-Received: by 10.42.146.201 with SMTP id k9mr36705725icv.54.1417197805892; Fri, 28 Nov 2014 10:03:25 -0800 (PST) Received: by 10.107.4.133 with HTTP; Fri, 28 Nov 2014 10:03:25 -0800 (PST) Date: Fri, 28 Nov 2014 18:03:25 +0000 Message-ID: Subject: Re: [alpine-devel] [PATCH] main/backuppc: Added initd script, small fixes and cleaned up From: k0r10n To: Natanael Copa Cc: Alpine-devel Content-Type: multipart/alternative; boundary=90e6ba613b66cbfa2f0508ef13ab --90e6ba613b66cbfa2f0508ef13ab Content-Type: text/plain; charset=UTF-8 Hi, there is final fix for BackupPC aport. I noticed $Conf{BackupPCUser} variable was not set after installing in /etc/BackupPC/config.pl, i added this to configure patch. Also after installing i've got o-rx on /etc,/var/lib and /var/log folders (fix is in APKBUILD file). And i added initd script, because it wasn't in package and added samba-client to depends, because initd script failed to start without smbclient. >From 6f8b6a96a138761d18e5d942006752d183f772a8 Mon Sep 17 00:00:00 2001 From: k0r10n Date: Fri, 28 Nov 2014 20:27:12 +0400 Subject: [PATCH] main/backuppc: Fix permissions and edited patch --- main/backuppc/APKBUILD | 50 ++++++++++++++++++++++++++---- ------- main/backuppc/backuppc.initd | 4 +++ main/backuppc/backuppc.post-install | 7 ------ main/backuppc/configure.pl.patch | 15 ++++++----- 4 files changed, 49 insertions(+), 27 deletions(-) delete mode 100644 main/backuppc/backuppc.post-install diff --git a/main/backuppc/APKBUILD b/main/backuppc/APKBUILD index 08f8206..e05a817 100644 --- a/main/backuppc/APKBUILD +++ b/main/backuppc/APKBUILD @@ -4,25 +4,34 @@ pkgname="backuppc" _realname="BackupPC" pkgver=3.3.0 _realver=$pkgver -pkgrel=1 +pkgrel=2 pkgdesc="High-performance, enterprise-grade backup system" url="http://backuppc.sourceforge.net/" arch="noarch" license="GPL2+" depends="perl busybox rsync perl-archive-zip perl-io-compress - perl-libwww perl-file-rsync" + perl-libwww perl-file-rsync samba-client" +pkgusers="backuppc" +pkggroups="backuppc" makedepends="" -install="$pkgname.pre-install $pkgname.post-install" +install="$pkgname.pre-install" subpackages="" source=" http://downloads.sourceforge.net/project/$pkgname/$pkgname/$_realver/$_realname-$_realver.tar.gz - configure.pl.patch" + configure.pl.patch + backuppc.initd + " _builddir="$srcdir/$_realname-$_realver" -prepare () { +prepare() { cd "$_builddir" - mkdir -p "$pkgdir"/etc/BackupPC - mkdir -p "$pkgdir"/var/www/cgi-bin - patch -p2 < ../../configure.pl.patch + for i in $source; do + case $i in + *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;; + esac + done + mkdir -p "$pkgdir"/etc/BackupPC \ + "$pkgdir"/var/www/cgi-bin \ + "$pkgdir"/var/www/htdocs/BackupPC || return 1 } build() { @@ -43,7 +52,7 @@ package() { --bin-path perl=/usr/bin/perl \ --bin-path ping=/bin/ping \ --bin-path rsync=/usr/bin/rsync \ - --bin-path sendmail=/usr/bin/sendmail \ + --bin-path sendmail=/usr/sbin/sendmail \ --bin-path smbclient=/usr/bin/smbclient \ --bin-path split=/usr/bin/split \ --bin-path ssh=/usr/bin/ssh \ @@ -60,15 +69,28 @@ package() { --uid-ignore \ --no-set-perms || return 1 - install -m755 configure.pl "$pkgdir"/usr/lib/BackupPC/bin/ configure.pl + install -m755 configure.pl \ + "$pkgdir"/usr/lib/BackupPC/bin/configure.pl || return 1 + install -D -m755 "$srcdir"/backuppc.initd \ + "$pkgdir"/etc/init.d/backuppc || return 1 - chmod 774 "$pkgdir"/usr/lib/BackupPC/bin/* + chmod 775 "$pkgdir"/usr/lib/BackupPC/bin/* + + for dir in etc var/log var/lib;do + chown -R backuppc.backuppc ${pkgdir}/${dir}/BackupPC + chmod 755 "$pkgdir/$dir" + done + + ln -s /var/www/cgi-bin/BackupPC_Admin "$pkgdir"/var/www/htdocs/index.cgi || return 1 } md5sums="2942a31daeec7c7bb227d843b7846f38 BackupPC-3.3.0.tar.gz -f57ad7fdcce804f20f2fe82bee91e813 configure.pl.patch" +2a25b036d273ea67b69aa62e4cd7c28f configure.pl.patch +5f27ed84a9ca11cba0bb5665faddca4b backuppc.initd" sha256sums="8a9c1b6faa4502b4c40617be97e806813815d9e22544854d99983c3da7c1f69b BackupPC-3.3.0.tar.gz -f07039e6bf25fc19bc0bc894d6dd6ff0348612a95a24e68b181da94b9f5ddd0c configure.pl.patch" +86988fbe8e8763abee8861f5bb03bf6bb7fd2430623f78fc921502b6759ad48d configure.pl.patch +ae3c6080c1ff4f5a42efbe533b20f02b9770e21f0e36c66879576683fcdda6b1 backuppc.initd" sha512sums="67ec1ca4d22ab1e81f9c0f409c758347a6c772e3d1aa39c93207f9d32817 6ac7b4e679d0b03972fc5870c37dde0480d28c61ae19975d54e144235ea0e84e9901 BackupPC-3.3.0.tar.gz -7ea98de0960cd0ea4f64e71c61e4565a73db2fd872d2f102dc08543ad60e b1cf986b9c0a32b7b4694dc9a8ffe2cd6bd7ca3ff2cc0b4d91961952664b62881faf configure.pl.patch" +a38361fd0e54a4c0100a7bf94b09483e5ba246dc45d6955d275542dd5662 d8da11d9580685195b7d4dfa9a07c0487a52a14a95340737e70889ffe5c5e26d5ff8 configure.pl.patch +96583fa711e1a92979d6ad60936d430e0b2b8138b8923d3727e86310ed73 b93ae25306294c230c9e7a4560379b58c6ecccf37591d3fe5f920e29b0c7525b488b backuppc.initd" diff --git a/main/backuppc/backuppc.initd b/main/backuppc/backuppc.initd index 850e6ae..ac1f36a 100644 --- a/main/backuppc/backuppc.initd +++ b/main/backuppc/backuppc.initd @@ -1,4 +1,8 @@ #!/sbin/runscript +BACKUPPC_BINDIR=/usr/lib/BackupPC/bin +DAEMON=BackupPC +BACKUPPC_LOGDIR=/var/log/BackupPC +USER=backuppc depend() { after firewall modules diff --git a/main/backuppc/backuppc.post-install b/main/backuppc/backuppc.post-install deleted file mode 100644 index f4b5a58..0000000 --- a/main/backuppc/backuppc.post-install +++ /dev/null @@ -1,7 +0,0 @@ -#!/bin/sh -for dir in /etc /var/log /var/lib -do - chown -R backuppc.backuppc ${dir}/BackupPC &>/dev/null -done - -ln -s /var/www/htdocs/BackupPC/index.cgi /var/www/cgi-bin/BackupPC_Admin &>/dev/null diff --git a/main/backuppc/configure.pl.patch b/main/backuppc/configure.pl. patch index 24d5e3b..67c2892 100644 --- a/main/backuppc/configure.pl.patch +++ b/main/backuppc/configure.pl.patch @@ -1,6 +1,6 @@ ---- src/BackupPC-3.2.0beta1/configure.pl -+++ configure.pl -@@ -327,25 +327,8 @@ +--- BackupPC-3.3.0.orig/configure.pl ++++ BackupPC-3.3.0/configure.pl +@@ -327,25 +327,11 @@ EOF my($name, $passwd, $Uid, $Gid); @@ -9,6 +9,9 @@ - $Conf{BackupPCUser} || "backuppc", - "backuppc-user"); - if ( $opts{"set-perms"} ) { ++ $Conf{BackupPCUser} = prompt("--> BackupPC should run as user", ++ $Conf{BackupPCUser} || "backuppc", ++ "backuppc-user"); ($name, $passwd, $Uid, $Gid) = getpwnam($Conf{BackupPCUser}); - last if ( $name ne "" ); - print <: > On Wed, 26 Nov 2014 09:01:05 +0400 > k0r10n wrote: > > > --- > > main/backuppc/APKBUILD | 38 > ++++++++++++++++++++++++------------- > > main/backuppc/backuppc.initd | 4 ++++ > > main/backuppc/backuppc.post-install | 4 ++-- > > main/backuppc/configure.pl.patch | 4 ++-- > > 4 files changed, 33 insertions(+), 17 deletions(-) > > > > I have a few questions below. > > ... > > > --- a/main/backuppc/backuppc.post-install > > +++ b/main/backuppc/backuppc.post-install > > @@ -1,7 +1,7 @@ > > #!/bin/sh > > -for dir in /etc /var/log /var/lib > > +for dir in /etc /var/log /var/lib /usr/lib > > do > > chown -R backuppc.backuppc ${dir}/BackupPC &>/dev/null > > done > > permissions of files should be set in the .apk itself and not in > post-install. Only exception is /var/run and /run which should be set > from init.d script with 'checkpath' > > Other question is, why does /usr/lib/BackupPC be owned by backuppc > user? /usr should generally be considered as read-only area. > > > > > > -ln -s /var/www/htdocs/BackupPC/index.cgi > /var/www/cgi-bin/BackupPC_Admin &>/dev/null > > +ln -s /var/www/cgi-bin/BackupPC_Admin > /var/www/htdocs/BackupPC/index.cgi &>/dev/null > > Symlinks should generally be created in .apk and not in post-install. > > Is it possible to get rid of the post-install script? > > > -nc > --90e6ba613b66cbfa2f0508ef13ab Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi, there is final fix for BackupPC aport. I noticed $Conf{BackupPCU= ser} variable
was not set = after installing in /etc/BackupPC/config.= pl, i added= this to configure patch.
= Also after installing i've got o-rx on /etc,/var/lib and /var/log folde= rs (fix is in APKBUILD file). And i added initd script, because it wasn'= ;t in package and added samba-client to depends, because initd script faile= d to start without smbclient.

From 6f8b6a96a138761d18e5d942006752d183f772a8 Mon Sep= 17 00:00:00 2001
From: k0= r10n <k0r10n.dev@gmail.com>
Date: Fri, 28 Nov 2014 20:27:12 +0400
Subject: [PATCH] main/backuppc: Fix perm= issions and edited patch

---
=C2=A0main/backuppc/APKBUILD=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 50 ++++++++++++++++++++++++++----<= /span>-------
=C2=A0main/backuppc/backup= pc.initd=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 4 +++
=C2=A0main/backuppc/backuppc.post-install |=C2=A0 7 ------<= /span>
=C2=A0main/backuppc/configure.pl.patch=C2=A0 =C2=A0 | 15 ++++++-----
=C2=A04 files changed, 49 inse= rtions(+), 27 deletions(-)
=C2=A0delete mode 100644 main/backuppc/backuppc.post-install

diff --git a/main/backuppc/APKBUILD b/main/backuppc/APKBUILD
index 08f8206..e05a817 100644=
--- a/main/backuppc/APKBU= ILD
+++ b/main/backuppc/AP= KBUILD
@@ -4,25 +4,34 @@ p= kgname=3D"backuppc"
=C2=A0_realname=3D"BackupPC"
=C2=A0pkgver=3D3.3.0
=C2=A0_realver=3D$pkgver
-pkgrel=3D1
+pk= grel=3D2
=C2=A0pkgdesc=3D&= quot;High-performance, enterprise-grade backup system"
=C2=A0url=3D"http://backuppc.sourceforge.net/"
=C2=A0arch=3D"noarch"
=C2=A0license=3D"GPL2+"
=C2=A0depends=3D"perl busy= box rsync perl-archive-zip perl-io-compress
-=C2=A0 =C2=A0 =C2=A0 =C2=A0perl-libwww perl-file-rsync&q= uot;
+=C2=A0 =C2=A0 =C2=A0= =C2=A0perl-libwww perl-file-rsync samba-client"
+pkgusers=3D"backuppc"
+pkggroups=3D"backuppc"=
=C2=A0makedepends=3D""=
-install=3D"$pkgname= .pre-install $pkgname.post-install"
+install=3D"$pkgname.pre-install"
=C2=A0subpackages=3D""
=C2=A0source=3D"http://downloads.sourceforge.net/project/$pkgname/$pkgnam= e/$_realver/$_realname-$_realver.tar.gz
-=C2=A0 =C2=A0 =C2=A0 =C2=A0configure.pl.patch"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0configure= .pl.patch
<= span style=3D"font-family:arial,sans-serif;font-size:13px">+=C2=A0 =C2=A0 = =C2=A0 =C2=A0backuppc.initd
+=C2=A0 =C2=A0 =C2=A0 =C2=A0"

=C2=A0= _builddir=3D"$srcdir/$_realname-$_realver"
-prepare () {
+prepare() {
=C2=A0= =C2=A0 =C2=A0 =C2=A0 cd "$_builddir"
-=C2=A0 =C2=A0 =C2=A0 =C2=A0mkdir -p "$pkgdir&qu= ot;/etc/BackupPC
-=C2=A0 = =C2=A0 =C2=A0 =C2=A0mkdir -p "$pkgdir"/var/www/cgi-bin
-=C2=A0 =C2=A0 =C2=A0 =C2=A0patch -p= 2 < ../../configure.pl.patch
+=C2=A0 =C2=A0 =C2=A0 =C2=A0for i in $source; do
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0case $i in
+=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*.patch) msg $i; patch = -p1 -i "$srcdir"/$i || return 1;;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0e= sac
+=C2=A0 =C2=A0 =C2=A0 = =C2=A0done
= +=C2=A0 =C2=A0 = =C2=A0 =C2=A0mkdir -p "$pkgdir"/etc/BackupPC \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 "$pkgdir"/var/www/cgi-bin \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 "$pkgdir"/var/www/htdocs/BackupPC || return 1
=C2=A0}

=C2= =A0build() {
@@ -43,7 +52,= 7 @@ package() {
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0--bin-path perl=3D/usr/bin/perl \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--bin-= path ping=3D/bin/ping \
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--bin-path rsync=3D/usr/bin/rsync \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 --= bin-path sendmail=3D/usr/bin/sendmail \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 --bin-path sendmail=3D/usr/sbin/= sendmail \
= =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0--bin-path smbclient=3D/usr/bin/smbclient \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--b= in-path split=3D/usr/bin/split \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--bin-path ssh=3D/usr/bin/ssh \
@@ -60,15 +69,28 @@ packag= e() {
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0--uid-ignore \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--no-set-perms || return 1

-=C2=A0 =C2=A0 =C2=A0 =C2=A0install -m755=C2=A0= configure.pl=C2=A0"$pkgdir"/usr/lib/BackupPC/<= /span>bin/configure.pl
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -m755=C2=A0configure.pl=C2=A0\
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"$pkgd= ir"/usr/lib/BackupPC/bin/configure.pl= =C2=A0|| return= 1
+=C2=A0 =C2=A0 =C2=A0 = =C2=A0install -D -m755 "$srcdir"/backuppc.initd \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0"$pkgdir"/etc/init.d/backuppc || return 1=

-=C2=A0 =C2=A0 =C2=A0 =C2=A0chmod 774 "$pkgd= ir"/usr/lib/BackupPC/bin/*
+= =C2=A0 =C2=A0 =C2=A0 =C2=A0chmod 775 "$pkgdir"/usr/lib/BackupPC/<= /span>bin/*
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0for dir in etc var/log va= r/lib;do
+=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0chown -R backuppc.backuppc ${pkgdi= r}/${dir}/BackupPC
+=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0chmod 755 "$pkgdir/$d= ir"
+=C2=A0 =C2=A0 = =C2=A0 =C2=A0done
+=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0ln -= s /var/www/cgi-bin/BackupPC_Admin "$pkgdir"/var/www/htdocs/index.cgi || return 1<= /span>

=C2=A0}

= =C2=A0md5sums=3D"2942a31daeec7c7bb227d843b7846f38=C2=A0 BackupPC-3.3.0.tar.gz-f57ad7fdcce804f20f2fe82bee91e813=C2=A0 configure.= pl.patch"
+2a25b036d273ea67b6= 9aa62e4cd7c28f=C2=A0 configure.pl.patch
+5= f27ed84a9ca11cba0bb5665faddca4b=C2=A0 backuppc.initd"
=C2=A0sha256sums=3D"8a9c1b6faa4502b4c40617be97e806813815d9e22= 544854d99983c3da7c1f69b=C2=A0 BackupPC-3.3.0.tar.gz
-f07039e6bf25fc19bc0bc894d6dd6ff0348612a95a24e68b181da94b9f5ddd0c=C2=A0 configure= .pl.patch"
+86988fbe8e8763abe= e8861f5bb03bf6bb7fd2430623f78fc921502b6759ad48d=C2=A0 configure.pl.patch
+ae3c6080c1ff4f5a42efbe533b20f02b9770e21f0e36c66879576683fcd= da6b1=C2= =A0 backuppc.initd"
= =C2=A0sha512sums=3D"67ec1ca4d22ab1e81f9c0f409c758347a6c772e3d1aa39c93207f9d328176ac7b4e679d0b0= 3972fc5870c37dde0480d28c61ae19975d54e144235ea0e84e9901=C2=A0 BackupPC-3.3.0.tar.gz-7ea98de0960cd0ea4f64e71c61e4565a73db2fd872d2f102d= c08543ad60eb1cf986b9c0a32b7b4694dc9a8ffe2cd6bd7ca3ff2cc0b4d91961952664b62881faf=C2=A0 configure.p= l.patch"
+a38361fd0e54a4c0100= a7bf94b09483e5ba246dc45d6955d275542dd5662d8da11d9580685195b7d4dfa9a07c0487a52a14a95340737e70889ff= e5c5e26d= 5ff8=C2=A0 configure.pl.patch
+965= 83fa711e1a92979d6ad60936d430e0b2b8138b8923d3727e86310ed73b93ae25306294c230c9e7a4560379b58c6ecccf375= 91d3fe5f920e29b0c7525b488b=C2=A0 backuppc.initd"
diff --git a/main/backuppc/backuppc.initd b/main/backup= pc/backuppc.initd
index 85= 0e6ae..ac1f36a 100644
--- = a/main/backuppc/backuppc.initd
+++ b/main/backuppc/backuppc.initd
@@ -1,4 +1,8 @@
=C2=A0#!/sbin/runscript
+BACKUPPC_BINDIR=3D/usr/lib/BackupPC/bin
+DAEMON=3DBackupPC
+BACKUPPC_LOGDIR=3D/var/log/BackupPC
+USER=3Dbackuppc

=C2=A0depend() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 af= ter firewall modules
diff = --git a/main/backuppc/backuppc.post-install b/main/backuppc/backuppc.post-installdeleted file mode 100644
index f4b5a58..0000000
--- a/main/backuppc/backuppc.post-install
+++ /dev/null
@@ -1,7 +0,0 @@
-#!/bin/sh
-for dir in /etc /var/log /var/lib
-do
-=C2= =A0 chown -R backuppc.backuppc ${dir}/BackupPC &>/dev/null-done
-
-ln = -s /var/www/htdocs/BackupPC/index.cgi /var/www/cgi-bin/BackupPC_Admin &>/dev/null
diff --git a/main/backuppc= /configure.pl.patch b/main/backuppc/configure.pl.patch
index 24d5e3b..67c2892 100644
--- a/main/backuppc/configure= .pl.= patch
+++ b/main/backuppc/= configure.pl.patch
@@ -1,6 +1,6 @@
---- src/BackupPC-3.2.0beta1/configure.pl
-+++=C2=A0configure.pl
-@@ -327,25 +327,8 @@
+--- BackupPC-3.3.0.orig/= configure.pl
<= span style=3D"font-family:arial,sans-serif;font-size:13px">++++ BackupPC-3.= 3.0/configure.pl
+@@ -327,25 +327,11 @@

=C2=A0 EOF
=C2=A0 my(= $name, $passwd, $Uid, $Gid);
@@ -9,6 +9,9 @@
=C2=A0-= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$Conf{BackupPCUser} || "b= ackuppc",
=C2=A0-=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"backuppc-user");=
=C2=A0-=C2=A0 =C2=A0 if ( $opts{= "set-perms"} ) {
++=C2=A0 =C2=A0 =C2=A0 $Conf{BackupPCUser} =3D prompt("--> BackupP= C should run as user",
++=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$Conf{BackupPCUser} = || "backuppc",
+= +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"backuppc-user&quo= t;);
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ($name, $passwd, $Uid, $Gid) =3D getpwnam($Conf{BackupPCUser}= );
=C2=A0-=C2=A0 =C2=A0 = =C2=A0 =C2=A0 last if ( $name ne "" );
=C2=A0-=C2=A0 =C2=A0 =C2=A0 =C2=A0 print <<EOF= ;
@@ -26,7 +29,7 @@=
=C2=A0 print <<EOF;=

=C2=A0 Please specify an install directory for Ba= ckupPC.=C2=A0 This is where the
-@@ -532,12 +515,6 @@
+@@ -532,12 +518,6 @@
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0) ) {<= br style=3D"font-family:arial,sans-serif;font-size:13px">=C2=A0 =C2=A0 =C2=A0 next if ( -d= "$DestDir$Conf{InstallDir}/$dir" );
=C2=A0 =C2=A0 =C2=A0 mkpath("$DestDir$Conf{InstallDir}/$dir"= , 0, 0755);
@@ -39,7 +42,7= @@
=C2=A0 }

=C2=A0 #
-@@ -546,11 +523,6 @@
+@= @ -546,11 +526,6 @@
=C2=A0= foreach my $dir ( ($Conf{CgiImageDir}) ) {
=C2=A0 =C2=A0 =C2=A0 next if ( $dir eq "" || -d= "$DestDir$dir" );
=C2=A0 =C2=A0 =C2=A0 mkpath("$DestDir$dir", 0, 0755);@@ -51,7 +54,7 @@
=C2=A0 }

= =C2=A0 #
-@@ -566,12 +538,= 6 @@
+@@ -566,12 +541,6 @@=
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 "$Conf{LogDir}",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ) ) {=C2=A0 =C2=A0 =C2=A0 mkpath("= $DestDir$dir", 0, 0750) if ( !-d "$DestDir$dir" );

2014-11-26 12:13= GMT+00:00 Natanael Copa <ncopa@alpinelinux.org>:
On Wed, 26 Nov 2014 09:01:05 += 0400
k0r10n <k0r10n.dev@gmail.com= > wrote:

> ---
>=C2=A0 main/backuppc/APKBUILD=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 38 ++++++++++++++++++++++++-------------
>=C2=A0 main/backuppc/backuppc.initd=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 = 4 ++++
>=C2=A0 main/backuppc/backuppc.post-install |=C2=A0 4 ++--
>=C2=A0 main/backuppc/configure.pl.patch=C2=A0 =C2=A0 |=C2=A0 4 ++--
>=C2=A0 4 files changed, 33 insertions(+), 17 deletions(-)
>

I have a few questions below.

...

> --- a/main/backuppc/backuppc.post-install
> +++ b/main/backuppc/backuppc.post-install
> @@ -1,7 +1,7 @@
>=C2=A0 #!/bin/sh
> -for dir in /etc /var/log /var/lib
> +for dir in /etc /var/log /var/lib /usr/lib
>=C2=A0 do
>=C2=A0 =C2=A0 chown -R backuppc.backuppc ${dir}/BackupPC &>/dev/= null
>=C2=A0 done

permissions of files should be set in the .apk itself and not in
post-install. Only exception is /var/run and /run which should be set
from init.d script with 'checkpath'

Other question is, why does /usr/lib/BackupPC be owned by backuppc
user? /usr should generally be considered as read-only area.


>
> -ln -s /var/www/htdocs/BackupPC/index.cgi /var/www/cgi-bin/BackupPC_Ad= min &>/dev/null
> +ln -s /var/www/cgi-bin/BackupPC_Admin /var/www/htdocs/BackupPC/index.= cgi &>/dev/null

Symlinks should generally be created in .apk and not in post-install= .

Is it possible to get rid of the post-install script?


-nc

--90e6ba613b66cbfa2f0508ef13ab-- --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---