Precedence: list
MIME-Version: 1.0
In-Reply-To: <20131127143028.51c1fd9f@vostro>
References: <1385553044-19328-1-git-send-email-eivind@uggedal.com>
	<20131127143028.51c1fd9f@vostro>
Date: Wed, 27 Nov 2013 15:55:07 +0100
Message-ID: <CAM-O=1CbumX97tuU148DsM-UcBkByTfmn8gNRvnvh0n-ihzUQQ@mail.gmail.com>
Subject: Re: [alpine-devel] [PATCH] main/git: bash-completion subpackage
From: Eivind Uggedal <eivind@uggedal.com>
To: Timo Teras <timo.teras@iki.fi>
Cc: alpine-devel@lists.alpinelinux.org
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Nov 27, 2013 at 1:30 PM, Timo Teras <timo.teras@iki.fi> wrote:
>
> On Wed, 27 Nov 2013 11:50:44 +0000
> Eivind Uggedal <eivind@uggedal.com> wrote:
>
> > @@ -75,6 +75,16 @@ svn() {
> >          mv "$pkgdir"/usr/libexec/git-core/git-svn
> > "$subpkgdir"/usr/libexec/git-core }
> >
> > +completion() {
> > +     depends=""
> > +     pkgdesc="Bash completion script for git"
> > +     arch="noarch"
> > +     replaces=""
> > +
>
> Would it make sense to have here install_if="git bash" or
> install_if="git bash-completion" or similar?

I didn't know about `install_if`. Seems it's used sparsely in the
aports repo. But it would be nice to pull in the completion packages
if one have bash-completion installed.

By this logic, should default_doc add an install_if="man"?

Eivind


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---