MIME-Version: 1.0
References: <CAN2Hq04c2HHFPUDPZ05SUw3JGZ2R=Oa_eUXUy91Ymk7tW-1jRw@mail.gmail.com>
 <BX958MTNMQUI.YLWRH1E4JGO3@homura>
In-Reply-To: <BX958MTNMQUI.YLWRH1E4JGO3@homura>
From: Richard Mortier <mort@cantab.net>
Date: Wed, 25 Sep 2019 15:28:39 +0100
Message-ID: <CAN2Hq07jJTNLFxpOFX-nemkiCt9Z-hK9NJbsx-h81mJrnsAMbg@mail.gmail.com>
Subject: Re: [alpine-devel] [PATCH alpine-conf] Support encrypted root in setup-disk
To: Drew DeVault <sir@cmpwn.com>
Cc: ~alpine/devel@lists.alpinelinux.org, Natanael Copa <ncopa@alpinelinux.org>, 
	=?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@iki.fi>
Content-Type: text/plain; charset="UTF-8"

Ah ok; FWIW I didn't interpret it like that.

I think the only other query I'd have is whether that interactive
block can be entered even if the user has specified -e -- if so, seems
odd to ask when they've already told you.

On Wed, 25 Sep 2019 at 15:13, Drew DeVault <sir@cmpwn.com> wrote:
>
> On Wed Sep 25, 2019 at 3:11 PM Richard Mortier wrote:
> > One other query - I don't understand the #TODO message...?
>
> The if statement it's TODO'ing skips prompting the user for encryption
> if they're using LVM or a non-sys disk setup. The task that remains to
> be done is tweaking the crypt support to support setting up encrypted
> disks for any case other than the basic one.



-- 
Richard Mortier
mort@cantab.net